From: Andrei Borzenkov <arvidjaar@gmail.com>
To: Felix Janda <felix.janda@posteo.de>
Cc: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: grub-core/osdep/unix/hostdisk.c: remove support for ancient glibc
Date: Fri, 5 Dec 2014 14:52:29 +0300 [thread overview]
Message-ID: <20141205145229.7bc61b61@opensuse.site> (raw)
In-Reply-To: <20141204222109.GA30539@euler>
В Thu, 4 Dec 2014 23:21:09 +0100
Felix Janda <felix.janda@posteo.de> пишет:
> On 28.11.2014, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> > On 21.11.2014 22:00, Felix Janda wrote:
> > > Hello,
> > >
> > > the file grub-core/osdep/unix/hostdisk.c has special code for glibc<2.1,
> > > which gets also pulled in for other libcs (such as musl libc) and makes
> > > compilation fail for them because the code uses glibc internals. The
> > > easiest way to fix is just to remove the code as the below patch does.
> > >
> > Don't assume that nobody will try to compile with ancient glibc. If you
> > want to raise the supported version for glibc you need to add a
> > configure check for presence of long offsets to configure and fail it if
> > it's not available. It should also be documented in INSTALL.
>
> Before messing around with configure.ac, I'd like know whether a patch
> (correctly) implementing what you suggest would be accepted.
>
> Another solution I would be happy with, is to change the conditions
>
> # if !defined(__GLIBC__) || \
> ((__GLIBC__ < 2) || ((__GLIBC__ == 2) && (__GLIBC_MINOR__ < 1)))
>
> to
>
> # ((__GLIBC__ < 2) || ((__GLIBC__ == 2) && (__GLIBC_MINOR__ < 1)))
>
This will likely result in build error if __GLIBC__ is undefined.
> Felix
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
next prev parent reply other threads:[~2014-12-05 11:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 20:00 grub-core/osdep/unix/hostdisk.c: remove support for ancient glibc Felix Janda
2014-11-22 8:59 ` Felix Janda
2014-11-27 14:34 ` Andrei Borzenkov
2014-11-27 22:27 ` Felix Janda
2014-11-28 19:18 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-12-04 22:21 ` Felix Janda
2014-12-05 11:52 ` Andrei Borzenkov [this message]
2014-12-05 17:50 ` Felix Janda
2014-12-07 16:24 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141205145229.7bc61b61@opensuse.site \
--to=arvidjaar@gmail.com \
--cc=felix.janda@posteo.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).