From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XwrRJ-00068d-3D for mharc-grub-devel@gnu.org; Fri, 05 Dec 2014 06:52:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwrR9-0005yB-Vj for grub-devel@gnu.org; Fri, 05 Dec 2014 06:52:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwrR3-0003rM-AK for grub-devel@gnu.org; Fri, 05 Dec 2014 06:52:39 -0500 Received: from mail-lb0-x233.google.com ([2a00:1450:4010:c04::233]:46556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwrR3-0003r8-2J for grub-devel@gnu.org; Fri, 05 Dec 2014 06:52:33 -0500 Received: by mail-lb0-f179.google.com with SMTP id z11so402811lbi.10 for ; Fri, 05 Dec 2014 03:52:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=EvFetUolmadAy85qRUqVc0okwtfwAeI9DbXazZ4YjIs=; b=geMbtGd8LtIDIdOLJoYeb+mkERccaB9nQkBTk9FTkHGz6d9p5d4J6njptbJceGzBPl bW1KoTaRfXVu1gs3iT6FGJA/O0R+xkiM14mHc27vkgFzz2TyZZ51v/FGzu7IJhfHpE2U 3gr0xGHVKr921UYmP3Iqc32cRY7xyRyqDPzHEGKTiT/OUMoWackmdXMHIvHjb1pNp/fN Lw4BezhrlPKM0phWc/kgF2piGpDwcx1k5FIhQGiIUjDjB0zWS9lqcnVUtExZ/skUdtC4 XylHwI0tu7QCyfX1EjgJqO1r1Y/pXNE4HX9QDHVabnEur5D6PjrV/3beCFggwTYWkpoU 1HBw== X-Received: by 10.112.180.198 with SMTP id dq6mr2482109lbc.56.1417780352156; Fri, 05 Dec 2014 03:52:32 -0800 (PST) Received: from opensuse.site (ppp91-76-15-25.pppoe.mtu-net.ru. [91.76.15.25]) by mx.google.com with ESMTPSA id xn9sm8262359lbb.25.2014.12.05.03.52.30 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Dec 2014 03:52:31 -0800 (PST) Date: Fri, 5 Dec 2014 14:52:29 +0300 From: Andrei Borzenkov To: Felix Janda Subject: Re: grub-core/osdep/unix/hostdisk.c: remove support for ancient glibc Message-ID: <20141205145229.7bc61b61@opensuse.site> In-Reply-To: <20141204222109.GA30539@euler> References: <20141121200040.GA4858@euler> <5478CA6D.9020904@gmail.com> <20141204222109.GA30539@euler> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.25; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::233 Cc: The development of GNU GRUB X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Dec 2014 11:52:45 -0000 =D0=92 Thu, 4 Dec 2014 23:21:09 +0100 Felix Janda =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On 28.11.2014, Vladimir '=CF=86-coder/phcoder' Serbinenko wrote: > > On 21.11.2014 22:00, Felix Janda wrote: > > > Hello, > > >=20 > > > the file grub-core/osdep/unix/hostdisk.c has special code for glibc<2= .1, > > > which gets also pulled in for other libcs (such as musl libc) and mak= es > > > compilation fail for them because the code uses glibc internals. The > > > easiest way to fix is just to remove the code as the below patch does. > > >=20 > > Don't assume that nobody will try to compile with ancient glibc. If you > > want to raise the supported version for glibc you need to add a > > configure check for presence of long offsets to configure and fail it if > > it's not available. It should also be documented in INSTALL. >=20 > Before messing around with configure.ac, I'd like know whether a patch > (correctly) implementing what you suggest would be accepted. >=20 > Another solution I would be happy with, is to change the conditions >=20 > # if !defined(__GLIBC__) || \ > ((__GLIBC__ < 2) || ((__GLIBC__ =3D=3D 2) && (__GLIBC_MINOR__ < 1= ))) >=20 > to >=20 > # ((__GLIBC__ < 2) || ((__GLIBC__ =3D=3D 2) && (__GLIBC_MINOR__ < 1))) >=20 This will likely result in build error if __GLIBC__ is undefined. > Felix >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel