Re: Query about GRUB_ENABLE_CRYPTODISK

[Andrei Borzenkov <arvidjaar@gmail.com>]

В Tue, 09 Dec 2014 23:27:49 +0000
Barry Jackson <zen25000@zen.co.uk> пишет:

> On 09/12/14 22:36, Barry Jackson wrote:
> > On 09/12/14 18:27, Andrei Borzenkov wrote:
> >> В Tue, 09 Dec 2014 12:35:20 +0000
> >> Barry Jackson <zen25000@zen.co.uk> пишет:
> >>
> >>> Hello,
> >>> In Mageia it has been proposed that GRUB_ENABLE_CRYPTODISK=y be made the
> >>> default setting in /etc/default/grub for all installations, whether they
> >>> use encryption or not.
> >>
> >> The discussion happens every now and then.
> >>
> >> http://lists.gnu.org/archive/html/grub-devel/2013-12/msg00112.html
> >
> > OK, thanks for the link.
> >
> > In the case of Mageia the default installation puts everything required
> > by grub under /boot, so AFAICT this should not cause a problem.
> 
> ... but it does.
> 
> I found time to do some testing, and adding it to the config on a system 
> with no encryption at all causes an error message:
> error: device name required.
> 
> this seems to be triggered by this line which grub-mkconfig adds to 
> grub.cfg:
> 
> cryptomount -u
> 

Does patch below help?

From: Andrei Borzenkov <arvidjaar@gmail.com>
Subject: [PATCH] do not emit cryptomount without crypto UUID

---
 util/grub-mkconfig_lib.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/grub-mkconfig_lib.in b/util/grub-mkconfig_lib.in
index 29ef865..60b31ca 100644
--- a/util/grub-mkconfig_lib.in
+++ b/util/grub-mkconfig_lib.in
@@ -145,7 +145,7 @@ prepare_grub_to_access_device ()
   done
 
   if [ x$GRUB_ENABLE_CRYPTODISK = xy ]; then
-      for uuid in "`"${grub_probe}" --device $@ --target=cryptodisk_uuid`"; do
+      for uuid in `"${grub_probe}" --device $@ --target=cryptodisk_uuid`; do
 	  echo "cryptomount -u $uuid"
       done
   fi
-- 
tg: (bac5d1a..) u/mkconfig-cryptomount (depends on: master)