From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XyXuq-000341-33 for mharc-grub-devel@gnu.org; Tue, 09 Dec 2014 22:26:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyXuj-000321-Ce for grub-devel@gnu.org; Tue, 09 Dec 2014 22:26:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyXue-00009K-R8 for grub-devel@gnu.org; Tue, 09 Dec 2014 22:26:09 -0500 Received: from mail-lb0-x230.google.com ([2a00:1450:4010:c04::230]:55719) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyXue-00009D-HQ for grub-devel@gnu.org; Tue, 09 Dec 2014 22:26:04 -0500 Received: by mail-lb0-f176.google.com with SMTP id p9so1651385lbv.35 for ; Tue, 09 Dec 2014 19:26:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=Jd3syszgcvZWIaT3XLJ5vpGxFrCJbRxuP+GWd7BNWPQ=; b=1CaZwQbYmcVpn/hua4RmYKBPCn7+HDiSIkOovIsWIFHMB1DPKNGmp7HmPV4NYqBx7l NaRkrSiqteeZi0JpoKtj6/dg2lE1HWYLAC/hDV2tOKvgkSNyvFtVIOgwJDUUh42BFuy4 xYuFdWH3ON31r5i2N96no2kxG3G//tsIb+DDLqc9CxyOgNjkFzrYT/178ibJ/NQwUTnf mX+np61m9bkIPp79UIOImqAF4y3amtMui9VRkFhKwtXeaMaXn0r+F1fZ1tvaAkci5TBh Pv2Fh27MSwZ8JOWo9FaLx0xF9s0WSZyy9Z9v6v+gpG50xoGpL9MglO22CpIRXm9Z1d7A SxKg== X-Received: by 10.112.24.130 with SMTP id u2mr1623799lbf.57.1418181962229; Tue, 09 Dec 2014 19:26:02 -0800 (PST) Received: from opensuse.site (ppp91-76-15-25.pppoe.mtu-net.ru. [91.76.15.25]) by mx.google.com with ESMTPSA id s8sm320378lae.47.2014.12.09.19.26.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Dec 2014 19:26:01 -0800 (PST) Date: Wed, 10 Dec 2014 06:25:58 +0300 From: Andrei Borzenkov To: Barry Jackson Subject: Re: Query about GRUB_ENABLE_CRYPTODISK Message-ID: <20141210062558.15524434@opensuse.site> In-Reply-To: <54878575.6090501@zen.co.uk> References: <5486EC88.1010908@zen.co.uk> <20141209212740.4d1f3ded@opensuse.site> <54877968.8030508@zen.co.uk> <54878575.6090501@zen.co.uk> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.25; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::230 Cc: grub-devel@gnu.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Dec 2014 03:26:14 -0000 =D0=92 Tue, 09 Dec 2014 23:27:49 +0000 Barry Jackson =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On 09/12/14 22:36, Barry Jackson wrote: > > On 09/12/14 18:27, Andrei Borzenkov wrote: > >> =D0=92 Tue, 09 Dec 2014 12:35:20 +0000 > >> Barry Jackson =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > >> > >>> Hello, > >>> In Mageia it has been proposed that GRUB_ENABLE_CRYPTODISK=3Dy be mad= e the > >>> default setting in /etc/default/grub for all installations, whether t= hey > >>> use encryption or not. > >> > >> The discussion happens every now and then. > >> > >> http://lists.gnu.org/archive/html/grub-devel/2013-12/msg00112.html > > > > OK, thanks for the link. > > > > In the case of Mageia the default installation puts everything required > > by grub under /boot, so AFAICT this should not cause a problem. >=20 > ... but it does. >=20 > I found time to do some testing, and adding it to the config on a system= =20 > with no encryption at all causes an error message: > error: device name required. >=20 > this seems to be triggered by this line which grub-mkconfig adds to=20 > grub.cfg: >=20 > cryptomount -u >=20 Does patch below help? From: Andrei Borzenkov Subject: [PATCH] do not emit cryptomount without crypto UUID --- util/grub-mkconfig_lib.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/grub-mkconfig_lib.in b/util/grub-mkconfig_lib.in index 29ef865..60b31ca 100644 --- a/util/grub-mkconfig_lib.in +++ b/util/grub-mkconfig_lib.in @@ -145,7 +145,7 @@ prepare_grub_to_access_device () done =20 if [ x$GRUB_ENABLE_CRYPTODISK =3D xy ]; then - for uuid in "`"${grub_probe}" --device $@ --target=3Dcryptodisk_uuid= `"; do + for uuid in `"${grub_probe}" --device $@ --target=3Dcryptodisk_uuid`= ; do echo "cryptomount -u $uuid" done fi --=20 tg: (bac5d1a..) u/mkconfig-cryptomount (depends on: master)