From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YCuKr-0004Nd-EA for mharc-grub-devel@gnu.org; Sun, 18 Jan 2015 13:12:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YCuKo-0004NQ-M1 for grub-devel@gnu.org; Sun, 18 Jan 2015 13:12:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YCuKj-0004uK-Qi for grub-devel@gnu.org; Sun, 18 Jan 2015 13:12:26 -0500 Received: from mx02.posteo.de ([89.146.194.165]:60912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YCuKj-0004u1-KE for grub-devel@gnu.org; Sun, 18 Jan 2015 13:12:21 -0500 Received: from dovecot03.posteo.de (unknown [185.67.36.28]) by mx02.posteo.de (Postfix) with ESMTPS id CDEBB237144; Sun, 18 Jan 2015 19:12:19 +0100 (CET) Received: from mail.posteo.de (localhost [127.0.0.1]) by dovecot03.posteo.de (Postfix) with ESMTPSA id 3kQPNg4RC9z5vMs; Sun, 18 Jan 2015 19:12:19 +0100 (CET) Date: Sun, 18 Jan 2015 19:11:08 +0100 From: Felix Janda To: Andrei Borzenkov Subject: Re: [PATCH] On linux require the libc to have large file support Message-ID: <20150118181107.GA6322@euler> References: <20150117135706.GA23804@euler> <20150118205320.14a5945f@opensuse.site> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150118205320.14a5945f@opensuse.site> User-Agent: Mutt/1.5.22 (2013-10-16) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 89.146.194.165 Cc: grub-devel@gnu.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jan 2015 18:12:28 -0000 Andrei Borzenkov wrote: > =D0=92 Sat, 17 Jan 2015 14:57:07 +0100 > Felix Janda =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >=20 > > With this, support code in grub-core/osdep/unix/hostdisk.c > > for old glibc releases could be removed. > > --- > > This patch tries to address the issues raised in > >=20 > > http://lists.gnu.org/archive/html/grub-devel/2014-12/msg00030.html > > --- > > INSTALL | 1 + > > configure.ac | 5 +++++ > > grub-core/osdep/unix/hostdisk.c | 25 ------------------------- > > 3 files changed, 6 insertions(+), 25 deletions(-) > >=20 > > diff --git a/INSTALL b/INSTALL > > index b67cd7f..ac7c2aa 100644 > > --- a/INSTALL > > +++ b/INSTALL > > @@ -39,6 +39,7 @@ configuring the GRUB. > > On GNU/Linux, you also need: > > =20 > > * libdevmapper 1.02.34 or later (recommended) > > +* a libc with large file support (e.g. glibc 2.1 or later) > > =20 > > For optional grub-emu features, you need: > > =20 > > diff --git a/configure.ac b/configure.ac > > index 31d2b0b..bdaebb8 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -346,6 +346,11 @@ AC_GNU_SOURCE > > AM_GNU_GETTEXT([external]) > > AC_SYS_LARGEFILE > > =20 > > +if test x"$host_kernel" =3D xlinux ; then >=20 > I wonder if we should do it unconditionally. Large files support is > really presumed by current code. >=20 > Not for now, but something to keep in mind for next version. Yes, the test is not ideal. But enabling it for everything would break cygwin. (There sizeof(off_t)=3D4 and the windows hostdisk.c is used.) It was not obvious for me how to detect all architectures that build grub-core/osdep/unix/hostdisk.c. It would also be possible to put something like int get_a_libc_with_lfs_support[sizeof(off_t)-8]; into grub-core/osdep/unix/hostdisk.c making at least the build fail for the right architectures. > > + AC_CHECK_SIZEOF(off_t) > > + test x"$ac_cv_sizeof_off_t" =3D x8 || AC_MSG_ERROR([Large file sup= port is required]) > > +fi > > + > > # Identify characteristics of the host architecture. > > unset ac_cv_c_bigendian > > =20 > > [..]