From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YEj7u-0005p8-B2 for mharc-grub-devel@gnu.org; Fri, 23 Jan 2015 13:38:38 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEj7r-0005nh-TA for grub-devel@gnu.org; Fri, 23 Jan 2015 13:38:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEj7m-0006oa-Li for grub-devel@gnu.org; Fri, 23 Jan 2015 13:38:35 -0500 Received: from mail-la0-x229.google.com ([2a00:1450:4010:c03::229]:45027) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEj7m-0006oQ-DS for grub-devel@gnu.org; Fri, 23 Jan 2015 13:38:30 -0500 Received: by mail-la0-f41.google.com with SMTP id gm9so8883729lab.0 for ; Fri, 23 Jan 2015 10:38:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type; bh=mNXbtxuFOYexhjnpGgu1g/VDl/OTuCGeHznuJs8Krws=; b=hvK3XHDaWbWdDCm0/dw4oj7lpgb+paABV4K6E7m8J2YPN2STyQF8euMibEewmgr95j q8NlWQNU3ivhPOCnUo5dJ/xZrMNSUamH7IHYJREH7PpVFxZb5L5mOMaJwxBHqdANjrlD tO0cwbvNhJP8VoU/+KZJfV7b+VcL6nYthxonNfRJDmoab/qVWCC/VnEk6/hRmKRiabcy +zYS5H+Y+U+++F5aMYGGv/tih21+dj2SFETucXsVAPiCrs6Zf8ofXpgesD2UmCksPn+K jcB7jipj06HPEW75PG7YTqe8VG3KJT9L2PVcUuh7kQqOy2AbPEf83VjAxB3PnVPpTRNr FDGw== X-Received: by 10.112.26.135 with SMTP id l7mr8763525lbg.56.1422038309650; Fri, 23 Jan 2015 10:38:29 -0800 (PST) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id ch1sm637128lbb.40.2015.01.23.10.38.28 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Jan 2015 10:38:28 -0800 (PST) Date: Fri, 23 Jan 2015 21:38:27 +0300 From: Andrei Borzenkov To: Vladimir =?UTF-8?B?J8+GLWNvZGVyL3BoY29kZXIn?= Serbinenko Subject: Re: Does grub-mkrescue support UEFI hybrid USB/DVD images? Message-ID: <20150123213827.6f4279cc@opensuse.site> In-Reply-To: <54C292F3.2020102@gmail.com> References: <54C16AD2.7090808@pcbsd.org> <54C17680.9080804@gmail.com> <54C21824.6060407@gmail.com> <20150123205839.1af3ce51@opensuse.site> <54C292F3.2020102@gmail.com> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.25; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/WfmKyPs77xkBhh.WIiHQJe1"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::229 Cc: The development of GNU GRUB X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2015 18:38:37 -0000 --Sig_/WfmKyPs77xkBhh.WIiHQJe1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =D0=92 Fri, 23 Jan 2015 19:29:07 +0100 Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: >=20 > > But returning (hd0,gpt2) would also be wrong here - ESP on CD image is > > empty, we need to somehow jump from ESP to full ISO image. > >=20 > Returning hd0,gpt2 is fine. By convention ()/file refers to parent disk > of whatever root partition is (as opposed to /file). Not sure I follow. If you include part_gpt, grub will set prefix to (hd0,gpt2)/boot/grub. But /boot/grub does NOT exist there - it exists on (hd0), so correct prefix is (hd0)/boot/grub. > So just including part_gpt in core should be enough. But perhaps we > should put my patch as well to increase reliability. Consider scenario > of installing on disk with gpt and apt and using apt partitions. GRUB > will properly detect that it needs part_apple but part_gpt is not needed > to access partition. > Most of the install tools specify partition explicitly, so having > partition is non-critical. Having disk on the hand is critical. >=20 > @Kris: Please try (after removing the other patch) > diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c > index e719839..e02340f 100644 > --- a/util/grub-mkrescue.c > +++ b/util/grub-mkrescue.c > @@ -653,6 +653,9 @@ main (int argc, char *argv[]) > char *efiimgfat; > grub_install_mkdir_p (efidir_efi_boot); >=20 > + grub_install_push_module ("part_gpt"); > + grub_install_push_module ("part_msdos"); > + > imgname =3D grub_util_path_concat (2, efidir_efi_boot, "bootia64.e= fi"); > make_image_fwdisk_abs (GRUB_INSTALL_PLATFORM_IA64_EFI, > "ia64-efi", imgname); > free (imgname); > @@ -713,6 +716,8 @@ main (int argc, char *argv[]) > free (efiimgfat); > free (efidir_efi); > free (efidir); > + grub_install_pop_module (); > + grub_install_pop_module (); > } >=20 > grub_install_push_module ("part_apple"); >=20 >=20 --Sig_/WfmKyPs77xkBhh.WIiHQJe1 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlTClSMACgkQR6LMutpd94yC5gCgzQmKjeCoVte6Riv3sOaPphJM HsEAn0HtgNl608B6O64qAMs3nXpw6h+c =Tq2T -----END PGP SIGNATURE----- --Sig_/WfmKyPs77xkBhh.WIiHQJe1--