From: Andrei Borzenkov <arvidjaar@gmail.com>
To: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
Cc: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: Does grub-mkrescue support UEFI hybrid USB/DVD images?
Date: Fri, 23 Jan 2015 22:03:23 +0300 [thread overview]
Message-ID: <20150123220323.3fc642f0@opensuse.site> (raw)
In-Reply-To: <20150123213827.6f4279cc@opensuse.site>
[-- Attachment #1: Type: text/plain, Size: 2205 bytes --]
В Fri, 23 Jan 2015 21:38:27 +0300
Andrei Borzenkov <arvidjaar@gmail.com> пишет:
> В Fri, 23 Jan 2015 19:29:07 +0100
> Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
>
> >
> > > But returning (hd0,gpt2) would also be wrong here - ESP on CD image is
> > > empty, we need to somehow jump from ESP to full ISO image.
> > >
> > Returning hd0,gpt2 is fine. By convention ()/file refers to parent disk
> > of whatever root partition is (as opposed to /file).
>
> Not sure I follow. If you include part_gpt, grub will set prefix to
> (hd0,gpt2)/boot/grub. But /boot/grub does NOT exist there - it exists
> on (hd0), so correct prefix is (hd0)/boot/grub.
>
Ah, OK, I see. Sorry.
> > So just including part_gpt in core should be enough. But perhaps we
> > should put my patch as well to increase reliability. Consider scenario
> > of installing on disk with gpt and apt and using apt partitions. GRUB
> > will properly detect that it needs part_apple but part_gpt is not needed
> > to access partition.
> > Most of the install tools specify partition explicitly, so having
> > partition is non-critical. Having disk on the hand is critical.
> >
> > @Kris: Please try (after removing the other patch)
Yes, it works.
> > diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c
> > index e719839..e02340f 100644
> > --- a/util/grub-mkrescue.c
> > +++ b/util/grub-mkrescue.c
> > @@ -653,6 +653,9 @@ main (int argc, char *argv[])
> > char *efiimgfat;
> > grub_install_mkdir_p (efidir_efi_boot);
> >
> > + grub_install_push_module ("part_gpt");
> > + grub_install_push_module ("part_msdos");
> > +
> > imgname = grub_util_path_concat (2, efidir_efi_boot, "bootia64.efi");
> > make_image_fwdisk_abs (GRUB_INSTALL_PLATFORM_IA64_EFI,
> > "ia64-efi", imgname);
> > free (imgname);
> > @@ -713,6 +716,8 @@ main (int argc, char *argv[])
> > free (efiimgfat);
> > free (efidir_efi);
> > free (efidir);
> > + grub_install_pop_module ();
> > + grub_install_pop_module ();
> > }
> >
> > grub_install_push_module ("part_apple");
> >
> >
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2015-01-23 19:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 21:25 Does grub-mkrescue support UEFI hybrid USB/DVD images? Kris Moore
2015-01-22 22:15 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-01-23 9:40 ` Andrei Borzenkov
2015-01-23 9:45 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-01-23 10:10 ` Andrei Borzenkov
2015-01-23 10:14 ` Thomas Schmitt
2015-01-23 14:40 ` Kris Moore
2015-01-23 16:18 ` Thomas Schmitt
2015-01-23 17:58 ` Andrei Borzenkov
2015-01-23 18:27 ` Thomas Schmitt
2015-01-23 18:29 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-01-23 18:38 ` Andrei Borzenkov
2015-01-23 19:03 ` Andrei Borzenkov [this message]
2015-01-24 0:12 ` adrian15
2015-01-25 8:03 ` adrian15
2015-01-25 8:15 ` adrian15
2015-01-25 10:51 ` adrian15
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123220323.3fc642f0@opensuse.site \
--to=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
--cc=phcoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).