From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YFSGq-0002lz-Hz for mharc-grub-devel@gnu.org; Sun, 25 Jan 2015 13:50:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFSGm-0002lT-Vg for grub-devel@gnu.org; Sun, 25 Jan 2015 13:50:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFSGi-0000ep-Pa for grub-devel@gnu.org; Sun, 25 Jan 2015 13:50:48 -0500 Received: from mx02.posteo.de ([89.146.194.165]:35170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFSGi-0000ef-Fo for grub-devel@gnu.org; Sun, 25 Jan 2015 13:50:44 -0500 Received: from dovecot03.posteo.de (unknown [185.67.36.28]) by mx02.posteo.de (Postfix) with ESMTPS id A2E5A25AF515 for ; Sun, 25 Jan 2015 19:50:42 +0100 (CET) Received: from mail.posteo.de (localhost [127.0.0.1]) by dovecot03.posteo.de (Postfix) with ESMTPSA id 3kVjvk2mjYz5vN5 for ; Sun, 25 Jan 2015 19:50:42 +0100 (CET) Date: Sun, 25 Jan 2015 19:49:23 +0100 From: Felix Janda To: The development of GNU GRUB Subject: Re: [PATCH] On linux require the libc to have large file support Message-ID: <20150125184922.GA705@euler> References: <20150117135706.GA23804@euler> <20150118205320.14a5945f@opensuse.site> <20150118181107.GA6322@euler> <20150118181807.GA16297@euler> <54C147F4.9030506@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <54C147F4.9030506@gmail.com> User-Agent: Mutt/1.5.22 (2013-10-16) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 89.146.194.165 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Jan 2015 18:50:50 -0000 Vladimir '=CF=86-coder/phcoder' Serbinenko wrote: > On 18.01.2015 19:18, Felix Janda wrote: > > Felix Janda wrote: > >> Andrei Borzenkov wrote: > >>> =D0=92 Sat, 17 Jan 2015 14:57:07 +0100 > >>> Felix Janda =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > >>> > >>>> With this, support code in grub-core/osdep/unix/hostdisk.c > >>>> for old glibc releases could be removed. > >>>> --- > >>>> This patch tries to address the issues raised in > >>>> > >>>> http://lists.gnu.org/archive/html/grub-devel/2014-12/msg00030.html > >>>> --- > >>>> INSTALL | 1 + > >>>> configure.ac | 5 +++++ > >>>> grub-core/osdep/unix/hostdisk.c | 25 ------------------------- > >>>> 3 files changed, 6 insertions(+), 25 deletions(-) > >>>> > >>>> diff --git a/INSTALL b/INSTALL > >>>> index b67cd7f..ac7c2aa 100644 > >>>> --- a/INSTALL > >>>> +++ b/INSTALL > >>>> @@ -39,6 +39,7 @@ configuring the GRUB. > >>>> On GNU/Linux, you also need: > >>>> =20 > >>>> * libdevmapper 1.02.34 or later (recommended) > >>>> +* a libc with large file support (e.g. glibc 2.1 or later) > >>>> =20 > >>>> For optional grub-emu features, you need: > >>>> =20 > >>>> diff --git a/configure.ac b/configure.ac > >>>> index 31d2b0b..bdaebb8 100644 > >>>> --- a/configure.ac > >>>> +++ b/configure.ac > >>>> @@ -346,6 +346,11 @@ AC_GNU_SOURCE > >>>> AM_GNU_GETTEXT([external]) > >>>> AC_SYS_LARGEFILE > >>>> =20 > >>>> +if test x"$host_kernel" =3D xlinux ; then > >>> > >>> I wonder if we should do it unconditionally. Large files support is > >>> really presumed by current code. > >>> > >>> Not for now, but something to keep in mind for next version. > >> > >> Yes, the test is not ideal. But enabling it for everything would > >> break cygwin. (There sizeof(off_t)=3D4 and the windows hostdisk.c is > >> used.) > >=20 > I've put all windows flavours and AROS on whitelist. Everything else > requires long-filesystem libc. Thank you for the patch. > Actually there may be a way to make mingw have long off_t, perhaps some > define. If so, it would be better to add it and keep only AROS on white= list. Thanks for fixing up the patch and committing! Felix