From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YbxqA-0008Lz-5p for mharc-grub-devel@gnu.org; Sat, 28 Mar 2015 17:00:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ybxq8-0008Ls-R4 for grub-devel@gnu.org; Sat, 28 Mar 2015 17:00:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ybxq3-0006s0-O2 for grub-devel@gnu.org; Sat, 28 Mar 2015 17:00:20 -0400 Received: from mail-la0-x234.google.com ([2a00:1450:4010:c03::234]:33323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ybxq3-0006ru-FK for grub-devel@gnu.org; Sat, 28 Mar 2015 17:00:15 -0400 Received: by labto5 with SMTP id to5so93297433lab.0 for ; Sat, 28 Mar 2015 14:00:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=RdtOXRKenb13xz2h7j2gKuOx+aAIJZ7zXh4Dpv85v3o=; b=Co8SEHLFm2DR0YfG2DPRwz7yVv2tV/xs9hke1k/s0x7CALIEyBtgdZys2v0uC8suku 4fV76XM9sxdyUm3jSj04e/rX1T/2RBaP0iy1qPeOXO0Ig8YPuc6Gd2v88HeS73frG63H 7W9qdp2sq4NCjrlBncST6x42+KG+3FtrLChb0T1U5zuKMyhQyRREPwfjzrQuiKZqcBco zpuxwT5mQXW0MbM31Dw7AxUXLrs55uNiEoa+tCT5dQAPfbBIBwT3zgcpzMF7kjK0hHTD gsJECA33N0XNRJD0KY/lb5UWc+nnrqQv8GAG4GhGpAd53ybCOE6OOgc50SojUSAxNarq YSoQ== X-Received: by 10.152.234.108 with SMTP id ud12mr22730970lac.81.1427576414254; Sat, 28 Mar 2015 14:00:14 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id d3sm1069121lbc.39.2015.03.28.14.00.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Mar 2015 14:00:13 -0700 (PDT) Date: Sun, 29 Mar 2015 00:00:11 +0300 From: Andrei Borzenkov To: Jaegeuk Kim Subject: Re: [PATCH] F2FS support Message-ID: <20150329000011.7163a2b7@opensuse.site> In-Reply-To: <20150328204318.GB81167@jaegeuk-mac02.hsd1.ca.comcast.net> References: <1427185140-41120-1-git-send-email-jaegeuk@kernel.org> <20150328103155.5c961fec@opensuse.site> <20150328204318.GB81167@jaegeuk-mac02.hsd1.ca.comcast.net> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.25; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::234 Cc: grub-devel@gnu.org, linux-f2fs-devel@lists.sourceforge.net X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2015 21:00:21 -0000 =D0=92 Sat, 28 Mar 2015 13:43:18 -0700 Jaegeuk Kim =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > Hi Andrei, >=20 > On Sat, Mar 28, 2015 at 10:31:55AM +0300, Andrei Borzenkov wrote: > > =D0=92 Tue, 24 Mar 2015 01:19:00 -0700 > > Jaegeuk Kim =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > >=20 > > > * Makefile.util.def: Add f2fs.c. > > > * doc/grub.texi: Add f2fs description. > > > * grub-core/Makefile.core.def: Add f2fs module. > > > * grub-core/fs/f2fs.c: New file. > > > * tests/f2fs_test.in: New file. > > > * tests/util/grub-fs-tester.in: Add f2fs requirements. > > >=20 > >=20 > > It's not the most useful commit message. Better would be short > > explanation of use cases and intended platforms. I'm curious here - > > F2FS is intended for raw flash access, on which platform(s) grub has > > access to such devices?=20 >=20 > I just followed the commit convention in grub.git. It has changed meanwhile. We are using normal git conventions now. > > > +static grub_err_t > > > +grub_f2fs_read_sb (struct grub_f2fs_data *data, int block) > > > +{ > > > + grub_disk_t disk =3D data->disk; > > > + grub_uint64_t offset; > > > + grub_err_t err; > > > + > > > + if (block =3D=3D 0) > > > + offset =3D F2FS_SUPER_OFFSET; > > > + else > > > + offset =3D F2FS_BLKSIZE + F2FS_SUPER_OFFSET; > > > + > >=20 > > Please name it "secondary" or similar instead of "block" to avoid > > confusion. You do not really want to read arbitrary block, right? > > Actually it makes more sense just to pass offset directly to eliminate useless computation.=20