From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Yrmcu-0007Yi-8r for mharc-grub-devel@gnu.org; Mon, 11 May 2015 08:16:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yrmcs-0007Vw-DL for grub-devel@gnu.org; Mon, 11 May 2015 08:16:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yrmcn-0000er-42 for grub-devel@gnu.org; Mon, 11 May 2015 08:16:02 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43783 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yrmcm-0000eS-U6 for grub-devel@gnu.org; Mon, 11 May 2015 08:15:57 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 925EAAC08; Mon, 11 May 2015 12:15:54 +0000 (UTC) Received: by quack.suse.cz (Postfix, from userid 1000) id 29CF68281E; Mon, 11 May 2015 14:15:48 +0200 (CEST) Date: Mon, 11 May 2015 14:15:48 +0200 From: Jan Kara To: Andrei Borzenkov Subject: Re: [PATCH 1/4] xfs: Add helper for inode size Message-ID: <20150511121548.GD9962@quack.suse.cz> References: <1405351291-24767-1-git-send-email-jack@suse.cz> <1405351291-24767-2-git-send-email-jack@suse.cz> <20150511145357.56bdf48d@opensuse.site> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150511145357.56bdf48d@opensuse.site> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 195.135.220.15 Cc: grub-devel@gnu.org, Jan Kara X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 May 2015 12:16:03 -0000 On Mon 11-05-15 14:53:57, Andrei Borzenkov wrote: > =D0=92 Mon, 14 Jul 2014 17:21:28 +0200 > Jan Kara =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >=20 > > Signed-off-by: Jan Kara > > --- > > grub-core/fs/xfs.c | 17 +++++++++++------ > > 1 file changed, 11 insertions(+), 6 deletions(-) > >=20 > > diff --git a/grub-core/fs/xfs.c b/grub-core/fs/xfs.c > > index 16ffd3f1ebd9..a2fc942707c1 100644 > > --- a/grub-core/fs/xfs.c > > +++ b/grub-core/fs/xfs.c > > @@ -255,6 +255,11 @@ grub_xfs_inode_offset (struct grub_xfs_data *dat= a, > > data->sblock.log2_inode); > > } > > =20 > > +static inline int > > +grub_xfs_inode_size(struct grub_xfs_data *data) >=20 > This should be grub_size_t. OK. > What is the reason to add it? It does not look like subsequent > patches modify this function like making it conditional on XFS version. This is just a cleanup so that it's clearer that 1 << data->sblock.log2_inode is actually inode size. But if you don't like it, you can just skip it. So should I send update patch? Thanks for having a look! Honza --=20 Jan Kara SUSE Labs, CR