From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YrmHe-0006HM-PI for mharc-grub-devel@gnu.org; Mon, 11 May 2015 07:54:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrmHb-0006GB-Vd for grub-devel@gnu.org; Mon, 11 May 2015 07:54:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrmHY-0000EM-PT for grub-devel@gnu.org; Mon, 11 May 2015 07:54:03 -0400 Received: from mail-la0-x230.google.com ([2a00:1450:4010:c03::230]:33487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrmHY-0000EG-Hk for grub-devel@gnu.org; Mon, 11 May 2015 07:54:00 -0400 Received: by layy10 with SMTP id y10so91264919lay.0 for ; Mon, 11 May 2015 04:53:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=GOo4Wna4j97g3quHvqN/PgDfObxJjJxo6QqZ47OnAmo=; b=KrqXpHdTtqg12E/lsO9oz2mGW07Lz9TFwvH/EnocviAg9Z7rrowvSb3VnkGoeSH7OH /PSc6aDO3p89/EGkKhFkY3GLoct19fDDtVCKFBEYEOdJYdp03QH1k2L59+vGsTc/ERoT F1TNS2lieENZITNdpfxYDh4aMVgT5UHuwsyIUy/PH+tMP70UKwyDIez7Bfi1CHLtvUij WZJ7/Q1vt1GvoyHjnLSgaTUgq8razy030cBAsrBbqzHTUDu2CWQThHQj3BcanH8qFmDQ TZuNduaoQJmn8sWR5N7nSAYdXk114qVVuLqIoYE678B1ZRboe+U8Ef1nDWoc3aKNgr41 WDsA== X-Received: by 10.112.161.197 with SMTP id xu5mr7674026lbb.69.1431345239761; Mon, 11 May 2015 04:53:59 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id jr1sm2993879lbc.43.2015.05.11.04.53.58 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 May 2015 04:53:59 -0700 (PDT) Date: Mon, 11 May 2015 14:53:57 +0300 From: Andrei Borzenkov To: Jan Kara Subject: Re: [PATCH 1/4] xfs: Add helper for inode size Message-ID: <20150511145357.56bdf48d@opensuse.site> In-Reply-To: <1405351291-24767-2-git-send-email-jack@suse.cz> References: <1405351291-24767-1-git-send-email-jack@suse.cz> <1405351291-24767-2-git-send-email-jack@suse.cz> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.27; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::230 Cc: grub-devel@gnu.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 May 2015 11:54:05 -0000 =D0=92 Mon, 14 Jul 2014 17:21:28 +0200 Jan Kara =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > Signed-off-by: Jan Kara > --- > grub-core/fs/xfs.c | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) >=20 > diff --git a/grub-core/fs/xfs.c b/grub-core/fs/xfs.c > index 16ffd3f1ebd9..a2fc942707c1 100644 > --- a/grub-core/fs/xfs.c > +++ b/grub-core/fs/xfs.c > @@ -255,6 +255,11 @@ grub_xfs_inode_offset (struct grub_xfs_data *data, > data->sblock.log2_inode); > } > =20 > +static inline int > +grub_xfs_inode_size(struct grub_xfs_data *data) This should be grub_size_t. What is the reason to add it? It does not look like subsequent patches modify this function like making it conditional on XFS version.