From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Ys5ER-0002lj-Rd for mharc-grub-devel@gnu.org; Tue, 12 May 2015 04:08:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ys5EP-0002lN-6p for grub-devel@gnu.org; Tue, 12 May 2015 04:08:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ys5EJ-0001oF-52 for grub-devel@gnu.org; Tue, 12 May 2015 04:08:01 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48559 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ys5EI-0001lZ-Vy for grub-devel@gnu.org; Tue, 12 May 2015 04:07:55 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 10807AD14; Tue, 12 May 2015 08:07:54 +0000 (UTC) Received: by quack.suse.cz (Postfix, from userid 1000) id 616038281E; Tue, 12 May 2015 10:07:50 +0200 (CEST) Date: Tue, 12 May 2015 10:07:50 +0200 From: Jan Kara To: Andrei Borzenkov Subject: Re: [PATCH 1/4] xfs: Add helper for inode size Message-ID: <20150512080750.GA13241@quack.suse.cz> References: <1405351291-24767-1-git-send-email-jack@suse.cz> <1405351291-24767-2-git-send-email-jack@suse.cz> <20150511145357.56bdf48d@opensuse.site> <20150511121548.GD9962@quack.suse.cz> <20150512082626.76a7dd70@opensuse.site> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150512082626.76a7dd70@opensuse.site> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 195.135.220.15 Cc: grub-devel@gnu.org, Jan Kara X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2015 08:08:02 -0000 On Tue 12-05-15 08:26:26, Andrei Borzenkov wrote: > =D0=92 Mon, 11 May 2015 14:15:48 +0200 > Jan Kara =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >=20 > > On Mon 11-05-15 14:53:57, Andrei Borzenkov wrote: > > > =D0=92 Mon, 14 Jul 2014 17:21:28 +0200 > > > Jan Kara =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > >=20 > > > > Signed-off-by: Jan Kara > > > > --- > > > > grub-core/fs/xfs.c | 17 +++++++++++------ > > > > 1 file changed, 11 insertions(+), 6 deletions(-) > > > >=20 > > > > diff --git a/grub-core/fs/xfs.c b/grub-core/fs/xfs.c > > > > index 16ffd3f1ebd9..a2fc942707c1 100644 > > > > --- a/grub-core/fs/xfs.c > > > > +++ b/grub-core/fs/xfs.c > > > > @@ -255,6 +255,11 @@ grub_xfs_inode_offset (struct grub_xfs_data = *data, > > > > data->sblock.log2_inode); > > > > } > > > > =20 > > > > +static inline int > > > > +grub_xfs_inode_size(struct grub_xfs_data *data) > > >=20 > > > This should be grub_size_t. > > OK. > >=20 > > > What is the reason to add it? It does not look like subsequent > > > patches modify this function like making it conditional on XFS vers= ion. > > This is just a cleanup so that it's clearer that 1 << > > data->sblock.log2_inode is actually inode size. But if you don't like= it, > > you can just skip it. So should I send update patch? Thanks for havin= g a > > look! >=20 > Yes, send updated patch, it is less risky as series had been tested for > quite some time. But actually helper to compute allocation size with > comment would be quite useful; I stared for quite some time at >=20 > sizeof (struct grub_fshelp_node) > - sizeof (struct grub_xfs_inode) > + (1 << data->sblock.log2_inode)); >=20 > trying to understand what it's about :) OK, I'll do that. Honza --=20 Jan Kara SUSE Labs, CR