From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Ys2iA-0008QT-ID for mharc-grub-devel@gnu.org; Tue, 12 May 2015 01:26:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ys2i8-0008QL-JC for grub-devel@gnu.org; Tue, 12 May 2015 01:26:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ys2i5-0001gO-0s for grub-devel@gnu.org; Tue, 12 May 2015 01:26:32 -0400 Received: from mail-la0-x231.google.com ([2a00:1450:4010:c03::231]:33153) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ys2i4-0001g4-QB for grub-devel@gnu.org; Tue, 12 May 2015 01:26:28 -0400 Received: by layy10 with SMTP id y10so108637282lay.0 for ; Mon, 11 May 2015 22:26:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=DJDwlND40NbeibRvDNao2GpRhIeiUJRPNA6k3WuI+Hc=; b=cXitSb8gVRkUYP4c9tpOy8br2o5u1jeay9zDFbse8Snjb1UiY/q9ivswTpYDHk4WaH 9qGytdrmbpStrERE8Gcy/K4P82hR8V+Ia+I6TU0uIk/CflYoRWI77le3liHghDhEzEf+ nET+eGBNPwc/cYLyOjDFsQgISxR0DmZ1gneWvyFd+4aIYTfmSC3eVSAHNANLoVwwBixu mGi+6iV1WpmT6KLttowUUkVO00QMxg/ATuxu2vK8m8Hkro+U2DDOBJwr6EM8SkQRBi9q cQdxy7uWFL0MQN4TFKuG7f3etCw+AgxqIrLI2ZMAGFTXUfzlEUiQE0B/ahl1WIi8MMVv L5TA== X-Received: by 10.112.205.231 with SMTP id lj7mr10725775lbc.42.1431408388147; Mon, 11 May 2015 22:26:28 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id zf3sm3530058lbb.2.2015.05.11.22.26.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 May 2015 22:26:27 -0700 (PDT) Date: Tue, 12 May 2015 08:26:26 +0300 From: Andrei Borzenkov To: Jan Kara Subject: Re: [PATCH 1/4] xfs: Add helper for inode size Message-ID: <20150512082626.76a7dd70@opensuse.site> In-Reply-To: <20150511121548.GD9962@quack.suse.cz> References: <1405351291-24767-1-git-send-email-jack@suse.cz> <1405351291-24767-2-git-send-email-jack@suse.cz> <20150511145357.56bdf48d@opensuse.site> <20150511121548.GD9962@quack.suse.cz> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.27; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::231 Cc: grub-devel@gnu.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2015 05:26:33 -0000 =D0=92 Mon, 11 May 2015 14:15:48 +0200 Jan Kara =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Mon 11-05-15 14:53:57, Andrei Borzenkov wrote: > > =D0=92 Mon, 14 Jul 2014 17:21:28 +0200 > > Jan Kara =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > >=20 > > > Signed-off-by: Jan Kara > > > --- > > > grub-core/fs/xfs.c | 17 +++++++++++------ > > > 1 file changed, 11 insertions(+), 6 deletions(-) > > >=20 > > > diff --git a/grub-core/fs/xfs.c b/grub-core/fs/xfs.c > > > index 16ffd3f1ebd9..a2fc942707c1 100644 > > > --- a/grub-core/fs/xfs.c > > > +++ b/grub-core/fs/xfs.c > > > @@ -255,6 +255,11 @@ grub_xfs_inode_offset (struct grub_xfs_data *dat= a, > > > data->sblock.log2_inode); > > > } > > > =20 > > > +static inline int > > > +grub_xfs_inode_size(struct grub_xfs_data *data) > >=20 > > This should be grub_size_t. > OK. >=20 > > What is the reason to add it? It does not look like subsequent > > patches modify this function like making it conditional on XFS version. > This is just a cleanup so that it's clearer that 1 << > data->sblock.log2_inode is actually inode size. But if you don't like it, > you can just skip it. So should I send update patch? Thanks for having a > look! Yes, send updated patch, it is less risky as series had been tested for quite some time. But actually helper to compute allocation size with comment would be quite useful; I stared for quite some time at sizeof (struct grub_fshelp_node) - sizeof (struct grub_xfs_inode) + (1 << data->sblock.log2_inode)); trying to understand what it's about :)