From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YwaV7-0002jf-64 for mharc-grub-devel@gnu.org; Sun, 24 May 2015 14:19:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YwaV5-0002jY-GS for grub-devel@gnu.org; Sun, 24 May 2015 14:19:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YwaV2-0006k9-AO for grub-devel@gnu.org; Sun, 24 May 2015 14:19:51 -0400 Received: from mail-lb0-x236.google.com ([2a00:1450:4010:c04::236]:36174) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YwaV2-0006k5-30 for grub-devel@gnu.org; Sun, 24 May 2015 14:19:48 -0400 Received: by lbbqq2 with SMTP id qq2so40106517lbb.3 for ; Sun, 24 May 2015 11:19:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type; bh=72AB7Z/bNJOxOesA7bFE9lyLbZs8iO1bufhB7NqbbYw=; b=cY4eZheUEKdh4ZH4AO9rbTpH8AFXrOYn366GrtlRclli8ZBmyC6d90dh3/2BgDNB/R f9n7flvHsttTiUvPgqYT8xKkZ9klXP3FaNoo6XnzfMieKstysmDf1H6C7RGGm+msih3v ZhbzUwrgCVPlbzs7/P/zwH3gmGUB+vkXQd61fKytfdDpvtDO2qun3OUhrZevUn17Z8xY W6gOmngT1pesslckWPHEEsg7DBv339eJGItuiQe2FY+ex/wInqjIiL7hFdBblJ9UBZHw ETjWlVHH/4Rh6J+4RT2XmVkCGt0B1D4h8+vOCmy4MGn0htK/8ZuwpR+SFuGzpjFOrNFf srvA== X-Received: by 10.112.150.100 with SMTP id uh4mr10622726lbb.112.1432491587397; Sun, 24 May 2015 11:19:47 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id o5sm1890905lag.9.2015.05.24.11.19.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 May 2015 11:19:46 -0700 (PDT) Date: Sun, 24 May 2015 21:19:44 +0300 From: Andrei Borzenkov To: Paul Menzel Subject: Re: [PATCH] disk/ahci: Use defines `GRUB_ATA_STATUS_BUSY` and `GRUB_ATA_STATUS_DRQ` Message-ID: <20150524211944.26a07b73@opensuse.site> In-Reply-To: <1432478922.2492.3.camel@users.sourceforge.net> References: <1432478922.2492.3.camel@users.sourceforge.net> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.27; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/y4EyyHSEwCyAAeu+6HMDeT/"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::236 Cc: grub-devel@gnu.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 May 2015 18:19:52 -0000 --Sig_/y4EyyHSEwCyAAeu+6HMDeT/ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =D0=92 Sun, 24 May 2015 16:48:42 +0200 Paul Menzel =D0=BF=D0=B8=D1=88=D0=B5=D1= =82: > Date: Sun, 24 May 2015 11:11:25 +0200 >=20 > Instead of hard coding `0x88` use the macros defined in `disk/ata.h`. applied > --- > grub-core/disk/ahci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/grub-core/disk/ahci.c b/grub-core/disk/ahci.c > index d6bdbdd..7f75724 100644 > --- a/grub-core/disk/ahci.c > +++ b/grub-core/disk/ahci.c > @@ -565,14 +565,14 @@ grub_ahci_pciinit (grub_pci_device_t dev, > while (grub_get_time_ms () < endtime) > { > for (i =3D 0; i < nports; i++) > - if (adevs[i] && (adevs[i]->hba->ports[adevs[i]->port].task_file_data & = 0x88)) > + if (adevs[i] && (adevs[i]->hba->ports[adevs[i]->port].task_file_data & = (GRUB_ATA_STATUS_BUSY | GRUB_ATA_STATUS_DRQ))) > break; > if (i =3D=3D nports) > break; > } > =20 > for (i =3D 0; i < nports; i++) > - if (adevs[i] && (adevs[i]->hba->ports[adevs[i]->port].task_file_data= & 0x88)) > + if (adevs[i] && (adevs[i]->hba->ports[adevs[i]->port].task_file_data= & (GRUB_ATA_STATUS_BUSY | GRUB_ATA_STATUS_DRQ))) > { > grub_dprintf ("ahci", "port %d is busy\n", i); > failed_adevs[i] =3D adevs[i]; --Sig_/y4EyyHSEwCyAAeu+6HMDeT/ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlViFkAACgkQR6LMutpd94zSOQCfdLh6URMQdcj2/0EGK3istQOw Gi0An3d7YNACaJkVoLeyrbbpfJ/SfEMR =xiY7 -----END PGP SIGNATURE----- --Sig_/y4EyyHSEwCyAAeu+6HMDeT/--