From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YyZky-00063c-IB for mharc-grub-devel@gnu.org; Sat, 30 May 2015 01:56:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyZkv-00063A-Qz for grub-devel@gnu.org; Sat, 30 May 2015 01:56:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YyZkr-0003bH-Mp for grub-devel@gnu.org; Sat, 30 May 2015 01:56:25 -0400 Received: from mail-la0-x234.google.com ([2a00:1450:4010:c03::234]:33905) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyZkr-0003bA-FE for grub-devel@gnu.org; Sat, 30 May 2015 01:56:21 -0400 Received: by laat2 with SMTP id t2so69445660laa.1 for ; Fri, 29 May 2015 22:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=nETQ020yL6Tkt9c/GkaV18EpEJa5VqxGLH7jophVU4U=; b=fpFQ/quxF3Vh8NYVXcXtHsqi4xhGzIbcLjEvedkac21otGa088HVilvEjN4k0Fo+wm kcV6FrxTAloRbm+A4SNU3UJRSnxU5NDQ0Zwb4KjlimqPysfi7cMe64vIVxGfTFLbnTyQ hqdEfFOeWtXjjuSvuyHJt+DDyFbC/dLsB6obr9EBlIbH4Et3riA9rlDmxi87eAk6x3Kr B2tjK3avTtAHIUCzC5CuJvGitbbMUQJzRbQ3RJKL2CfxDMvb9o/GOzleFBvdPc1f/EdD PyUwzXXtwDjCwY44hfeVuEJIauvxMOhevTVkZ6+0EQ0Ct7E6GMkx4RKSRn4DnVTakJ5s S7Mg== X-Received: by 10.152.25.227 with SMTP id f3mr11150618lag.67.1432965380636; Fri, 29 May 2015 22:56:20 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id yh3sm2051527lab.44.2015.05.29.22.56.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 May 2015 22:56:19 -0700 (PDT) Date: Sat, 30 May 2015 08:56:19 +0300 From: Andrei Borzenkov To: Toomas Soome Subject: Re: [PATCH 5/5] zfs extensible_dataset and large_blocks feature support Message-ID: <20150530085619.0e3f523f@opensuse.site> In-Reply-To: <2FF20C30-47E0-4360-AA77-CF7EBFF582AB@me.com> References: <20150419224040.44ec3e70@opensuse.site> <9505B405-2124-4FCC-9527-41C5BE5B045A@me.com> <20150420064023.277228f2@opensuse.site> <20150503222358.2431549d@opensuse.site> <44E34C2C-8A51-46C1-9BAF-6F36AFE04181@me.com> <20150504073237.34f1952a@opensuse.site> <2D9FA5E8-9271-4A70-975C-7453D5588F48@me.com> <2FF20C30-47E0-4360-AA77-CF7EBFF582AB@me.com> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.27; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::234 Cc: The development of GNU GRUB X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2015 05:56:27 -0000 =D0=92 Fri, 15 May 2015 10:50:59 +0300 Toomas Soome =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >=20 > hi! > so what is the status of this last feature pair? its the final bundle to= get full support of modern openzfs to grub and since zfs on all major pl= ayers (illumos/zol/freebsd) support this feature, its only question of time= when someone will step on this missing piece;) Committed with additional explanatory commit text scraped from this discussion. Thanks! >=20 > rgds, > toomas >=20 > > On 04.05.2015, at 9:49, Toomas Soome wrote: > >=20 > >=20 > >> On 04.05.2015, at 7:32, Andrei Borzenkov wrote: > >>=20 > >> =D0=92 Sun, 03 May 2015 22:47:40 +0300 > >> Toomas Soome =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > >>=20 > >>>=20 > >>>> On 03.05.2015, at 22:23, Andrei Borzenkov wrot= e: > >>>>=20 > >>>>>>=20 > >>>>>=20 > >>>>> they do implement read support extensible dataset=E2=80=A6 instead = of fixed DMU types they dont specify type, making it possible to use fat za= p objects from bonus area.=20 > >>>>>=20 > >>>>> reference commit: > >>>>> https://github.com/illumos/illumos-gate/commit/2acef22db7808606888f= 8f92715629ff3ba555b9 > >>>>>=20 > >>>>=20 > >>>> OK; just to be sure - there are several remaining uses of > >>>> DMU_OT_DSL_DATASET and DMU_OT_DSL_DIR; are these intentional? > >>>=20 > >>>=20 > >>> they *should* be ok. at least browsing and loading files from dataset= s haven=E2=80=99t revealed other instances over the test time. but problem = is, the cases of zapify (when =E2=80=9Cnormal=E2=80=9D structure is wrapped= as zap object) I have seen, have been related to datasets using >128k reco= rdsize, and its possible some cases may have been missed - the grub zfs cod= e and real zfs code are not exactly easy to compare. at least so far I have= n=E2=80=99t seen bugs related to this nor received any reports. the basic s= ymptom can be either message about wrong type or =E2=80=9Cmissing=E2=80=9D = directory entry in listing. > >>>=20 > >>=20 > >>=20 > >> Can https://savannah.gnu.org/bugs/?44448 be somehow related? > >=20 > > without grub debug=3Dzfs its impossible to say - guessing there is not = really helpful:) altho in general, feature check for label should generate = error message if pool has enabled features not supported by version of grub= used there. > >=20 > > basically, my first suggestion to cases like that is to set debug=3Dzfs= in grub and ask user to provide that debug output. > >=20 > > rgds, > > toomas > >=20 > >=20 >=20