From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Yyajm-0002aV-93 for mharc-grub-devel@gnu.org; Sat, 30 May 2015 02:59:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yyajj-0002Ye-95 for grub-devel@gnu.org; Sat, 30 May 2015 02:59:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yyajg-0005u3-4q for grub-devel@gnu.org; Sat, 30 May 2015 02:59:15 -0400 Received: from mail-lb0-x22e.google.com ([2a00:1450:4010:c04::22e]:36677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yyajf-0005tz-TR for grub-devel@gnu.org; Sat, 30 May 2015 02:59:12 -0400 Received: by lbbqq2 with SMTP id qq2so60145115lbb.3 for ; Fri, 29 May 2015 23:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=AcusyeCKSkiBoorep8P6XrLFnJTSsQSOgUuDuUHfRto=; b=QbLGB4owZJNSsM0IbmWAYFManDlTvmI7BqqYHMaJpepZIIDyFseRq7+8AQkIC8tbpd GfEAZrENb3H+sSvRv7urknUk7gJCXEdJu5kMsg4wCrB/2A4AQRUQVoie40/KnU57fb0/ NExON0UZ+M4ApjVgJapyZoMyylnkFYP7Rnv9g4WSHXVMCEy4ohRrG1b+52oX7PMgI1kH GegxTDKjIj9UDSFbZxQbjh26p9uhTKTAYEq3851dWIQiXwofQ69btMWTCwRDd+Wthjut D8rs9WeGAWZPPo9ZjxNiXqU4LU5d/yyU88BiLQcWIRMgfVxwAj9n/rz72VVQKqLh9V0T S7+w== X-Received: by 10.152.18.199 with SMTP id y7mr11427867lad.39.1432969151011; Fri, 29 May 2015 23:59:11 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id l3sm2089219lbj.46.2015.05.29.23.59.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 May 2015 23:59:10 -0700 (PDT) Date: Sat, 30 May 2015 09:59:09 +0300 From: Andrei Borzenkov To: Jan Kara Subject: Re: [PATCH 2/2] xfs: V5 filesystem format support Message-ID: <20150530095909.62c7b302@opensuse.site> In-Reply-To: <1431502368-29422-3-git-send-email-jack@suse.cz> References: <1431502368-29422-1-git-send-email-jack@suse.cz> <1431502368-29422-3-git-send-email-jack@suse.cz> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.27; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::22e Cc: grub-devel@gnu.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2015 06:59:16 -0000 =D0=92 Wed, 13 May 2015 09:32:48 +0200 Jan Kara =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > =20 > struct grub_xfs_sblock > { > @@ -54,12 +68,19 @@ struct grub_xfs_sblock > grub_uint8_t log2_agblk; > grub_uint8_t unused6[67]; > grub_uint8_t log2_dirblk; > + grub_uint8_t unused7[7]; > + grub_uint32_t features2; > + grub_uint8_t unused8[4]; > + grub_uint32_t sb_features_compat; > + grub_uint32_t sb_features_ro_compat; > + grub_uint32_t sb_features_incompat; > + grub_uint32_t sb_features_log_incompat; They do not seem to be really used. Normally the very first thing other filesystems do is to check for incompatible features we do not support. Even if there are no such such features right now you should add checks to avoid attempt to access unsupported future format. ... > @@ -281,6 +384,9 @@ grub_xfs_read_inode (struct grub_xfs_data *data, grub= _uint64_t ino, > grub_uint64_t block =3D grub_xfs_inode_block (data, ino); > int offset =3D grub_xfs_inode_offset (data, ino); > =20 > + grub_dprintf("xfs", "Reading inode (%llu) - %llu, %d\n", PRIuGRUB_UINT64_T and drop casts. > + (unsigned long long) ino, > + (unsigned long long) block, offset);