From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Z0Y8a-0001Z7-Op for mharc-grub-devel@gnu.org; Thu, 04 Jun 2015 12:37:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0Y8Y-0001Z1-BP for grub-devel@gnu.org; Thu, 04 Jun 2015 12:36:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0Y8V-0001xC-3f for grub-devel@gnu.org; Thu, 04 Jun 2015 12:36:58 -0400 Received: from mail-la0-x234.google.com ([2a00:1450:4010:c03::234]:35197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0Y8U-0001wp-Rh for grub-devel@gnu.org; Thu, 04 Jun 2015 12:36:55 -0400 Received: by labko7 with SMTP id ko7so36098436lab.2 for ; Thu, 04 Jun 2015 09:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=OUHuhXuTc+yaUH5lOK3y6W4HNdIqjQ1N37EIkaNo9Nw=; b=JCd3u3lcU8uujchjkJMAIgwpdJuOW3SQ5TgjSp56FFP/NGkp1vKh9gxPM7rapC8O6m qpc2eV2hnWDfri6jzwJuA1PzRHSTJzyz+pQV2ieCNdSdPPavzZxfxZ8GG5SGXWbLD3ko 2kZoBRtMwf0WUXo4IH3mKAlYGwcSXPh74H1dhLeDZ5dYRekwY/AT0r4cZN8mD+8xwIib 1ZXvnCfdIul7RtQmq+754cxwS25yZ4mRtP0T9EEau6T1A3x2YwQiejXuWWeZVrDahUCO ImkWRoupOyK+le8U5LTqwz5D/2Ll06TBmqKY4FqLlU8cK2SvYwPwE9bosm/oZl4M2H7M D6xw== X-Received: by 10.152.36.161 with SMTP id r1mr38478323laj.88.1433435812979; Thu, 04 Jun 2015 09:36:52 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id u10sm884952lbw.31.2015.06.04.09.36.52 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jun 2015 09:36:52 -0700 (PDT) Date: Thu, 4 Jun 2015 19:36:51 +0300 From: Andrei Borzenkov To: Toomas Soome Subject: Re: multiboot2.h & multiboot_header_tag_module_align Message-ID: <20150604193651.75e8ab04@opensuse.site> In-Reply-To: <397C2E4D-B5C1-4937-B761-7C5A4A05E527@me.com> References: <55706F68.5080100@gmail.com> <20150604191914.41653084@opensuse.site> <397C2E4D-B5C1-4937-B761-7C5A4A05E527@me.com> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.27; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::234 Cc: The development of GNU GRUB X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2015 16:36:59 -0000 =D0=92 Thu, 04 Jun 2015 19:29:17 +0300 Toomas Soome =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >=20 > > On 04.06.2015, at 19:19, Andrei Borzenkov wrote: > >=20 > > =D0=92 Thu, 04 Jun 2015 19:04:46 +0300 > > Toomas Soome =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > >=20 > >>=20 > >>> On 04.06.2015, at 18:31, Vladimir '=CF=86-coder/phcoder' Serbinenko <= phcoder@gmail.com> wrote: > >>>=20 > >>> On 04.06.2015 14:18, Toomas Soome wrote: > >>>> hi! > >>>>=20 > >>>> i know this tag (multiboot_header_tag_module_align) is not really us= ed, but it still would be nice if the copy/paste error of the actual struct= ure would be fixed;) > >>>>=20 > >>> Can you propose a patch? > >>>> rgds, > >>=20 > >> as its header tag, i think following should be it; header tags have 16= bit ints for type and flags, 32bit size and based on name, this tag is to r= equest bootloader to use specified alignment, so the data field should be 3= 2bit uint as well (default MULTIBOOT_MOD_ALIGN is 0x00001000). > >>=20 > >> diff --git a/include/multiboot2.h b/include/multiboot2.h > >> index 3ccff15..e3064da 100644 > >> --- a/include/multiboot2.h > >> +++ b/include/multiboot2.h > >> @@ -156,9 +156,7 @@ struct multiboot_header_tag_module_align > >> multiboot_uint16_t type; > >> multiboot_uint16_t flags; > >> multiboot_uint32_t size; > >> - multiboot_uint32_t width; > >> - multiboot_uint32_t height; > >> - multiboot_uint32_t depth; > >> + multiboot_uint32_t align; > > What about consulting multiboot2 specification? :) >=20 >=20 > oh right, for some reason i missed the actual specification and was stumb= ling on link to this broken header;) >=20 > this is of course the correct one (http://nongnu.askapache.com/grub/phcod= er/multiboot.pdf 3.1.9 If this tag is present modules must be page aligned): >=20 > diff --git a/include/multiboot2.h b/include/multiboot2.h > index 3ccff15..9d48627 100644 > --- a/include/multiboot2.h > +++ b/include/multiboot2.h > @@ -156,9 +156,6 @@ struct multiboot_header_tag_module_align > multiboot_uint16_t type; > multiboot_uint16_t flags; > multiboot_uint32_t size; > - multiboot_uint32_t width; > - multiboot_uint32_t height; > - multiboot_uint32_t depth; > }; > =20 > struct multiboot_color >=20 Could you make properly formatted git patch either as attachment or as git send-email?