* multiboot2.h & multiboot_header_tag_module_align @ 2015-06-04 12:18 Toomas Soome 2015-06-04 15:31 ` Vladimir 'φ-coder/phcoder' Serbinenko 0 siblings, 1 reply; 8+ messages in thread From: Toomas Soome @ 2015-06-04 12:18 UTC (permalink / raw) To: The development of GNU GRUB hi! i know this tag (multiboot_header_tag_module_align) is not really used, but it still would be nice if the copy/paste error of the actual structure would be fixed;) rgds, toomas ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: multiboot2.h & multiboot_header_tag_module_align 2015-06-04 12:18 multiboot2.h & multiboot_header_tag_module_align Toomas Soome @ 2015-06-04 15:31 ` Vladimir 'φ-coder/phcoder' Serbinenko 2015-06-04 16:04 ` Toomas Soome 0 siblings, 1 reply; 8+ messages in thread From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2015-06-04 15:31 UTC (permalink / raw) To: The development of GNU GRUB [-- Attachment #1: Type: text/plain, Size: 430 bytes --] On 04.06.2015 14:18, Toomas Soome wrote: > hi! > > i know this tag (multiboot_header_tag_module_align) is not really used, but it still would be nice if the copy/paste error of the actual structure would be fixed;) > Can you propose a patch? > rgds, > toomas > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 213 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: multiboot2.h & multiboot_header_tag_module_align 2015-06-04 15:31 ` Vladimir 'φ-coder/phcoder' Serbinenko @ 2015-06-04 16:04 ` Toomas Soome 2015-06-04 16:19 ` Andrei Borzenkov 0 siblings, 1 reply; 8+ messages in thread From: Toomas Soome @ 2015-06-04 16:04 UTC (permalink / raw) To: The development of GNU GRUB > On 04.06.2015, at 18:31, Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> wrote: > > On 04.06.2015 14:18, Toomas Soome wrote: >> hi! >> >> i know this tag (multiboot_header_tag_module_align) is not really used, but it still would be nice if the copy/paste error of the actual structure would be fixed;) >> > Can you propose a patch? >> rgds, as its header tag, i think following should be it; header tags have 16bit ints for type and flags, 32bit size and based on name, this tag is to request bootloader to use specified alignment, so the data field should be 32bit uint as well (default MULTIBOOT_MOD_ALIGN is 0x00001000). diff --git a/include/multiboot2.h b/include/multiboot2.h index 3ccff15..e3064da 100644 --- a/include/multiboot2.h +++ b/include/multiboot2.h @@ -156,9 +156,7 @@ struct multiboot_header_tag_module_align multiboot_uint16_t type; multiboot_uint16_t flags; multiboot_uint32_t size; - multiboot_uint32_t width; - multiboot_uint32_t height; - multiboot_uint32_t depth; + multiboot_uint32_t align; }; struct multiboot_color ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: multiboot2.h & multiboot_header_tag_module_align 2015-06-04 16:04 ` Toomas Soome @ 2015-06-04 16:19 ` Andrei Borzenkov 2015-06-04 16:29 ` Toomas Soome 0 siblings, 1 reply; 8+ messages in thread From: Andrei Borzenkov @ 2015-06-04 16:19 UTC (permalink / raw) To: Toomas Soome; +Cc: The development of GNU GRUB В Thu, 04 Jun 2015 19:04:46 +0300 Toomas Soome <tsoome@me.com> пишет: > > > On 04.06.2015, at 18:31, Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> wrote: > > > > On 04.06.2015 14:18, Toomas Soome wrote: > >> hi! > >> > >> i know this tag (multiboot_header_tag_module_align) is not really used, but it still would be nice if the copy/paste error of the actual structure would be fixed;) > >> > > Can you propose a patch? > >> rgds, > > as its header tag, i think following should be it; header tags have 16bit ints for type and flags, 32bit size and based on name, this tag is to request bootloader to use specified alignment, so the data field should be 32bit uint as well (default MULTIBOOT_MOD_ALIGN is 0x00001000). > > diff --git a/include/multiboot2.h b/include/multiboot2.h > index 3ccff15..e3064da 100644 > --- a/include/multiboot2.h > +++ b/include/multiboot2.h > @@ -156,9 +156,7 @@ struct multiboot_header_tag_module_align > multiboot_uint16_t type; > multiboot_uint16_t flags; > multiboot_uint32_t size; > - multiboot_uint32_t width; > - multiboot_uint32_t height; > - multiboot_uint32_t depth; > + multiboot_uint32_t align; What about consulting multiboot2 specification? :) > }; > > struct multiboot_color > > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: multiboot2.h & multiboot_header_tag_module_align 2015-06-04 16:19 ` Andrei Borzenkov @ 2015-06-04 16:29 ` Toomas Soome 2015-06-04 16:36 ` Andrei Borzenkov 0 siblings, 1 reply; 8+ messages in thread From: Toomas Soome @ 2015-06-04 16:29 UTC (permalink / raw) To: Andrei Borzenkov; +Cc: The development of GNU GRUB > On 04.06.2015, at 19:19, Andrei Borzenkov <arvidjaar@gmail.com> wrote: > > В Thu, 04 Jun 2015 19:04:46 +0300 > Toomas Soome <tsoome@me.com> пишет: > >> >>> On 04.06.2015, at 18:31, Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> wrote: >>> >>> On 04.06.2015 14:18, Toomas Soome wrote: >>>> hi! >>>> >>>> i know this tag (multiboot_header_tag_module_align) is not really used, but it still would be nice if the copy/paste error of the actual structure would be fixed;) >>>> >>> Can you propose a patch? >>>> rgds, >> >> as its header tag, i think following should be it; header tags have 16bit ints for type and flags, 32bit size and based on name, this tag is to request bootloader to use specified alignment, so the data field should be 32bit uint as well (default MULTIBOOT_MOD_ALIGN is 0x00001000). >> >> diff --git a/include/multiboot2.h b/include/multiboot2.h >> index 3ccff15..e3064da 100644 >> --- a/include/multiboot2.h >> +++ b/include/multiboot2.h >> @@ -156,9 +156,7 @@ struct multiboot_header_tag_module_align >> multiboot_uint16_t type; >> multiboot_uint16_t flags; >> multiboot_uint32_t size; >> - multiboot_uint32_t width; >> - multiboot_uint32_t height; >> - multiboot_uint32_t depth; >> + multiboot_uint32_t align; > What about consulting multiboot2 specification? :) oh right, for some reason i missed the actual specification and was stumbling on link to this broken header;) this is of course the correct one (http://nongnu.askapache.com/grub/phcoder/multiboot.pdf 3.1.9 If this tag is present modules must be page aligned): diff --git a/include/multiboot2.h b/include/multiboot2.h index 3ccff15..9d48627 100644 --- a/include/multiboot2.h +++ b/include/multiboot2.h @@ -156,9 +156,6 @@ struct multiboot_header_tag_module_align multiboot_uint16_t type; multiboot_uint16_t flags; multiboot_uint32_t size; - multiboot_uint32_t width; - multiboot_uint32_t height; - multiboot_uint32_t depth; }; struct multiboot_color ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: multiboot2.h & multiboot_header_tag_module_align 2015-06-04 16:29 ` Toomas Soome @ 2015-06-04 16:36 ` Andrei Borzenkov 2015-06-04 16:46 ` Toomas Soome 0 siblings, 1 reply; 8+ messages in thread From: Andrei Borzenkov @ 2015-06-04 16:36 UTC (permalink / raw) To: Toomas Soome; +Cc: The development of GNU GRUB В Thu, 04 Jun 2015 19:29:17 +0300 Toomas Soome <tsoome@me.com> пишет: > > > On 04.06.2015, at 19:19, Andrei Borzenkov <arvidjaar@gmail.com> wrote: > > > > В Thu, 04 Jun 2015 19:04:46 +0300 > > Toomas Soome <tsoome@me.com> пишет: > > > >> > >>> On 04.06.2015, at 18:31, Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> wrote: > >>> > >>> On 04.06.2015 14:18, Toomas Soome wrote: > >>>> hi! > >>>> > >>>> i know this tag (multiboot_header_tag_module_align) is not really used, but it still would be nice if the copy/paste error of the actual structure would be fixed;) > >>>> > >>> Can you propose a patch? > >>>> rgds, > >> > >> as its header tag, i think following should be it; header tags have 16bit ints for type and flags, 32bit size and based on name, this tag is to request bootloader to use specified alignment, so the data field should be 32bit uint as well (default MULTIBOOT_MOD_ALIGN is 0x00001000). > >> > >> diff --git a/include/multiboot2.h b/include/multiboot2.h > >> index 3ccff15..e3064da 100644 > >> --- a/include/multiboot2.h > >> +++ b/include/multiboot2.h > >> @@ -156,9 +156,7 @@ struct multiboot_header_tag_module_align > >> multiboot_uint16_t type; > >> multiboot_uint16_t flags; > >> multiboot_uint32_t size; > >> - multiboot_uint32_t width; > >> - multiboot_uint32_t height; > >> - multiboot_uint32_t depth; > >> + multiboot_uint32_t align; > > What about consulting multiboot2 specification? :) > > > oh right, for some reason i missed the actual specification and was stumbling on link to this broken header;) > > this is of course the correct one (http://nongnu.askapache.com/grub/phcoder/multiboot.pdf 3.1.9 If this tag is present modules must be page aligned): > > diff --git a/include/multiboot2.h b/include/multiboot2.h > index 3ccff15..9d48627 100644 > --- a/include/multiboot2.h > +++ b/include/multiboot2.h > @@ -156,9 +156,6 @@ struct multiboot_header_tag_module_align > multiboot_uint16_t type; > multiboot_uint16_t flags; > multiboot_uint32_t size; > - multiboot_uint32_t width; > - multiboot_uint32_t height; > - multiboot_uint32_t depth; > }; > > struct multiboot_color > Could you make properly formatted git patch either as attachment or as git send-email? ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: multiboot2.h & multiboot_header_tag_module_align 2015-06-04 16:36 ` Andrei Borzenkov @ 2015-06-04 16:46 ` Toomas Soome 2015-06-04 17:02 ` Andrei Borzenkov 0 siblings, 1 reply; 8+ messages in thread From: Toomas Soome @ 2015-06-04 16:46 UTC (permalink / raw) To: The development of GNU GRUB [-- Attachment #1: Type: text/plain, Size: 20 bytes --] patch attached. [-- Attachment #2: 0001-multiboot_header_tag_module_align-fix-to-confirm-mul.patch --] [-- Type: application/octet-stream, Size: 745 bytes --] From 3b7d382f384a2e79e2adcdd8d4ef09f28f45f26a Mon Sep 17 00:00:00 2001 From: Toomas Soome <tsoome@me.com> Date: Thu, 4 Jun 2015 19:41:54 +0300 Subject: [PATCH] multiboot_header_tag_module_align fix to confirm multiboot specification --- include/multiboot2.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/multiboot2.h b/include/multiboot2.h index 3ccff15..9d48627 100644 --- a/include/multiboot2.h +++ b/include/multiboot2.h @@ -156,9 +156,6 @@ struct multiboot_header_tag_module_align multiboot_uint16_t type; multiboot_uint16_t flags; multiboot_uint32_t size; - multiboot_uint32_t width; - multiboot_uint32_t height; - multiboot_uint32_t depth; }; struct multiboot_color -- 1.9.4 [-- Attachment #3: Type: text/plain, Size: 2589 bytes --] > On 04.06.2015, at 19:36, Andrei Borzenkov <arvidjaar@gmail.com> wrote: > > В Thu, 04 Jun 2015 19:29:17 +0300 > Toomas Soome <tsoome@me.com> пишет: > >> >>> On 04.06.2015, at 19:19, Andrei Borzenkov <arvidjaar@gmail.com> wrote: >>> >>> В Thu, 04 Jun 2015 19:04:46 +0300 >>> Toomas Soome <tsoome@me.com> пишет: >>> >>>> >>>>> On 04.06.2015, at 18:31, Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> wrote: >>>>> >>>>> On 04.06.2015 14:18, Toomas Soome wrote: >>>>>> hi! >>>>>> >>>>>> i know this tag (multiboot_header_tag_module_align) is not really used, but it still would be nice if the copy/paste error of the actual structure would be fixed;) >>>>>> >>>>> Can you propose a patch? >>>>>> rgds, >>>> >>>> as its header tag, i think following should be it; header tags have 16bit ints for type and flags, 32bit size and based on name, this tag is to request bootloader to use specified alignment, so the data field should be 32bit uint as well (default MULTIBOOT_MOD_ALIGN is 0x00001000). >>>> >>>> diff --git a/include/multiboot2.h b/include/multiboot2.h >>>> index 3ccff15..e3064da 100644 >>>> --- a/include/multiboot2.h >>>> +++ b/include/multiboot2.h >>>> @@ -156,9 +156,7 @@ struct multiboot_header_tag_module_align >>>> multiboot_uint16_t type; >>>> multiboot_uint16_t flags; >>>> multiboot_uint32_t size; >>>> - multiboot_uint32_t width; >>>> - multiboot_uint32_t height; >>>> - multiboot_uint32_t depth; >>>> + multiboot_uint32_t align; >>> What about consulting multiboot2 specification? :) >> >> >> oh right, for some reason i missed the actual specification and was stumbling on link to this broken header;) >> >> this is of course the correct one (http://nongnu.askapache.com/grub/phcoder/multiboot.pdf 3.1.9 If this tag is present modules must be page aligned): >> >> diff --git a/include/multiboot2.h b/include/multiboot2.h >> index 3ccff15..9d48627 100644 >> --- a/include/multiboot2.h >> +++ b/include/multiboot2.h >> @@ -156,9 +156,6 @@ struct multiboot_header_tag_module_align >> multiboot_uint16_t type; >> multiboot_uint16_t flags; >> multiboot_uint32_t size; >> - multiboot_uint32_t width; >> - multiboot_uint32_t height; >> - multiboot_uint32_t depth; >> }; >> >> struct multiboot_color >> > > Could you make properly formatted git patch either as attachment or as > git send-email? > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: multiboot2.h & multiboot_header_tag_module_align 2015-06-04 16:46 ` Toomas Soome @ 2015-06-04 17:02 ` Andrei Borzenkov 0 siblings, 0 replies; 8+ messages in thread From: Andrei Borzenkov @ 2015-06-04 17:02 UTC (permalink / raw) To: Toomas Soome; +Cc: The development of GNU GRUB В Thu, 04 Jun 2015 19:46:06 +0300 Toomas Soome <tsoome@me.com> пишет: > > patch attached. > > applied to master and multiboot2 branch. Thanks! ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-06-04 17:02 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-06-04 12:18 multiboot2.h & multiboot_header_tag_module_align Toomas Soome 2015-06-04 15:31 ` Vladimir 'φ-coder/phcoder' Serbinenko 2015-06-04 16:04 ` Toomas Soome 2015-06-04 16:19 ` Andrei Borzenkov 2015-06-04 16:29 ` Toomas Soome 2015-06-04 16:36 ` Andrei Borzenkov 2015-06-04 16:46 ` Toomas Soome 2015-06-04 17:02 ` Andrei Borzenkov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).