From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZF243-00010c-8T for mharc-grub-devel@gnu.org; Tue, 14 Jul 2015 11:24:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZF240-00010A-PS for grub-devel@gnu.org; Tue, 14 Jul 2015 11:24:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZF23u-0001s5-Pu for grub-devel@gnu.org; Tue, 14 Jul 2015 11:24:08 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:22695) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZF23u-0001rC-JU for grub-devel@gnu.org; Tue, 14 Jul 2015 11:24:02 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t6EFNrWW021487 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 14 Jul 2015 15:23:54 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t6EFNrZg023908 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 14 Jul 2015 15:23:53 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t6EFNr9L017426; Tue, 14 Jul 2015 15:23:53 GMT Received: from l.oracle.com (/10.137.176.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 14 Jul 2015 08:23:52 -0700 Received: by l.oracle.com (Postfix, from userid 1000) id 5B15C6A01A3; Tue, 14 Jul 2015 11:23:51 -0400 (EDT) Date: Tue, 14 Jul 2015 11:23:51 -0400 From: Konrad Rzeszutek Wilk To: Ian Campbell Subject: Re: [Xen-devel] [PATCH v2 2/3] util/grub.d/20_linux_xen.in: Add arm64 support Message-ID: <20150714152351.GD10480@l.oracle.com> References: <=fu.wei@linaro.org> <1436777640-31871-1-git-send-email-fu.wei@linaro.org> <1436777640-31871-3-git-send-email-fu.wei@linaro.org> <20150714065317.36dc83aa@opensuse.site> <1436866888.25044.47.camel@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436866888.25044.47.camel@citrix.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: userv0021.oracle.com [156.151.31.71] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 141.146.126.69 Cc: grub-devel@gnu.org, xen-devel@lists.xensource.com, stefano.stabellini@eu.citrix.com, Andrei Borzenkov , phcoder@gmail.com, linaro-uefi@lists.linaro.org, leif.lindholm@linaro.org, ryan.harkin@linaro.org, jcm@redhat.com, fu.wei@linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2015 15:24:09 -0000 On Tue, Jul 14, 2015 at 10:41:28AM +0100, Ian Campbell wrote: > On Tue, 2015-07-14 at 06:53 +0300, Andrei Borzenkov wrote: > > > +if [ "x$machine" != xaarch64 ]; then > > > + multiboot_cmd="multiboot" > > > + module_cmd="module" And we should use the grub-file --is-multiboot2 to figure out if the Xen binary can also do that - and use multiboot2 protocol. But that patch I can cobble after this one is done. > > > +else > > > + multiboot_cmd="xen_hypervisor" > > > + module_cmd="xen_module" > > > +fi > > > + > > > > Strictly speaking, this is boot-time decision. As mentioned by > > Vladimir, better would be to provide alias xen_hypervisor and > > xen_module in multiboot for platforms supporting Xen (is MIPS really > > supported?) and use it consistently. > > I had been thinking of this the other way around, e.g. on platforms > which support Xen but not multiboot1 "multiboot" would be added as an > alias for xen_hypervisor. > > However so long as grub-mkconfig (via 20_linux_xen) work for everyone > and that peoples existing hand-crafted x86/multiboot/Xen grub.cfg's > continue to work then I think having the alias go either way would be > fine. > > BTW I had been going to suggest a function at the grub.cfg level which > dispatched to the correct command, but I suppose an actual alias is > better. > > Ian. > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel