From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZIfkl-0008Ol-W8 for mharc-grub-devel@gnu.org; Fri, 24 Jul 2015 12:23:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIfkj-0008OA-HP for grub-devel@gnu.org; Fri, 24 Jul 2015 12:23:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZIfke-0008Nw-J5 for grub-devel@gnu.org; Fri, 24 Jul 2015 12:23:17 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:35128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIfke-0008N3-CO for grub-devel@gnu.org; Fri, 24 Jul 2015 12:23:12 -0400 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t6OGN42K024117 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 24 Jul 2015 16:23:04 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t6OGN3oH020194 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 24 Jul 2015 16:23:04 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t6OGN2KL000697; Fri, 24 Jul 2015 16:23:02 GMT Received: from l.oracle.com (/10.137.176.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 24 Jul 2015 09:23:02 -0700 Received: by l.oracle.com (Postfix, from userid 1000) id F12046A4DBF; Fri, 24 Jul 2015 12:22:57 -0400 (EDT) Date: Fri, 24 Jul 2015 12:22:57 -0400 From: Konrad Rzeszutek Wilk To: Daniel Kiper Subject: Re: [PATCH v2 01/23] x86/boot: remove unneeded instruction Message-ID: <20150724162257.GB2220@l.oracle.com> References: <1437402558-7313-1-git-send-email-daniel.kiper@oracle.com> <1437402558-7313-2-git-send-email-daniel.kiper@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437402558-7313-2-git-send-email-daniel.kiper@oracle.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 141.146.126.69 Cc: jgross@suse.com, grub-devel@gnu.org, wei.liu2@citrix.com, keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, roy.franz@linaro.org, ning.sun@intel.com, david.vrabel@citrix.com, jbeulich@suse.com, phcoder@gmail.com, xen-devel@lists.xenproject.org, qiaowei.ren@intel.com, richard.l.maliszewski@intel.com, gang.wei@intel.com, fu.wei@linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2015 16:23:18 -0000 On Mon, Jul 20, 2015 at 04:28:56PM +0200, Daniel Kiper wrote: > Signed-off-by: Daniel Kiper Don't you use it in: /* Switch to low-memory stack. */ 193 mov sym_phys(trampoline_phys),%edi 194 lea 0x10000(%edi),%esp 195 lea trampoline_boot_cpu_entry-trampoline_start(%edi),%eax ? > --- > xen/arch/x86/boot/head.S | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S > index cfd59dc..f63b349 100644 > --- a/xen/arch/x86/boot/head.S > +++ b/xen/arch/x86/boot/head.S > @@ -169,7 +169,6 @@ __start: > /* Apply relocations to bootstrap trampoline. */ > mov sym_phys(trampoline_phys),%edx > mov $sym_phys(__trampoline_rel_start),%edi > - mov %edx,sym_phys(trampoline_phys) > 1: > mov (%edi),%eax > add %edx,(%edi,%eax) > -- > 1.7.10.4 >