From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZKUaT-0003PQ-89 for mharc-grub-devel@gnu.org; Wed, 29 Jul 2015 12:52:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKUaD-0003Nw-RA for grub-devel@gnu.org; Wed, 29 Jul 2015 12:52:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKUZZ-0007D6-FA for grub-devel@gnu.org; Wed, 29 Jul 2015 12:51:57 -0400 Received: from mail-la0-x236.google.com ([2a00:1450:4010:c03::236]:36077) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKUZZ-0007Bv-6n for grub-devel@gnu.org; Wed, 29 Jul 2015 12:51:17 -0400 Received: by lagw2 with SMTP id w2so9965543lag.3 for ; Wed, 29 Jul 2015 09:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=EQnTd1s8tz8WnwoFNDubIpPcFEP4v8+J6PMm/4FQEY4=; b=G3zrHFfuQLIuQ+znP+VGAl5VUbU5DenrdXnhPhkz5QzJxL+anb2e0XxI+mpQG0TwVJ fvd9RCegntisWUnNCMPc1l0Wn9rjQee2ib+Iw+AdoqwwXbFT7DzVe9wjIQt2Br41qJi9 Bo5aQa3PHLErlIbgYrmkneWOQmmR4AQIjJVoDAOhjAN/4F42ckCBDoaGLmZAhe484BNr fJ2pSr9CaOP4DAcpJQoSAJAOqAHuVdbmK5sMfqLAkd2hWeD60iqQPd6Jh8r308XhgWmx EJkL+qocA+ZrOmmViCS0XWr8M2Z3WGUuEt5dy2Vp5YYXVkT7edOX+C73WhpwMc7HKoF7 PNEg== X-Received: by 10.112.124.164 with SMTP id mj4mr39328111lbb.3.1438188675475; Wed, 29 Jul 2015 09:51:15 -0700 (PDT) Received: from opensuse.site (ppp91-76-6-204.pppoe.mtu-net.ru. [91.76.6.204]) by smtp.gmail.com with ESMTPSA id zf3sm5428109lbb.2.2015.07.29.09.51.14 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jul 2015 09:51:14 -0700 (PDT) Date: Wed, 29 Jul 2015 19:51:12 +0300 From: Andrei Borzenkov To: John Lane Subject: Re: [PATCH 5/5] Cryptomount support for hyphens in UUID Message-ID: <20150729195112.751a7ec9@opensuse.site> In-Reply-To: <55B87800.3060802@jelmail.com> References: <1435588260-29456-1-git-send-email-grub@jelmail.com> <1435588260-29456-6-git-send-email-grub@jelmail.com> <20150729060823.136d182a@opensuse.site> <55B87800.3060802@jelmail.com> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.28; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::236 Cc: grub-devel@gnu.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2015 16:52:11 -0000 =D0=92 Wed, 29 Jul 2015 07:51:44 +0100 John Lane =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On 29/07/15 04:08, Andrei Borzenkov wrote: > > I still believe that generally ignoring hyphens for every future crypto > > implementation is wrong. In future we simply should avoid mangling > > UUID. So this should be restricted to LUKS only, where the problem > > exists. > > > > > Andrei I modified this in response to your earlier feedback so that it > doesn't modify the user-supplied data and doesn't have any effect beyond > the three places I mentioned. That not what I mean. This patch ignores hyphens in UUID for any current and future crypto backends. This means that it cannot distinguish between 11-122 and 111-22 as UUID. And we cannot be sure we never meet such backend. And GELI as far as I can tell does not actually use hyphens. We already made mistake of mangling native UUID, I'd rather avoid continue to do it. Can we restrict this to LUKS only?=20 > These have no negative impact on uuid > values used elesewere. If you don't want to support this fair enough - > this can be dropped without impacting the other patches. >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel