From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZOshf-00023f-Tx for mharc-grub-devel@gnu.org; Mon, 10 Aug 2015 15:25:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOshb-00021j-0m for grub-devel@gnu.org; Mon, 10 Aug 2015 15:25:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZOshU-0006wp-VS for grub-devel@gnu.org; Mon, 10 Aug 2015 15:25:42 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:51476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOshU-0006wh-ND for grub-devel@gnu.org; Mon, 10 Aug 2015 15:25:36 -0400 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t7AJPSuX027664 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 10 Aug 2015 19:25:28 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t7AJPRKd005746 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 10 Aug 2015 19:25:27 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t7AJPRba014332; Mon, 10 Aug 2015 19:25:27 GMT Received: from l.oracle.com (/10.137.176.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 10 Aug 2015 12:25:27 -0700 Received: by l.oracle.com (Postfix, from userid 1000) id A04166A3C73; Mon, 10 Aug 2015 15:25:25 -0400 (EDT) Date: Mon, 10 Aug 2015 15:25:25 -0400 From: Konrad Rzeszutek Wilk To: Daniel Kiper Subject: Re: [Xen-devel] [PATCH v2 12/23] efi: split out efi_console_set_mode() Message-ID: <20150810192525.GI13576@l.oracle.com> References: <1437402558-7313-1-git-send-email-daniel.kiper@oracle.com> <1437402558-7313-13-git-send-email-daniel.kiper@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437402558-7313-13-git-send-email-daniel.kiper@oracle.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 141.146.126.69 Cc: jgross@suse.com, grub-devel@gnu.org, keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, gang.wei@intel.com, roy.franz@linaro.org, ning.sun@intel.com, david.vrabel@citrix.com, jbeulich@suse.com, phcoder@gmail.com, xen-devel@lists.xenproject.org, wei.liu2@citrix.com, richard.l.maliszewski@intel.com, qiaowei.ren@intel.com, fu.wei@linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2015 19:25:46 -0000 On Mon, Jul 20, 2015 at 04:29:07PM +0200, Daniel Kiper wrote: > ..which sets console mode. We want to re-use this > code to support multiboot2 protocol on EFI platforms. > > Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk > --- > v2 - suggestions/fixes: > - improve commit message > (suggested by Jan Beulich). > --- > xen/common/efi/boot.c | 37 ++++++++++++++++++++----------------- > 1 file changed, 20 insertions(+), 17 deletions(-) > > diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c > index 6f327cd..4614146 100644 > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -611,6 +611,25 @@ static void __init efi_init(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTabl > StdErr = SystemTable->StdErr ?: StdOut; > } > > +static void __init efi_console_set_mode(void) > +{ > + UINTN cols, rows, size; > + unsigned int best, i; > + > + for ( i = 0, size = 0, best = StdOut->Mode->Mode; > + i < StdOut->Mode->MaxMode; ++i ) > + { > + if ( StdOut->QueryMode(StdOut, i, &cols, &rows) == EFI_SUCCESS && > + cols * rows > size ) > + { > + size = cols * rows; > + best = i; > + } > + } > + if ( best != StdOut->Mode->Mode ) > + StdOut->SetMode(StdOut, best); > +} > + > static void __init setup_efi_pci(void) > { > EFI_STATUS status; > @@ -799,23 +818,7 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) > } > > if ( !base_video ) > - { > - unsigned int best; > - UINTN cols, rows, size; > - > - for ( i = 0, size = 0, best = StdOut->Mode->Mode; > - i < StdOut->Mode->MaxMode; ++i ) > - { > - if ( StdOut->QueryMode(StdOut, i, &cols, &rows) == EFI_SUCCESS && > - cols * rows > size ) > - { > - size = cols * rows; > - best = i; > - } > - } > - if ( best != StdOut->Mode->Mode ) > - StdOut->SetMode(StdOut, best); > - } > + efi_console_set_mode(); > } > > PrintStr(L"Xen " __stringify(XEN_VERSION) "." __stringify(XEN_SUBVERSION) > -- > 1.7.10.4 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel