From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZOsqc-0005CV-JX for mharc-grub-devel@gnu.org; Mon, 10 Aug 2015 15:35:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOsqV-000564-Gh for grub-devel@gnu.org; Mon, 10 Aug 2015 15:35:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZOsqS-0001wH-9m for grub-devel@gnu.org; Mon, 10 Aug 2015 15:34:55 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:22295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOsqS-0001vj-3R for grub-devel@gnu.org; Mon, 10 Aug 2015 15:34:52 -0400 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t7AJYgx1008829 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 10 Aug 2015 19:34:43 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t7AJYgOX012217 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 10 Aug 2015 19:34:42 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id t7AJYf84001775; Mon, 10 Aug 2015 19:34:41 GMT Received: from l.oracle.com (/10.137.176.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 10 Aug 2015 12:34:41 -0700 Received: by l.oracle.com (Postfix, from userid 1000) id 5BED86A3C73; Mon, 10 Aug 2015 15:34:39 -0400 (EDT) Date: Mon, 10 Aug 2015 15:34:39 -0400 From: Konrad Rzeszutek Wilk To: Daniel Kiper Subject: Re: [Xen-devel] [PATCH v2 17/23] efi: split out efi_set_gop_mode() Message-ID: <20150810193439.GN13576@l.oracle.com> References: <1437402558-7313-1-git-send-email-daniel.kiper@oracle.com> <1437402558-7313-18-git-send-email-daniel.kiper@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437402558-7313-18-git-send-email-daniel.kiper@oracle.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: userv0022.oracle.com [156.151.31.74] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 141.146.126.69 Cc: jgross@suse.com, grub-devel@gnu.org, keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, gang.wei@intel.com, roy.franz@linaro.org, ning.sun@intel.com, david.vrabel@citrix.com, jbeulich@suse.com, phcoder@gmail.com, xen-devel@lists.xenproject.org, wei.liu2@citrix.com, richard.l.maliszewski@intel.com, qiaowei.ren@intel.com, fu.wei@linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2015 19:35:01 -0000 On Mon, Jul 20, 2015 at 04:29:12PM +0200, Daniel Kiper wrote: > ..which sets chosen GOP mode. We want to re-use this > code to support multiboot2 protocol on EFI platforms. > > Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk > --- > v2 - suggestions/fixes: > - improve commit message > (suggested by Jan Beulich). > --- > xen/common/efi/boot.c | 33 ++++++++++++++++++++------------- > 1 file changed, 20 insertions(+), 13 deletions(-) > > diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c > index 177697a..04b9c7e 100644 > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -860,6 +860,25 @@ static void __init efi_variables(void) > } > } > > +static void __init efi_set_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, UINTN gop_mode) > +{ > + EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *mode_info; > + EFI_STATUS status; > + UINTN info_size; > + > + if ( !gop ) > + return; > + > + /* Set graphics mode. */ > + if ( gop_mode < gop->Mode->MaxMode && gop_mode != gop->Mode->Mode ) > + gop->SetMode(gop, gop_mode); > + > + /* Get graphics and frame buffer info. */ > + status = gop->QueryMode(gop, gop->Mode->Mode, &info_size, &mode_info); > + if ( !EFI_ERROR(status) ) > + efi_arch_video_init(gop, info_size, mode_info); > +} > + > static int __init __maybe_unused set_color(u32 mask, int bpp, u8 *pos, u8 *sz) > { > if ( bpp < 0 ) > @@ -887,7 +906,6 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) > UINTN map_key, info_size, gop_mode = ~0; > EFI_SHIM_LOCK_PROTOCOL *shim_lock; > EFI_GRAPHICS_OUTPUT_PROTOCOL *gop = NULL; > - EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *mode_info; > union string section = { NULL }, name; > bool_t base_video = 0, retry; > char *option_str; > @@ -1105,18 +1123,7 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) > > efi_arch_memory_setup(); > > - if ( gop ) > - { > - > - /* Set graphics mode. */ > - if ( gop_mode < gop->Mode->MaxMode && gop_mode != gop->Mode->Mode ) > - gop->SetMode(gop, gop_mode); > - > - /* Get graphics and frame buffer info. */ > - status = gop->QueryMode(gop, gop->Mode->Mode, &info_size, &mode_info); > - if ( !EFI_ERROR(status) ) > - efi_arch_video_init(gop, info_size, mode_info); > - } > + efi_set_gop_mode(gop, gop_mode); > > info_size = 0; > efi_bs->GetMemoryMap(&info_size, NULL, &map_key, > -- > 1.7.10.4 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel