From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZQFHN-0006by-QG for mharc-grub-devel@gnu.org; Fri, 14 Aug 2015 09:44:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQFHL-0006Zw-US for grub-devel@gnu.org; Fri, 14 Aug 2015 09:44:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZQFHH-0004Zm-SM for grub-devel@gnu.org; Fri, 14 Aug 2015 09:44:15 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:26331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQFHH-0004Yz-MD for grub-devel@gnu.org; Fri, 14 Aug 2015 09:44:11 -0400 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t7EDi2Tv017235 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 14 Aug 2015 13:44:02 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t7EDi0gJ019449 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 14 Aug 2015 13:44:01 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id t7EDhwfO005694; Fri, 14 Aug 2015 13:43:59 GMT Received: from l.oracle.com (/10.137.176.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 14 Aug 2015 06:43:58 -0700 Received: by l.oracle.com (Postfix, from userid 1000) id B183E6A065C; Fri, 14 Aug 2015 09:43:56 -0400 (EDT) Date: Fri, 14 Aug 2015 09:43:56 -0400 From: Konrad Rzeszutek Wilk To: Daniel Kiper Subject: Re: [PATCH v2 23/23] x86: add multiboot2 protocol support for relocatable images Message-ID: <20150814134356.GC12254@l.oracle.com> References: <1437402558-7313-1-git-send-email-daniel.kiper@oracle.com> <1437402558-7313-24-git-send-email-daniel.kiper@oracle.com> <20150811165658.GC32231@l.oracle.com> <20150814115701.GB8034@olila.local.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150814115701.GB8034@olila.local.net-space.pl> User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 141.146.126.69 Cc: jgross@suse.com, grub-devel@gnu.org, wei.liu2@citrix.com, keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, roy.franz@linaro.org, ning.sun@intel.com, david.vrabel@citrix.com, jbeulich@suse.com, phcoder@gmail.com, xen-devel@lists.xenproject.org, qiaowei.ren@intel.com, richard.l.maliszewski@intel.com, gang.wei@intel.com, fu.wei@linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Aug 2015 13:44:16 -0000 On Fri, Aug 14, 2015 at 01:57:01PM +0200, Daniel Kiper wrote: > On Tue, Aug 11, 2015 at 12:56:58PM -0400, Konrad Rzeszutek Wilk wrote: > > On Mon, Jul 20, 2015 at 04:29:18PM +0200, Daniel Kiper wrote: > > > Add multiboot2 protocol support for relocatable images. Only GRUB2 > > > with relevant patches understands that feature. Older multiboot > > > > You may want to enumerate what those 'relevant' patches are. > > > > > protocol (regardless of version) compatible loaders ignore it > > > and everything works as usual. > > > > > > Signed-off-by: Daniel Kiper > > > --- > > > xen/arch/x86/boot/head.S | 46 +++++++++++++++++++++++++++++-------- > > > xen/arch/x86/x86_64/asm-offsets.c | 1 + > > > xen/include/xen/multiboot2.h | 13 +++++++++++ > > > 3 files changed, 50 insertions(+), 10 deletions(-) > > > > > > diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S > > > index d484f68..2520e48 100644 > > > --- a/xen/arch/x86/boot/head.S > > > +++ b/xen/arch/x86/boot/head.S > > > @@ -81,6 +81,13 @@ multiboot1_header_end: > > > /* Align modules at page boundry. */ > > > mb2ht_init MB2_HT(MODULE_ALIGN), MB2_HT(REQUIRED) > > > > > > + /* Load address preference. */ > > > + mb2ht_init MB2_HT(RELOCATABLE), MB2_HT(OPTIONAL), \ > > > + sym_phys(start), /* Min load address. */ \ > > > > We could go straight to __start? > > This specifies lowest load address not entry point. Ah right. And the __start can be moved somewhere inside the .text code, while 'start' is always at offset 0. Thank you! > > Daniel