From: Colin Watson <cjwatson@ubuntu.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] syslinux_test: Fix out-of-tree build handling
Date: Mon, 19 Sep 2016 16:43:41 +0100 [thread overview]
Message-ID: <20160919154341.GA13998@riva.ucam.org> (raw)
In-Reply-To: <CAA91j0X0JLK-+Kg6WmnYsF3nsbdEc=dtJPJhM=vatLr1JBgsPw@mail.gmail.com>
On Mon, Sep 19, 2016 at 04:17:38PM +0300, Andrei Borzenkov wrote:
> Current GIT should support relative pathnames; this is better
> solution. I had in mind syslinux test, but as you are working on it
> anyway could you look at simply cd'ing into correct directory and
> using relative pathnames everywhere?
I tried, but I'm afraid that doesn't work; grub-syslinux2cfg still calls
grub_canonicalize_file_name on its --root argument, and that produces a
canonicalised absolute pathname, so the output still contains quite a
few absolute paths. Given that, I think my previous patch is the
simplest approach.
--
Colin Watson [cjwatson@ubuntu.com]
prev parent reply other threads:[~2016-09-19 15:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 16:33 [PATCH] syslinux_test: Fix out-of-tree build handling Colin Watson
2016-09-19 13:17 ` Andrei Borzenkov
2016-09-19 15:43 ` Colin Watson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919154341.GA13998@riva.ucam.org \
--to=cjwatson@ubuntu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).