From: Daniel Kiper <dkiper@net-space.pl>
To: agraf@suse.de, grub-devel@gnu.org
Cc: dkiper@net-space.pl, arvidjaar@gmail.com, leif.lindholm@linaro.org
Subject: Re: [PATCH 1/2] arm64: Move firmware fdt search into global function
Date: Wed, 16 Nov 2016 12:05:16 +0100 [thread overview]
Message-ID: <20161116110516.GL16470@router-fw-old.local.net-space.pl> (raw)
In-Reply-To: <f07df9d1-7da9-a6c1-8c77-9e5908eebc61@suse.de>
On Wed, Nov 16, 2016 at 11:33:26AM +0100, Alexander Graf wrote:
> On 16/11/2016 11:28, Daniel Kiper wrote:
> >On Tue, Nov 15, 2016 at 10:07:39PM +0100, Alexander Graf wrote:
[...]
> >>Uh, the point of the function was to share code between 32bit and 64bit
> >>arm platforms which are completely separate archs.
> >>
> >>There's also effort underway to run with device tree on x86:
> >>
> >> https://plus.google.com/+ChristopherFriedt/posts/SfDifuC1xsR
> >
> >OK but right know we build FDT code for every EFI platform. This
> >is not nice because not every EFI platform uses/knows FDT (at least
> >today). So, I think that we should revert that patch and then you
> >can provide another patch which puts FDT code in separate file, e.g.
> >grub-core/kern/efi/fdt.c build only on platforms supporting FDT.
> >Does it make sense?
>
> It probably makes a lot more sense to move it to that file rather than
> revert the patches, as this is patch 1/2 and you would have to revert
> the actual 32bit arm enablement as well, breaking bisectability for
> 32bit arm.
OK, let's go that way. I am waiting for your patch(es).
Daniel
prev parent reply other threads:[~2016-11-16 11:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-28 23:22 [PATCH 1/2] arm64: Move firmware fdt search into global function Alexander Graf
2016-02-28 23:22 ` [PATCH 2/2] arm efi: Use fdt from firmware when available Alexander Graf
2016-03-10 20:00 ` Vladimir 'phcoder' Serbinenko
2016-03-13 14:44 ` Leif Lindholm
2016-11-10 12:27 ` Daniel Kiper
2016-11-12 9:03 ` [PATCH 1/2] arm64: Move firmware fdt search into global function Andrei Borzenkov
2016-11-15 21:00 ` Daniel Kiper
2016-11-15 21:07 ` Alexander Graf
2016-11-16 10:28 ` Daniel Kiper
2016-11-16 10:33 ` Alexander Graf
2016-11-16 11:05 ` Daniel Kiper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161116110516.GL16470@router-fw-old.local.net-space.pl \
--to=dkiper@net-space.pl \
--cc=agraf@suse.de \
--cc=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
--cc=leif.lindholm@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).