From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1c7RdL-0005wh-AE for mharc-grub-devel@gnu.org; Thu, 17 Nov 2016 13:42:03 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7RdJ-0005wY-C7 for grub-devel@gnu.org; Thu, 17 Nov 2016 13:42:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7RdE-0000Ov-Gy for grub-devel@gnu.org; Thu, 17 Nov 2016 13:42:01 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:26012) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c7RdE-0000O9-9R for grub-devel@gnu.org; Thu, 17 Nov 2016 13:41:56 -0500 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id uAHIfpBk001064 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Nov 2016 18:41:51 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id uAHIfpU9016238 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Nov 2016 18:41:51 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id uAHIfo3f031076; Thu, 17 Nov 2016 18:41:50 GMT Received: from localhost.localdomain (/209.6.196.81) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 17 Nov 2016 10:41:50 -0800 Date: Thu, 17 Nov 2016 13:41:47 -0500 From: Konrad Rzeszutek Wilk To: The development of GNU GRUB Cc: hufman@gmail.com, arvidjaar@gmail.com, Daniel Kiper Subject: Re: Patch: Improve HTTP time by sending Connection:close Message-ID: <20161117184147.GD29877@localhost.localdomain> References: <20161115132157.GD16470@router-fw-old.local.net-space.pl> <20161115204451.GF16470@router-fw-old.local.net-space.pl> <20161117183216.GA5612@router-fw-old.local.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161117183216.GA5612@router-fw-old.local.net-space.pl> User-Agent: Mutt/1.7.1 (2016-10-04) X-Source-IP: userv0022.oracle.com [156.151.31.74] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 156.151.31.81 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2016 18:42:02 -0000 On Thu, Nov 17, 2016 at 07:32:16PM +0100, Daniel Kiper wrote: > On Tue, Nov 15, 2016 at 01:43:16PM -0800, Walter Huf wrote: > > GRUB has a bug where it waits a minimum of 400ms for every file it fetches > > over HTTP, unless the server serves it with Transfer-Encoding:chunked or > > the file just happens to be split into 20 TCP packets. When using > > pxeboot.img built with just pxe and http module (following instructions > > from https://www.gnu.org/software/grub/manual/html_node/Network.html), this > > causes an initial text menu to take about 7 seconds to load with all the > > modules being dynamically fetched. > > I agree that this looks like a bug. > > > The SOB (statement of benefit?) of this patch is to fix this bug with the > > smallest change to existing data structures and logic. > > I meant Signed-off-by: ... > In your case it should look like: > > Signed-off-by: Walter Huf It is not as simple as that. Putting your SoB means that you: Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. then you just add a line saying Signed-off-by: Random J Developer