From: Daniel Kiper <dkiper@net-space.pl>
To: arvidjaar@gmail.com, phcoder@gmail.com, grub-devel@gnu.org
Cc: nikunj@linux.vnet.ibm.com
Subject: Re: [2.02][PATCH] bootp: export server IP as environment variable
Date: Thu, 17 Nov 2016 20:02:34 +0100 [thread overview]
Message-ID: <20161117190234.GA7245@router-fw-old.local.net-space.pl> (raw)
In-Reply-To: <1458322920-5131-1-git-send-email-arvidjaar@gmail.com>
On Fri, Mar 18, 2016 at 08:42:00PM +0300, Andrei Borzenkov wrote:
> Network boot autoconfiguration sets default server to next server IP
> (siaddr) from BOOTP/DHCP reply, but manual configuration using net_bootp
> exports only server name. Unfortunately semantic of server name is not
> clearly defined. BOOTP RFC 951 defines it only for client request, and
> DHCP RFC 1541 only mentions it, without any implied usage. It looks like
> this field is mostly empty in server replies.
>
> Export next server IP as net_<interface>_server_ip variable. This allows
> grub configuration script to set $root/$prefix based on information obtained
> by net_bootp.
>
> Reported and tested by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
> Cc: nikunj@linux.vnet.ibm.com
>
> ---
>
> @Nikunj: cosmetic changes comparing with version you tested - no need to
> allocate small buffer dynamically.
>
> @Vladimir: I think this is useful; I will update networking documentation
> in followup patch.
Vladimir, Andrei, could you take care of it?
Daniel
next prev parent reply other threads:[~2016-11-17 19:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 17:42 [2.02][PATCH] bootp: export server IP as environment variable Andrei Borzenkov
2016-11-17 19:02 ` Daniel Kiper [this message]
2016-11-18 18:11 ` Andrei Borzenkov
2016-11-21 13:09 ` Daniel Kiper
2016-11-21 19:52 ` Andrei Borzenkov
2016-11-21 22:02 ` Daniel Kiper
2016-11-22 17:21 ` Andrei Borzenkov
2016-11-22 18:19 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117190234.GA7245@router-fw-old.local.net-space.pl \
--to=dkiper@net-space.pl \
--cc=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
--cc=nikunj@linux.vnet.ibm.com \
--cc=phcoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).