From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1dekk6-0002Qg-V5 for mharc-grub-devel@gnu.org; Mon, 07 Aug 2017 12:18:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dekk0-0002Li-Q9 for grub-devel@gnu.org; Mon, 07 Aug 2017 12:18:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dekjv-0004aN-Rg for grub-devel@gnu.org; Mon, 07 Aug 2017 12:18:52 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:27984) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dekjv-0004ZH-H4 for grub-devel@gnu.org; Mon, 07 Aug 2017 12:18:47 -0400 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v77GIhli023029 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 7 Aug 2017 16:18:44 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v77GIgOA017212 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 7 Aug 2017 16:18:43 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id v77GIgnR013127; Mon, 7 Aug 2017 16:18:42 GMT Received: from char.us.oracle.com (/10.137.176.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 07 Aug 2017 09:18:42 -0700 Received: by char.us.oracle.com (Postfix, from userid 1000) id 490C06A00E9; Mon, 7 Aug 2017 12:18:41 -0400 (EDT) Date: Mon, 7 Aug 2017 12:18:41 -0400 From: Konrad Rzeszutek Wilk To: The development of GNU GRUB Cc: Daniel Kiper Subject: Re: [PATCH v2 14/14] efi: change heap allocation type to GRUB_EFI_LOADER_CODE Message-ID: <20170807161841.GS29262@char.us.oracle.com> References: <20170803100432.29913-1-leif.lindholm@linaro.org> <20170803100432.29913-15-leif.lindholm@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-Received-From: 141.146.126.69 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Aug 2017 16:18:58 -0000 On Mon, Aug 07, 2017 at 02:11:16PM +0000, Vladimir 'phcoder' Serbinenko w= rote: > LGTM Is LGTM equivalant to Acked-by? >=20 > Le Thu, Aug 3, 2017 =E0 12:09 PM, Leif Lindholm a > =E9crit : >=20 > > With upcoming changes to EDK2, allocations of type EFI_LOADER_DATA ma= y > > not return regions with execute ability. Since modules are loaded ont= o > > the heap, change the heap allocation type to GRUB_EFI_LOADER_CODE in > > order to permit execution on systems with this feature enabled. > > > > Closes: 50420 > > > > Signed-off-by: Leif Lindholm > > --- > > grub-core/kern/efi/mm.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/grub-core/kern/efi/mm.c b/grub-core/kern/efi/mm.c > > index c8fffe902..f1424f2e4 100644 > > --- a/grub-core/kern/efi/mm.c > > +++ b/grub-core/kern/efi/mm.c > > @@ -448,7 +448,9 @@ add_memory_regions (grub_efi_memory_descriptor_t > > *memory_map, > > pages =3D required_pages; > > } > > > > - addr =3D grub_efi_allocate_pages (start, pages); > > + addr =3D grub_efi_allocate_pages_real (start, pages, > > + GRUB_EFI_ALLOCATE_ADDRESS, > > + GRUB_EFI_LOADER_CODE); > > if (! addr) > > grub_fatal ("cannot allocate conventional memory %p with %u p= ages", > > (void *) ((grub_addr_t) start), > > -- > > 2.11.0 > > > > > > _______________________________________________ > > Grub-devel mailing list > > Grub-devel@gnu.org > > https://lists.gnu.org/mailman/listinfo/grub-devel > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel