From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: ZFS boot environment patch
Date: Fri, 15 Sep 2017 09:50:11 -0400 [thread overview]
Message-ID: <20170915135011.GT11040@char.us.oracle.com> (raw)
In-Reply-To: <20170914235739.lwvcahiy6qjevljg@riva.ucam.org>
On Fri, Sep 15, 2017 at 12:57:39AM +0100, Colin Watson wrote:
> On Thu, Sep 14, 2017 at 09:22:01PM +0200, Paul Lagerweij wrote:
> > On Wed, 13 Sep 2017 at 09:17:42PM +0100, Colin Watson wrote:
> > > > On Wed, Sep 13, 2017 at 11:02:48AM -0400, Konrad Rzeszutek Wilk wrote:
> > > > > @@ -62,9 +63,15 @@ case x"$GRUB_FS" in
> > > > > + zfs_active_bootfs="`zpool list -H -o bootfs ${rpool} || true`"
> > > >
> > > > Is zpool usually in /sbin or such? Perhaps a full path?
> > >
> > > Full paths are brittle when they refer to something installed by a
> > > different package. If you need to do that kind of thing then it's
> > > usually better to temporarily extend $PATH instead.
> >
> > Do you mean that grub-mkconfig has its own $PATH and that I should
> > temporarily change it to the user's $PATH? If so, can the 10_linux script
> > see the user's $PATH?
>
> No, that's not what we mean. Konrad's point is that /sbin (and
> /usr/sbin) may not be in $PATH when grub-mkconfig is invoked. (I'm not
> sure I agree that this is likely because grub-mkconfig is normally
> invoked as root and root's $PATH normally includes /sbin, but Konrad
> seems to think it's a possibility worth worrying about.)
>
> A reasonable solution to this kind of thing is to set
> PATH="$PATH:/sbin:/usr/sbin" to ensure that utilities there are
> available.
Which is much better than what I had mind. In other words, just
disregard my suggestion to add '/sbin' to the patch.
>
> --
> Colin Watson [cjwatson@ubuntu.com]
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
next prev parent reply other threads:[~2017-09-15 13:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 19:22 ZFS boot environment patch Paul Lagerweij
2017-09-14 23:57 ` Colin Watson
2017-09-15 10:33 ` Vladimir 'phcoder' Serbinenko
2017-09-15 13:50 ` Konrad Rzeszutek Wilk [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-09-15 10:24 Paul Lagerweij
2017-09-01 11:31 Paul Lagerweij
2017-09-13 15:02 ` Konrad Rzeszutek Wilk
2017-09-13 20:17 ` Colin Watson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915135011.GT11040@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).