From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1dsr0g-0005ul-HK for mharc-grub-devel@gnu.org; Fri, 15 Sep 2017 09:50:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsr0e-0005tk-Lk for grub-devel@gnu.org; Fri, 15 Sep 2017 09:50:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsr0a-00049y-K0 for grub-devel@gnu.org; Fri, 15 Sep 2017 09:50:19 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:32693) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dsr0a-00048k-AJ for grub-devel@gnu.org; Fri, 15 Sep 2017 09:50:16 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v8FDoEnx001057 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 15 Sep 2017 13:50:14 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v8FDoDPk011737 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 15 Sep 2017 13:50:14 GMT Received: from ubhmp0012.oracle.com (ubhmp0012.oracle.com [156.151.24.65]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v8FDoCx6019217 for ; Fri, 15 Sep 2017 13:50:12 GMT Received: from char.us.oracle.com (/10.137.176.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 15 Sep 2017 13:50:12 +0000 Received: by char.us.oracle.com (Postfix, from userid 1000) id 5638B6A0764; Fri, 15 Sep 2017 09:50:11 -0400 (EDT) Date: Fri, 15 Sep 2017 09:50:11 -0400 From: Konrad Rzeszutek Wilk To: The development of GNU GRUB Subject: Re: ZFS boot environment patch Message-ID: <20170915135011.GT11040@char.us.oracle.com> References: <20170914235739.lwvcahiy6qjevljg@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170914235739.lwvcahiy6qjevljg@riva.ucam.org> User-Agent: Mutt/1.8.3 (2017-05-23) X-Source-IP: userv0021.oracle.com [156.151.31.71] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-Received-From: 141.146.126.69 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Sep 2017 13:50:21 -0000 On Fri, Sep 15, 2017 at 12:57:39AM +0100, Colin Watson wrote: > On Thu, Sep 14, 2017 at 09:22:01PM +0200, Paul Lagerweij wrote: > > On Wed, 13 Sep 2017 at 09:17:42PM +0100, Colin Watson wrote: > > > > On Wed, Sep 13, 2017 at 11:02:48AM -0400, Konrad Rzeszutek Wilk wrote: > > > > > @@ -62,9 +63,15 @@ case x"$GRUB_FS" in > > > > > + zfs_active_bootfs="`zpool list -H -o bootfs ${rpool} || true`" > > > > > > > > Is zpool usually in /sbin or such? Perhaps a full path? > > > > > > Full paths are brittle when they refer to something installed by a > > > different package. If you need to do that kind of thing then it's > > > usually better to temporarily extend $PATH instead. > > > > Do you mean that grub-mkconfig has its own $PATH and that I should > > temporarily change it to the user's $PATH? If so, can the 10_linux script > > see the user's $PATH? > > No, that's not what we mean. Konrad's point is that /sbin (and > /usr/sbin) may not be in $PATH when grub-mkconfig is invoked. (I'm not > sure I agree that this is likely because grub-mkconfig is normally > invoked as root and root's $PATH normally includes /sbin, but Konrad > seems to think it's a possibility worth worrying about.) > > A reasonable solution to this kind of thing is to set > PATH="$PATH:/sbin:/usr/sbin" to ensure that utilities there are > available. Which is much better than what I had mind. In other words, just disregard my suggestion to add '/sbin' to the patch. > > -- > Colin Watson [cjwatson@ubuntu.com] > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel