grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
* About text mode on EFI when booting Linux
@ 2017-11-09  9:49 Dennis Chen
  2017-11-09 10:43 ` Matthias Lange
  0 siblings, 1 reply; 2+ messages in thread
From: Dennis Chen @ 2017-11-09  9:49 UTC (permalink / raw)
  To: grub-devel; +Cc: phcoder, fedora.dm0, nd

Hi Vladimir,

We encounter an error message "no suitable video mode found" when
booting a VM on i386 platform. Though I think this is not a big problem,
but the LinuxKit guys(we use grub2 in LinuxKit project) have some
concerns about this error message, so I submit a patch[1] try to
eliminate this message. Would you please take a look at that patch?

I also dig into the commit logs of the grub2 git tree, and found below
commit:

commit b1257f653367e8d21b625276f53f086d68fab0b3
Author: Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>
Date:   Tue Aug 16 16:11:10 2011 +0200

        Don't accept text modes on EFI when booting Linux.
    
        * grub-core/loader/i386/linux.c (ACCEPTS_PURE_TEXT): New define.
        (grub_linux_boot) [!ACCEPTS_PURE_TEXT]: Restrict to graphics modes. 

...
diff --git a/grub-core/loader/i386/linux.c b/grub-core/loader/i386/linux.c
index 9e3d482..5356d7a 100644
--- a/grub-core/loader/i386/linux.c
+++ b/grub-core/loader/i386/linux.c
@@ -45,15 +45,18 @@ GRUB_MOD_LICENSE ("GPLv3+");
 #include <grub/efi/efi.h>
 #define HAS_VGA_TEXT 0
 #define DEFAULT_VIDEO_MODE "auto"
+#define ACCEPTS_PURE_TEXT 0
 #elif defined (GRUB_MACHINE_IEEE1275)
 #include <grub/ieee1275/ieee1275.h>
 #define HAS_VGA_TEXT 0

I am very curious about the context/background of this commit here, what's
the reason leads us not to accept a text modes on EFI when booting Linux?

[1] https://lists.gnu.org/archive/html/grub-devel/2017-10/msg00031.html

Thanks,
Dennis 


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-11-09 10:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-09  9:49 About text mode on EFI when booting Linux Dennis Chen
2017-11-09 10:43 ` Matthias Lange

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).