From: Peter Jones <pjones@redhat.com>
To: Daniel Kiper <dkiper@net-space.pl>
Cc: grub-devel@gnu.org
Subject: Re: [PATCH 1/2] mkimage: avoid copying relocations for sections that won't be copied.
Date: Tue, 20 Feb 2018 18:26:01 -0500 [thread overview]
Message-ID: <20180220232443.hs3u75ghseb2mgfq@redhat.com> (raw)
In-Reply-To: <20180220144844.GA29532@router-fw-old.local.net-space.pl>
On Tue, Feb 20, 2018 at 03:48:44PM +0100, Daniel Kiper wrote:
> On Wed, Jan 31, 2018 at 11:26:59AM -0500, Peter Jones wrote:
> > +static int
> > +SUFFIX (is_kept_section) (Elf_Shdr *s, const struct grub_install_image_target_desc *image_target);
> > +static int
> > +SUFFIX (is_kept_reloc_section) (Elf_Shdr *s, const struct grub_install_image_target_desc *image_target,
> > + Elf_Shdr *sections, Elf_Half section_entsize, Elf_Half num_sections,
> > + const char *strtab);
>
> Ugh... Could not you create a struct and pass the pointer to it here?
Fair enough - I did it that way because the whole file seems averse to
that sort of thing, and once you start doing it, it gets a bit messy.
Nevertheless, I'll send you a patchset that includes that in just a few
minutes.
> PS Please CC me on the patches next time.
Will do.
--
Peter
prev parent reply other threads:[~2018-02-20 23:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 16:26 [PATCH 1/2] mkimage: avoid copying relocations for sections that won't be copied Peter Jones
2018-01-31 16:27 ` [PATCH 2/2] .mod files: Strip annobin annotations and .eh_frame, and their relocations Peter Jones
2018-02-15 22:03 ` Vladimir 'phcoder' Serbinenko
2018-02-20 14:51 ` Daniel Kiper
2018-02-20 23:29 ` Peter Jones
2018-02-15 21:52 ` [PATCH 1/2] mkimage: avoid copying relocations for sections that won't be copied Peter Jones
2018-02-15 22:03 ` Vladimir 'phcoder' Serbinenko
2018-02-20 14:48 ` Daniel Kiper
2018-02-20 23:25 ` [PATCH v2 1/3] mkimage: refactor a bunch of section data into a struct Peter Jones
2018-02-20 23:25 ` [PATCH v2 2/3] mkimage: avoid copying relocations for sections that won't be copied Peter Jones
2018-02-21 11:18 ` Daniel Kiper
2018-02-20 23:25 ` [PATCH v2 3/3] .mod files: Strip annobin annotations and .eh_frame, and their relocations Peter Jones
2018-02-21 11:22 ` Daniel Kiper
2018-02-21 11:07 ` [PATCH v2 1/3] mkimage: refactor a bunch of section data into a struct Daniel Kiper
2018-02-21 20:18 ` Peter Jones
2018-02-21 20:20 ` [PATCH v3 1/7] aout.h: Fix missing include Peter Jones
2018-02-21 20:20 ` [PATCH v3 2/7] mkimage: make it easier to run syntax checkers on grub-mkimagexx.c Peter Jones
2018-02-23 14:27 ` Daniel Kiper
2018-02-21 20:20 ` [PATCH v3 3/7] mkimage: rename a couple of things to be less confusing later Peter Jones
2018-02-23 14:29 ` Daniel Kiper
2018-02-21 20:20 ` [PATCH v3 4/7] mkimage: make locate_sections() set up vaddresses as well Peter Jones
2018-02-23 14:38 ` Daniel Kiper
2018-02-21 20:20 ` [PATCH v3 5/7] mkimage: refactor a bunch of section data into a struct Peter Jones
2018-02-23 14:51 ` Daniel Kiper
2018-02-23 15:27 ` Peter Jones
2018-02-21 20:20 ` [PATCH v3 6/7] mkimage: avoid copying relocations for sections that won't be copied Peter Jones
2018-02-23 14:54 ` Daniel Kiper
2018-02-21 20:20 ` [PATCH v3 7/7] .mod files: Strip annobin annotations and .eh_frame, and their relocations Peter Jones
2018-02-23 14:54 ` Daniel Kiper
2018-02-23 14:56 ` Daniel Kiper
2018-02-23 14:15 ` [PATCH v3 1/7] aout.h: Fix missing include Daniel Kiper
2018-02-20 23:26 ` Peter Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220232443.hs3u75ghseb2mgfq@redhat.com \
--to=pjones@redhat.com \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).