grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Kiper <dkiper@net-space.pl>
To: mchang@suse.com
Cc: grub-devel@gnu.org, sriram-s@hpe.com
Subject: Re: efinet SNP issue affects iscsi boot
Date: Thu, 20 Sep 2018 14:01:08 +0200	[thread overview]
Message-ID: <20180920120108.GA17654@router-fw-old.i.net-space.pl> (raw)
In-Reply-To: <20180920103807.sidtlmre2oztx7h3@mazu>

On Thu, Sep 20, 2018 at 06:38:07PM +0800, Michael Chang wrote:
> On Thu, Sep 13, 2018 at 06:06:15PM -0600, Micah Parrish wrote:
> > Hi, new subscriber here.? We have a problem with Grub 2 and its use of SNP
> > instead of MNP.? Our UEFI driver for a network card parses the relevant DHCP
> > options for iSCSI boot, generates an iBFT table, then gets closed by Grub
> > when it opens the SNP interface. The driver removes the iBFT table as part
> > of normal unload cleanup.? I think this should happen with the Tianocore
> > UEFI reference driver as well.? The problem is often masked or does not
> > occur when there are multiple network ports enabled.? It occurs with several
> > different vendors NICs.
> >
> > Possible solutions I see:
> >
> > 1. Grub parses the DHCP options and creates its own iBFT.
> >
> > 2. Grub copies the already generated iBFT before destroying the interface.
> >
> > 3. Grub opens the network interface MNP instead of SNP.
> >
> > Although I am a neophyte at grub and UEFI development, I would like to start
> > a discussion on possible solutions.? Has anyone else seen this?
>
> For possible solution 3, I managed to work out patch to use MNP but is not
> polished, although it survived my testing. If you don't mind and willing to
> give it go I will post it here as RFC patch for review.

That would be perfect. However, there are a few things worth mentioning here.

The issue is never ending story. So, please look for relevant discussions
in grub-devel archives and take them into account if it is possible/make sense.
If you have any difficulties with finding them drop me a line.

Please do not drop SNP driver. I think that we should make MNP driver a new
default and SNP should stay as a backup. Just in case.

Additionally, a few days ago I have started looking for people interested
in the project. There are some. Hence, if you are going to take a stab at
it I will ask them to do some reviews of your work. I will drop you their
emails if they are happy to do so.

Daniel


  reply	other threads:[~2018-09-20 12:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-14  0:06 efinet SNP issue affects iscsi boot Micah Parrish
2018-09-20 10:38 ` Michael Chang
2018-09-20 12:01   ` Daniel Kiper [this message]
2018-09-27 10:15     ` Michael Chang
2018-09-27 16:29       ` Daniel Kiper
     [not found] <mailman.6307.1537451267.1283.grub-devel@gnu.org>
2018-09-20 19:26 ` Micah Parrish
2018-09-27 10:22   ` Michael Chang
     [not found] <mailman.31.1538064006.6859.grub-devel@gnu.org>
2018-09-27 18:58 ` Micah Parrish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180920120108.GA17654@router-fw-old.i.net-space.pl \
    --to=dkiper@net-space.pl \
    --cc=grub-devel@gnu.org \
    --cc=mchang@suse.com \
    --cc=sriram-s@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).