From: Andre Przywara <andre.przywara@arm.com>
To: Daniel Kiper <dkiper@net-space.pl>
Cc: Vladimir Serbinenko <phcoder@gmail.com>,
Andrei Borzenkov <arvidjaar@gmail.com>,
Daniel Kiper <daniel.kiper@oracle.com>,
Mark Rutland <mark.rutland@arm.com>, <grub-devel@gnu.org>
Subject: Re: [PATCH] bootp: add native DHCPv4 support
Date: Mon, 11 Feb 2019 18:10:47 +0000 [thread overview]
Message-ID: <20190211181047.299610dc@donnerap.cambridge.arm.com> (raw)
In-Reply-To: <20190124141319.fse4uzv3sqmr3oel@tomti.i.net-space.pl>
On Thu, 24 Jan 2019 15:13:19 +0100
Daniel Kiper <dkiper@net-space.pl> wrote:
Hi Daniel,
> On Mon, Jan 21, 2019 at 02:10:48PM +0000, Andre Przywara wrote:
> > On Mon, 21 Jan 2019 13:02:08 +0100
> > Daniel Kiper <dkiper@net-space.pl> wrote:
...
> > > Is it possible to split this patch to smaller pieces?
> >
> > Possible: yes, though I am not sure I understand enough of it and grub
> > to do it properly. Will try my best, though, as soon as I find some
> > spare cycles to understand the patch a bit better.
>
> Is it matter of days, weeks or months?
Apparently a matter of 18 days ;-)
So I read the Wikipedia pages for DHCP and BOOTP, skimmed over the various RFCs and wrapped my head around the high level functionality of the grub network stack. After starring a while at Andrei's patch I think I figured what he did.
So I managed to break it down into a series of refactoring patches, with some patches on top to add the actual DHCP functionality.
I will clean that up and try to test it as far as possible.
> > The rest of the comments make sense, I will address them eventually,
> > unless someone (Andrei?) screams...
>
> Thanks a lot!
>
> I am looking forward for next version of this patch.
Prepare for a series of 9 patches (at the moment) later this week. ;-)
Cheers,
Andre.
next prev parent reply other threads:[~2019-02-11 18:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 15:59 [PATCH] bootp: add native DHCPv4 support Andre Przywara
2019-01-21 12:02 ` Daniel Kiper
2019-01-21 14:10 ` Andre Przywara
2019-01-24 14:13 ` Daniel Kiper
2019-02-11 18:10 ` Andre Przywara [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-03-20 7:29 Andrei Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211181047.299610dc@donnerap.cambridge.arm.com \
--to=andre.przywara@arm.com \
--cc=arvidjaar@gmail.com \
--cc=daniel.kiper@oracle.com \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
--cc=mark.rutland@arm.com \
--cc=phcoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).