From: Miguel Arruga Vivas <rosen644835@gmail.com>
To: grub-devel@gnu.org
Cc: Daniel Kiper <dkiper@net-space.pl>
Subject: [PATCH] install: Free allocated path for grub.efi.
Date: Mon, 28 Oct 2019 12:27:43 +0100 [thread overview]
Message-ID: <20191028122743.098fcb72@gmail.com> (raw)
In-Reply-To: <20191028122531.188744b3@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 115 bytes --]
Hi,
This patch is a minor issue, but in terms of correctness I think this
free is missing.
Happy hacking,
Miguel
[-- Attachment #2: 0001-install-Free-allocated-path-for-grub.efi.patch --]
[-- Type: text/x-patch, Size: 816 bytes --]
From 1720e89de777fd3a30a6824797d97855b7bb8b68 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miguel=20=C3=81ngel=20Arruga=20Vivas?=
<rosen644835@gmail.com>
Date: Mon, 28 Oct 2019 10:08:25 +0100
Subject: [PATCH 1/2] install: Free allocated path for grub.efi.
* util/grub-install.c (main): Free local variable allocated with
grub_util_path_concat.
---
util/grub-install.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/grub-install.c b/util/grub-install.c
index 8970b73aa..8f84bf8cd 100644
--- a/util/grub-install.c
+++ b/util/grub-install.c
@@ -1664,6 +1664,7 @@ main (int argc, char *argv[])
/* memdisk */ NULL,
have_load_cfg ? load_cfg : NULL,
/* image target */ mkimage_target, 0);
+ free (dst);
}
break;
case GRUB_INSTALL_PLATFORM_ARM_EFI:
--
2.23.0
next prev parent reply other threads:[~2019-10-28 11:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 14:30 Reproducible grub-install Miguel Arruga Vivas
2019-10-23 9:09 ` Daniel Kiper
2019-10-28 11:25 ` Granularity of grub-install (was Re: Reproducibility of grub-install) Miguel Arruga Vivas
2019-10-28 11:27 ` Miguel Arruga Vivas [this message]
2019-10-28 21:01 ` [PATCH 2/2] install: Add only-platform-installation option Miguel Arruga Vivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028122743.098fcb72@gmail.com \
--to=rosen644835@gmail.com \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox