From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kIugR-0002YC-5T for mharc-grub-devel@gnu.org; Thu, 17 Sep 2020 10:14:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIugO-0002WR-Gm for grub-devel@gnu.org; Thu, 17 Sep 2020 10:14:45 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:40655) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIugM-0002Af-Bg for grub-devel@gnu.org; Thu, 17 Sep 2020 10:14:44 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 1AE635C018B; Thu, 17 Sep 2020 10:14:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 17 Sep 2020 10:14:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=LoFAsGCPIXhgnEqw/8y+ALm1TvZ xI2JV0JlEFk5W1yo=; b=CFe6e9iBlabvYlX/+BDeNLRCv0EB5ZttG/oT80agSfo BPDPwbZIBaK70MZ47cCHxJLFsISM0GeBmL/ihUaiggEMfL/4NK7QWsDcjD85UWyj HIzoC31oGezhFYcf2FmO47j9ZDkykuN1sANYrjHQn7AFIm1KHsoTiugLHhoCx56c bYq0w62yaJtJNiooXzxJYfCYkoh/+X3oT2f/OyMqFVnJRSKgAVlTlXNa4APHlQJV LacbciuAkKmoFdGNKDBpf0g+i6mI6jZL6SVXwDFp00fxX6yGI40X4HczHzFdKzEI Tl5YS20GEyuziizmMBRsAl9ibQPkkpm6QOZ/SRrmlKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=LoFAsG CPIXhgnEqw/8y+ALm1TvZxI2JV0JlEFk5W1yo=; b=d4TDRSRn7qo7N9j55WER+N jdsjqrU13DpPVKTdEk/0Sjhs7en5p4WoA6QeXlsSnUZRgrd27FeowWCR011vkQrn 6qWYlCUJ7dLmJXX6Vbcz0v20yaJjOpVAu2Lix5qSiELyDB4jUrJJ8UyfGXSW7zUW +GPU8zwYNQPQBL83ysK/8tMdch4f7aU496z/UM0ZIFAC/n909innui/f5TwusK1a C/VDmElqxOfQWHNZID+HpmwTRWeohhve34SNskjEpGvKydzYjXkIBZNjMStqWXxp QHluafcLE3o14ZI19JSBfg2HMMuLKCHnKjzA/HLD2L7Py+eUyQZPKwif4dG0mAqA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrtdeggdejhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomheprfgrthhrihgt khcuufhtvghinhhhrghrughtuceophhssehpkhhsrdhimheqnecuggftrfgrthhtvghrnh epheeghfdtfeeuffehkefgffduleffjedthfdvjeektdfhhedvlefgtefgvdettdfhnecu kfhppeejjedrudeluddrfeejrddvtdelnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepphhssehpkhhsrdhimh X-ME-Proxy: Received: from vm-mail.pks.im (x4dbf25d1.dyn.telefonica.de [77.191.37.209]) by mail.messagingengine.com (Postfix) with ESMTPA id 5B6CB306467D; Thu, 17 Sep 2020 10:14:37 -0400 (EDT) Received: from localhost (tanuki [10.192.0.23]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id 6031c0ae (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 17 Sep 2020 14:14:33 +0000 (UTC) Date: Thu, 17 Sep 2020 16:14:32 +0200 From: Patrick Steinhardt To: grub-devel@gnu.org Cc: Denis GNUtoo Carikli , Glenn Washburn , Daniel Kiper Subject: Re: [PATCH v3 0/9] Cryptodisk fixes for v2.06 Message-ID: <20200917141432.GA33367@tanuki.pks.im> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9jxsPFA5p3P2qPhR" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=66.111.4.29; envelope-from=ps@pks.im; helo=out5-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/17 10:05:48 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2020 14:14:46 -0000 --9jxsPFA5p3P2qPhR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 07, 2020 at 05:27:27PM +0200, Patrick Steinhardt wrote: > this is the third version of this patchset, collecting various fixes for > LUKS2/cryptodisk for the upcoming release of GRUB v2.06. >=20 > Besides my Reviewed-by tag, the only thing that changed is the final > patch by Glenn. Quoting him: >=20 > > The main difference with this patch is that sector_size is renamed = to > > log_sector_size, grub has enough inaccurate or misleading names. > > Additionally, rename LOG_SECTOR_SIZE to LUKS_LOG_SECTOR_SIZE and > > CRYPT_LOG_SECTOR_SIZE to GRUB_CRYPTODISK_IV_LOG_SIZE and moved to > > cryptodisk.h. Also a comment was reworded for clarity. A subset of these patches has been applied by Daniel, leaving us at (rearranged for better readability): > Glenn Washburn (6): > cryptodisk: Fix incorrect calculation of start sector > cryptodisk: Unregister cryptomount command when removing module Both were picked. > luks2: Fix use of incorrect index and some error messages > luks2: grub_cryptodisk_t->total_length is the max number of device > native sectors > cryptodisk: Fix cipher IV mode 'plain64' always being set as 'plain' > cryptodisk: Properly handle non-512 byte sized sectors These weren't yet and got some feedback. > Patrick Steinhardt (3): > json: Remove invalid typedef redefinition > luks: Fix out-of-bounds copy of UUID > luks2: Improve error reporting when decrypting/verifying key All three of these have been applied. @Glenn: seeing that all of my patches have been applied, do you want to take over your remaining four patches again? That'd probably make the process easier for both of us. Patrick --9jxsPFA5p3P2qPhR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAl9jb0cACgkQVbJhu7ck PpSfvA/+JbdmlCyPng79MovjGrFCqWF42h0BoXZu3DHynncZtRqjWK7Yypek3vOq Ycwm2ihRAiHvBmimsnaoLByu0aFNINV58zddScBW/tNXvc1RV1FLa8IvToYQB/Yp 7G+Hjv5mciWuElqXKeeg1Oc75eU0BpAoktSktk+GLORfSAsoww1bKD62dwU4HZ6Z TDA3yZacncSe/TPKkpldlmjBZQ6JqCE5NlB/EiltQCs0BR27dSzxt+ekG3wZqZML i455rhLkwvJhcnqGf4gZqaA33pCWr+VHhprsGQlymxnw32OUVKSWgGrM5VtpivIa Ptr6z8WrC97IDp6Zs6QLHUz5DHQhyq8j1F+Wp1eIB/gZLr30rn9tunO4OgauORv8 Chjlww+X64xNlbIyWn8LZBw9QQYE9b4GLMHzbsBKpDzxRyk296trH6+Kyz/PNLGk QnBQe+SMwJRW/22kl6XdKV4/6OrvTMh98ZdL6Dj32zyWHDgefFA4DgxiJE5nVS+4 8wwptKskjz5torG3KLnDJWbFUrWFMKRCi4L+EzRtF7on0CaDrAZaFp9osJhJBpN/ s3Ime/85hbN6Icam/qo4Il7kSs/d4ctUz0C1DcrmLsSkewi8H70rSkX/7rE7UAjC Jd027BX17/jVtRirTe3aLNnuUMBDRzT4kBvFWDwWdcRjN9PbAl8= =XE/j -----END PGP SIGNATURE----- --9jxsPFA5p3P2qPhR--