From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kOPJN-0006Lc-P0 for mharc-grub-devel@gnu.org; Fri, 02 Oct 2020 13:57:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOPJM-0006Hv-5e for grub-devel@gnu.org; Fri, 02 Oct 2020 13:57:40 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:40112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOPJJ-0005ee-1N for grub-devel@gnu.org; Fri, 02 Oct 2020 13:57:39 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 092HrviC001811; Fri, 2 Oct 2020 17:57:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=1kZgTf+tnIMPETUtpnGtP1o2c/m9BWnf47W0ZzKqL4w=; b=MQgaZnrC4YIPALeBq9nmbJvrsle2zwB1EB0WbcqrD3KpIljQYvuUSXQquwy2eC6oIE3r 6W0w25vpt9JwRappYhk/VwuWbw4g8buLAh4pf6Ob6TcHSNkoZW6FZvMzmtFsbgIVvBd4 jpwKAanx4hmFX8tGVsBl2GdKkuLYJZCLFpiFAIT0uhCf9JdLDLyll2TqmI//RJo26dol oPpzLKlp803Ynx6Cbx68xVMuCxBUgHXuLg2da+ZkWzkOFjLRdvFKe4dXyOnYEh6lDBUB 0GRRov59jEMsHqn6LWdqaoFIgtj4zzHyI8cr48IjnXraJXA9nz9BD0/sg47ngbdRhiGI uw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2130.oracle.com with ESMTP id 33wupg339h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 02 Oct 2020 17:57:29 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 092Hp2hA144010; Fri, 2 Oct 2020 17:57:29 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 33uv2jmv09-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 02 Oct 2020 17:57:29 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 092HvSNT002449; Fri, 2 Oct 2020 17:57:28 GMT Received: from char.us.oracle.com (/10.152.32.25) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 02 Oct 2020 10:57:28 -0700 Received: by char.us.oracle.com (Postfix, from userid 1000) id 71FB56A012C; Fri, 2 Oct 2020 13:58:58 -0400 (EDT) Date: Fri, 2 Oct 2020 13:58:58 -0400 From: Konrad Rzeszutek Wilk To: The development of GNU GRUB Cc: rashmica.g@gmail.com, alastair@d-silva.org, Daniel Axtens Subject: Re: [PATCH 08/18] libtasn1: import libtasn1-4.16.0 Message-ID: <20201002175858.GA14414@char.us.oracle.com> References: <20201002051321.1538488-1-dja@axtens.net> <20201002051321.1538488-9-dja@axtens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201002051321.1538488-9-dja@axtens.net> User-Agent: Mutt/1.9.1 (2017-09-22) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9762 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010020131 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9762 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 clxscore=1011 phishscore=0 mlxscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010020131 Received-SPF: pass client-ip=141.146.126.79; envelope-from=konrad.wilk@oracle.com; helo=aserp2130.oracle.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/02 12:00:34 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2020 17:57:40 -0000 On Fri, Oct 02, 2020 at 03:13:11PM +1000, Daniel Axtens wrote: > Import a very trimmed-down set of libtasn1 files: > > pushd /tmp > wget https://ftp.gnu.org/gnu/libtasn1/libtasn1-4.16.0.tar.gz > popd > pushd grub-core/lib > mkdir libtasn1 > cp /tmp/libtasn1-4.16.0/{README.md,LICENSE} libtasn1/ > mkdir libtasn1/lib > cp /tmp/libtasn1-4.16.0/lib/{coding.c,decoding.c,element.c,element.h,errors.c,gstr.c,gstr.h,int.h,parser_aux.c,parser_aux.h,structure.c,structure.h} libtasn1/lib > cp /tmp/libtasn1-4.16.0/lib/includes/libtasn1.h ../../include/grub/ > git add libtasn1/ ../../include/grub/libtasn1.h > popd > > Signed-off-by: Daniel Axtens > --- > grub-core/lib/libtasn1/LICENSE | 16 + > grub-core/lib/libtasn1/README.md | 91 + > grub-core/lib/libtasn1/lib/coding.c | 1415 +++++++++++++ > grub-core/lib/libtasn1/lib/decoding.c | 2478 +++++++++++++++++++++++ > grub-core/lib/libtasn1/lib/element.c | 1111 ++++++++++ > grub-core/lib/libtasn1/lib/element.h | 40 + > grub-core/lib/libtasn1/lib/errors.c | 100 + > grub-core/lib/libtasn1/lib/gstr.c | 74 + > grub-core/lib/libtasn1/lib/gstr.h | 47 + > grub-core/lib/libtasn1/lib/int.h | 221 ++ > grub-core/lib/libtasn1/lib/parser_aux.c | 1173 +++++++++++ > grub-core/lib/libtasn1/lib/parser_aux.h | 172 ++ > grub-core/lib/libtasn1/lib/structure.c | 1220 +++++++++++ > grub-core/lib/libtasn1/lib/structure.h | 45 + > include/grub/libtasn1.h | 588 ++++++ > 15 files changed, 8791 insertions(+) > create mode 100644 grub-core/lib/libtasn1/LICENSE > create mode 100644 grub-core/lib/libtasn1/README.md > create mode 100644 grub-core/lib/libtasn1/lib/coding.c > create mode 100644 grub-core/lib/libtasn1/lib/decoding.c > create mode 100644 grub-core/lib/libtasn1/lib/element.c > create mode 100644 grub-core/lib/libtasn1/lib/element.h > create mode 100644 grub-core/lib/libtasn1/lib/errors.c > create mode 100644 grub-core/lib/libtasn1/lib/gstr.c > create mode 100644 grub-core/lib/libtasn1/lib/gstr.h > create mode 100644 grub-core/lib/libtasn1/lib/int.h > create mode 100644 grub-core/lib/libtasn1/lib/parser_aux.c > create mode 100644 grub-core/lib/libtasn1/lib/parser_aux.h > create mode 100644 grub-core/lib/libtasn1/lib/structure.c > create mode 100644 grub-core/lib/libtasn1/lib/structure.h > create mode 100644 include/grub/libtasn1.h > > diff --git a/grub-core/lib/libtasn1/LICENSE b/grub-core/lib/libtasn1/LICENSE > new file mode 100644 > index 000000000000..e8b3628db9b8 > --- /dev/null > +++ b/grub-core/lib/libtasn1/LICENSE > @@ -0,0 +1,16 @@ > +LICENSING > +========= > + > +The libtasn1 library is released under the GNU Lesser General Public > +License (LGPL) version 2.1 or later; see [COPYING.LESSER](doc/COPYING.LESSER) > +for the license terms. > + > +The GNU LGPL applies to the main libtasn1 library, while the > +included applications library are under the GNU GPL version 3. > +The libtasn1 library is located in the lib directory, while the applications > +in src/. GRUB is GPL-v3. This is not. Can you re-license it to be GPL-v3?