Grub Development Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javierm@redhat.com>
To: grub-devel@gnu.org
Cc: Daniel Kiper <daniel.kiper@oracle.com>,
	Javier Martinez Canillas <javierm@redhat.com>
Subject: [PATCH 2/2] arm: Include missing <grub/symbol.h> header
Date: Thu,  5 Nov 2020 15:58:57 +0100	[thread overview]
Message-ID: <20201105145857.1136767-2-javierm@redhat.com> (raw)
In-Reply-To: <20201105145857.1136767-1-javierm@redhat.com>

The header uses the EXPORT_FUNC() macro defined in <grub/types.h> but
doens't include it, which leads to the following compile error on arm:

../include/grub/cpu/system.h:12:13: error: ‘EXPORT_FUNC’ declared as function returning a function
   12 | extern void EXPORT_FUNC(grub_arm_disable_caches_mmu) (void);
      |             ^~~~~~~~~~~
../include/grub/cpu/system.h:12:1: warning: parameter names (without types) in function declaration
   12 | extern void EXPORT_FUNC(grub_arm_disable_caches_mmu) (void);
      | ^~~~~~
make[3]: *** [Makefile:36581: kern/efi/kernel_exec-sb.o] Error 1

Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---

 include/grub/arm/system.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/grub/arm/system.h b/include/grub/arm/system.h
index f62c18c13a8..f15ce9751a5 100644
--- a/include/grub/arm/system.h
+++ b/include/grub/arm/system.h
@@ -1,6 +1,7 @@
 #ifndef GRUB_SYSTEM_CPU_HEADER
 #define GRUB_SYSTEM_CPU_HEADER
 
+#include <grub/symbol.h>
 #include <grub/types.h>
 
 enum
-- 
2.28.0



  reply	other threads:[~2020-11-05 14:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-05 14:58 [PATCH 1/2] loader/i386/linux: Include missing <grub/types.h> header Javier Martinez Canillas
2020-11-05 14:58 ` Javier Martinez Canillas [this message]
2020-11-18 18:06 ` Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201105145857.1136767-2-javierm@redhat.com \
    --to=javierm@redhat.com \
    --cc=daniel.kiper@oracle.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox