grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Hamilton <adhamilt@gmail.com>
To: grub-devel@gnu.org
Cc: daniel.kiper@oracle.com, Andrew Hamilton <adhamilt@gmail.com>
Subject: [PATCH 0/1] grub-shell: Correct Test Failures
Date: Sat, 21 Jun 2025 10:50:37 -0500	[thread overview]
Message-ID: <20250621155038.146060-1-adhamilt@gmail.com> (raw)

It was observed that netboot_test and file_filter_test
are failing currently when running 'make check'.
This is being caused by the tmp folder cleanup failing
at the end of these tests, from grub-shell.

The following error is seen in these test logs:
"rmdir: failed to remove '/tmp/grub-shell.2VvsV9ZkH6':
Directory not empty"

This was traced back to the creation of a subfolder
in these two tests for netboot. Update grub-shell.in
to remove this subfolder when netboot option is used.

Andrew Hamilton (1):
  tests: Correct netboot and file_filter test failure

 tests/util/grub-shell.in | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.39.5


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

             reply	other threads:[~2025-06-21 15:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-21 15:50 Andrew Hamilton [this message]
2025-06-21 15:50 ` [PATCH 1/1] tests: Correct netboot and file_filter test failure Andrew Hamilton
2025-06-23 17:38   ` Leo Sandoval via Grub-devel
2025-06-23 17:40   ` Daniel Kiper via Grub-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250621155038.146060-1-adhamilt@gmail.com \
    --to=adhamilt@gmail.com \
    --cc=daniel.kiper@oracle.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).