* [PATCH 0/1] po: Fix GRUB Build With Gettext 0.26
@ 2025-08-23 3:43 Andrew Hamilton
2025-08-23 3:43 ` [PATCH 1/1] po: Update Translations to Build with " Andrew Hamilton
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Hamilton @ 2025-08-23 3:43 UTC (permalink / raw)
To: grub-devel; +Cc: daniel.kiper, savannah, Andrew Hamilton
Gettext 0.26 validates format strings. In some cases before
the GRUB build process was converting newlines sequences (\n)
to (\<translated character>) which is invalid. Update the impacted
language SED script files to ensure newlines use the correct escape
sequence.
This avoids build errors such as:
de@hebrew.po:8192: 'msgstr' is not a valid Shell printf format string,
unlike 'msgid'. Reason: This escape sequence is invalid.
Fixes: https://savannah.gnu.org/bugs/?67353
Andrew Hamilton (1):
po: Update Translations to Build with Gettext 0.26
po/arabic.sed | 2 ++
po/cyrillic.sed | 2 ++
po/greek.sed | 2 ++
po/hebrew.sed | 2 ++
4 files changed, 8 insertions(+)
--
2.39.5
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] po: Update Translations to Build with Gettext 0.26
2025-08-23 3:43 [PATCH 0/1] po: Fix GRUB Build With Gettext 0.26 Andrew Hamilton
@ 2025-08-23 3:43 ` Andrew Hamilton
2025-08-23 9:14 ` Vladimir 'phcoder' Serbinenko
2025-08-25 14:36 ` Daniel Kiper via Grub-devel
0 siblings, 2 replies; 4+ messages in thread
From: Andrew Hamilton @ 2025-08-23 3:43 UTC (permalink / raw)
To: grub-devel; +Cc: daniel.kiper, savannah, Andrew Hamilton
Gettext 0.26 validates format strings. In some cases before
the GRUB build process was converting newlines sequences (\n)
to (\<translated character>) which is invalid. Update the impacted
language SED script files to ensure newlines use the correct escape
sequence.
This avoids build errors such as:
de@hebrew.po:8192: 'msgstr' is not a valid Shell printf format string,
unlike 'msgid'. Reason: This escape sequence is invalid.
Fixes: https://savannah.gnu.org/bugs/?67353
Signed-off-by: Andrew Hamilton <adhamilt@gmail.com>
---
po/arabic.sed | 2 ++
po/cyrillic.sed | 2 ++
po/greek.sed | 2 ++
po/hebrew.sed | 2 ++
4 files changed, 8 insertions(+)
diff --git a/po/arabic.sed b/po/arabic.sed
index 3fbee7248..50bede0f8 100644
--- a/po/arabic.sed
+++ b/po/arabic.sed
@@ -81,3 +81,5 @@ s,%\([0-9]*\)زو,%\1zu,g
s,%\([0-9]*\)كس,%\1x,g
s,%\([0-9]*\)لكس,%\1lx,g
s,%\([0-9]*\)للكس,%\1llx,g
+
+s,\\ن,\\n,g
diff --git a/po/cyrillic.sed b/po/cyrillic.sed
index 472f09529..d3db38838 100644
--- a/po/cyrillic.sed
+++ b/po/cyrillic.sed
@@ -104,3 +104,5 @@ s,%\([0-9]*\)зу,%\1zu,g
s,%\([0-9]*\)ѯ,%\1x,g
s,%\([0-9]*\)лѯ,%\1lx,g
s,%\([0-9]*\)ллѯ,%\1llx,g
+
+s,\\н,\\n,g
diff --git a/po/greek.sed b/po/greek.sed
index 0e81625fb..1ace5fcd2 100644
--- a/po/greek.sed
+++ b/po/greek.sed
@@ -106,3 +106,5 @@ s,%\([0-9]*\)ζυ,%\1zu,g
s,%\([0-9]*\)ξ,%\1x,g
s,%\([0-9]*\)λξ,%\1lx,g
s,%\([0-9]*\)λλξ,%\1llx,g
+
+s,\\ν,\\n,g
diff --git a/po/hebrew.sed b/po/hebrew.sed
index 33174bbdc..ce59e576e 100644
--- a/po/hebrew.sed
+++ b/po/hebrew.sed
@@ -89,3 +89,5 @@ s,%\([0-9]*\)זוּ,%\1zu,g
s,%\([0-9]*\)כּס,%\1x,g
s,%\([0-9]*\)לכּס,%\1lx,g
s,%\([0-9]*\)ללכּס,%\1llx,g
+
+s,\\נ,\\n,g
--
2.39.5
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] po: Update Translations to Build with Gettext 0.26
2025-08-23 3:43 ` [PATCH 1/1] po: Update Translations to Build with " Andrew Hamilton
@ 2025-08-23 9:14 ` Vladimir 'phcoder' Serbinenko
2025-08-25 14:36 ` Daniel Kiper via Grub-devel
1 sibling, 0 replies; 4+ messages in thread
From: Vladimir 'phcoder' Serbinenko @ 2025-08-23 9:14 UTC (permalink / raw)
To: The development of GNU GRUB
[-- Attachment #1.1: Type: text/plain, Size: 2266 bytes --]
Looks good. Reviewed-by: Vladimir Serbinenko phcoder@gmail.com
Regards
Vladimir 'phcoder' Serbinenko
Le sam. 23 août 2025, 06:44, Andrew Hamilton <adhamilt@gmail.com> a écrit :
> Gettext 0.26 validates format strings. In some cases before
> the GRUB build process was converting newlines sequences (\n)
> to (\<translated character>) which is invalid. Update the impacted
> language SED script files to ensure newlines use the correct escape
> sequence.
>
> This avoids build errors such as:
> de@hebrew.po:8192: 'msgstr' is not a valid Shell printf format string,
> unlike 'msgid'. Reason: This escape sequence is invalid.
>
> Fixes: https://savannah.gnu.org/bugs/?67353
>
> Signed-off-by: Andrew Hamilton <adhamilt@gmail.com>
> ---
> po/arabic.sed | 2 ++
> po/cyrillic.sed | 2 ++
> po/greek.sed | 2 ++
> po/hebrew.sed | 2 ++
> 4 files changed, 8 insertions(+)
>
> diff --git a/po/arabic.sed b/po/arabic.sed
> index 3fbee7248..50bede0f8 100644
> --- a/po/arabic.sed
> +++ b/po/arabic.sed
> @@ -81,3 +81,5 @@ s,%\([0-9]*\)زو,%\1zu,g
> s,%\([0-9]*\)كس,%\1x,g
> s,%\([0-9]*\)لكس,%\1lx,g
> s,%\([0-9]*\)للكس,%\1llx,g
> +
> +s,\\ن,\\n,g
> diff --git a/po/cyrillic.sed b/po/cyrillic.sed
> index 472f09529..d3db38838 100644
> --- a/po/cyrillic.sed
> +++ b/po/cyrillic.sed
> @@ -104,3 +104,5 @@ s,%\([0-9]*\)зу,%\1zu,g
> s,%\([0-9]*\)ѯ,%\1x,g
> s,%\([0-9]*\)лѯ,%\1lx,g
> s,%\([0-9]*\)ллѯ,%\1llx,g
> +
> +s,\\н,\\n,g
> diff --git a/po/greek.sed b/po/greek.sed
> index 0e81625fb..1ace5fcd2 100644
> --- a/po/greek.sed
> +++ b/po/greek.sed
> @@ -106,3 +106,5 @@ s,%\([0-9]*\)ζυ,%\1zu,g
> s,%\([0-9]*\)ξ,%\1x,g
> s,%\([0-9]*\)λξ,%\1lx,g
> s,%\([0-9]*\)λλξ,%\1llx,g
> +
> +s,\\ν,\\n,g
> diff --git a/po/hebrew.sed b/po/hebrew.sed
> index 33174bbdc..ce59e576e 100644
> --- a/po/hebrew.sed
> +++ b/po/hebrew.sed
> @@ -89,3 +89,5 @@ s,%\([0-9]*\)זוּ,%\1zu,g
> s,%\([0-9]*\)כּס,%\1x,g
> s,%\([0-9]*\)לכּס,%\1lx,g
> s,%\([0-9]*\)ללכּס,%\1llx,g
> +
> +s,\\נ,\\n,g
> --
> 2.39.5
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #1.2: Type: text/html, Size: 3204 bytes --]
[-- Attachment #2: Type: text/plain, Size: 141 bytes --]
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] po: Update Translations to Build with Gettext 0.26
2025-08-23 3:43 ` [PATCH 1/1] po: Update Translations to Build with " Andrew Hamilton
2025-08-23 9:14 ` Vladimir 'phcoder' Serbinenko
@ 2025-08-25 14:36 ` Daniel Kiper via Grub-devel
1 sibling, 0 replies; 4+ messages in thread
From: Daniel Kiper via Grub-devel @ 2025-08-25 14:36 UTC (permalink / raw)
To: Andrew Hamilton; +Cc: Daniel Kiper, grub-devel, savannah
On Fri, Aug 22, 2025 at 10:43:17PM -0500, Andrew Hamilton wrote:
> Gettext 0.26 validates format strings. In some cases before
> the GRUB build process was converting newlines sequences (\n)
> to (\<translated character>) which is invalid. Update the impacted
> language SED script files to ensure newlines use the correct escape
> sequence.
>
> This avoids build errors such as:
> de@hebrew.po:8192: 'msgstr' is not a valid Shell printf format string,
> unlike 'msgid'. Reason: This escape sequence is invalid.
>
> Fixes: https://savannah.gnu.org/bugs/?67353
>
> Signed-off-by: Andrew Hamilton <adhamilt@gmail.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-25 14:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-23 3:43 [PATCH 0/1] po: Fix GRUB Build With Gettext 0.26 Andrew Hamilton
2025-08-23 3:43 ` [PATCH 1/1] po: Update Translations to Build with " Andrew Hamilton
2025-08-23 9:14 ` Vladimir 'phcoder' Serbinenko
2025-08-25 14:36 ` Daniel Kiper via Grub-devel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).