grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Leo Sandoval via Grub-devel <grub-devel@gnu.org>
To: grub-devel@gnu.org
Cc: Leo Sandoval <lsandova@redhat.com>
Subject: [PATCH 3/3] tests: remove -w param from mkfs.hfsplus
Date: Fri, 19 Sep 2025 15:45:05 -0600	[thread overview]
Message-ID: <20250919214516.1693171-4-lsandova@redhat.com> (raw)
In-Reply-To: <20250919214516.1693171-1-lsandova@redhat.com>

Apparently the man page is outdated because the option '-w' is shown
but not on 'mkfs.hfsplus --usage'. According to Gemini

    The -w option is usedto add an HFS wrapper around an HFS Plus file
    system, which is sometimes required for compatibility with older
    Mac OS 9 systems. However, this is not a standard or commonly used
    option and may not be available in all versions of the hfsprogs package,
    especially on Linux.

Signed-off-by: Leo Sandoval <lsandova@redhat.com>
---
 tests/util/grub-fs-tester.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in
index cac58dafa8..599b5f1762 100644
--- a/tests/util/grub-fs-tester.in
+++ b/tests/util/grub-fs-tester.in
@@ -727,7 +727,7 @@ for LOGSECSIZE in $(range "$MINLOGSECSIZE" "$MAXLOGSECSIZE" 1); do
 		    "mkfs.hfsplus" -b $BLKSIZE -v "$FSLABEL" "${MOUNTDEVICE}"
 		    dd if=/dev/urandom of="${MOUNTDEVICE}" bs=1 seek=$((0x468)) conv=notrunc count=8 ;;
 		x"hfsplus_wrap")
-		    "mkfs.hfsplus" -w -b $BLKSIZE -v "$FSLABEL" "${MOUNTDEVICE}"
+		    "mkfs.hfsplus" -b $BLKSIZE -v "$FSLABEL" "${MOUNTDEVICE}"
 		    dd if=/dev/urandom of="${MOUNTDEVICE}" bs=1 seek=$((0x468)) conv=notrunc count=8
 		    MOUNTFS="hfsplus";;
 		x"hfsplus_casesens")
-- 
2.50.1


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

  parent reply	other threads:[~2025-09-19 21:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-19 21:45 [PATCH 0/3] tests: improvements and fixes for the test suite Leo Sandoval via Grub-devel
2025-09-19 21:45 ` [PATCH 1/3] tests: skip tests if required tools are not available Leo Sandoval via Grub-devel
2025-11-09  4:28   ` Glenn Washburn
2025-09-19 21:45 ` [PATCH 2/3] tests: include verbosity on tests.in checks Leo Sandoval via Grub-devel
2025-11-09  4:47   ` Glenn Washburn
2025-09-19 21:45 ` Leo Sandoval via Grub-devel [this message]
2025-11-09  3:34   ` [PATCH 3/3] tests: remove -w param from mkfs.hfsplus Glenn Washburn
2025-11-09  3:44     ` Glenn Washburn
2025-11-05 19:25 ` [PATCH 0/3] tests: improvements and fixes for the test suite Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250919214516.1693171-4-lsandova@redhat.com \
    --to=grub-devel@gnu.org \
    --cc=lsandova@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).