From: Andrew Hamilton <adhamilt@gmail.com>
To: grub-devel@gnu.org
Cc: daniel.kiper@oracle.com, safinaskar@zohomail.com,
benh@debian.org, bluca@debian.org, kibi@debian.org,
Andrew Hamilton <adhamilt@gmail.com>
Subject: [PATCH 1/1] build: Disable building video_bochs for EFI x86 platforms
Date: Sun, 28 Sep 2025 09:29:49 -0500 [thread overview]
Message-ID: <20250928142949.142548-2-adhamilt@gmail.com> (raw)
In-Reply-To: <20250928142949.142548-1-adhamilt@gmail.com>
Disable building video_bochs for EFI x86 platforms. For EFI platforms
efi_gop or efi_uga should provide the video support. Currently,
in EFI platforms there is a risk that both the bochs devices is
present and the EFI video interface - which can cause unexpected
video corruption when a mix of the two interfaces are used. This
can happen when all_video is loaded for simplicity in a GRUB config.
Fixes: https://savannah.gnu.org/bugs/index.php?66200
Signed-off-by: Andrew Hamilton <adhamilt@gmail.com>
---
grub-core/Makefile.core.def | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def
index 0fcf67f9d..0caaec9dd 100644
--- a/grub-core/Makefile.core.def
+++ b/grub-core/Makefile.core.def
@@ -2169,7 +2169,11 @@ module = {
module = {
name = video_bochs;
x86 = video/bochs.c;
- enable = x86;
+ enable = i386_pc;
+ enable = i386_qemu;
+ enable = i386_coreboot;
+ enable = i386_multiboot;
+ enable = i386_ieee1275;
};
module = {
--
2.47.3
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
next prev parent reply other threads:[~2025-09-28 14:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-28 14:29 [PATCH 0/1] Correct Video Corruption for EFI Plus Bochs Andrew Hamilton
2025-09-28 14:29 ` Andrew Hamilton [this message]
2025-09-29 4:43 ` Askar Safin via Grub-devel
2025-09-29 12:04 ` Andrew Hamilton
2025-09-29 17:47 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250928142949.142548-2-adhamilt@gmail.com \
--to=adhamilt@gmail.com \
--cc=benh@debian.org \
--cc=bluca@debian.org \
--cc=daniel.kiper@oracle.com \
--cc=grub-devel@gnu.org \
--cc=kibi@debian.org \
--cc=safinaskar@zohomail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).