From: Avnish Chouhan <avnish@linux.ibm.com>
To: grub-devel@gnu.org
Cc: daniel.kiper@oracle.com, Avnish Chouhan <avnish@linux.ibm.com>
Subject: [PATCH 1/4] normal: Adding a grub_malloc failure check in completion.c
Date: Tue, 28 Oct 2025 22:01:59 +0530 [thread overview]
Message-ID: <20251028163202.63905-2-avnish@linux.ibm.com> (raw)
In-Reply-To: <20251028163202.63905-1-avnish@linux.ibm.com>
This patch adds a NULL check in grub_malloc(). Missing a failure check
after calling grub_malloc() can lead to undefined behavior. If the allocation
fails and returns NULL, subsequent dereferencing or writing to the pointer
will likely result in a runtime error such as a segmentation fault.
Signed-off-by: Avnish Chouhan <avnish@linux.ibm.com>
---
grub-core/normal/completion.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/grub-core/normal/completion.c b/grub-core/normal/completion.c
index 18cadfa..4058e0a 100644
--- a/grub-core/normal/completion.c
+++ b/grub-core/normal/completion.c
@@ -490,6 +490,9 @@ grub_normal_do_completion (char *buf, int *restore,
spaces++;
ret = grub_malloc (match_len - current_len + grub_strlen (suffix) + spaces + 1);
+ if (ret == NULL)
+ goto fail;
+
newstr = ret;
for (escstr = match + current_len; *escstr; escstr++)
{
--
2.47.1
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
next prev parent reply other threads:[~2025-10-28 16:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 16:31 [PATCH 0/4] Adding a failure check after grub_malloc() Avnish Chouhan
2025-10-28 16:31 ` Avnish Chouhan [this message]
2025-11-02 14:54 ` [PATCH 1/4] normal: Adding a grub_malloc failure check in completion.c Sudhakar Kuppusamy
2025-10-28 16:32 ` [PATCH 2/4] Adding a grub_malloc failure check in msdos.c Avnish Chouhan
2025-11-02 14:57 ` Sudhakar Kuppusamy
2025-10-28 16:32 ` [PATCH 3/4] Adding a grub_malloc failure check in mmap.c Avnish Chouhan
2025-11-02 14:58 ` Sudhakar Kuppusamy
2025-10-28 16:32 ` [PATCH 4/4] Adding a grub_malloc failure check in legacy_parse.c Avnish Chouhan
2025-11-02 15:00 ` Sudhakar Kuppusamy
2025-11-05 19:11 ` [PATCH 0/4] Adding a failure check after grub_malloc() Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251028163202.63905-2-avnish@linux.ibm.com \
--to=avnish@linux.ibm.com \
--cc=daniel.kiper@oracle.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).