[PATCH] bootstrap: Run linguas.sh in bootstrap epilogue

[PATCH] bootstrap: Run linguas.sh in bootstrap epilogue

[Glenn Washburn]

Heretofore, linguas.sh had to be run by the user and a common mistake
made when building GRUB was to not run the command. By adding it to
the bootstrap epilogue it will get run at the end of the bootstrap
script. The user no longer needs to remember to run it.

Update INSTALL file to reflect that it is no longer necessary to run
linguas.sh. Also, fix a list numbering error.

Fixes: 9f73ebd49be (* INSTALL: Document linguas.sh.)
Signed-off-by: Glenn Washburn <development@efficientek.com>
---
 INSTALL        | 17 +++++++----------
 bootstrap.conf |  4 ++++
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/INSTALL b/INSTALL
index 724584c575e2..2b40cc59227b 100644
--- a/INSTALL
+++ b/INSTALL
@@ -136,15 +136,12 @@ The simplest way to compile this package is:
 
   1. `cd' to the directory containing the package's source code.
 
-  2. Skip this and following step if you use release tarball and proceed to
-     step 4. If you want translations type `./linguas.sh'.
-  
-  3. Type `./bootstrap'.
+  2. Type `./bootstrap'.
 
      The autogen.sh (called by bootstrap) uses python. By default autodetect
      it, but it can be overridden by setting the PYTHON variable.
 
-  4. Type `./configure' to configure the package for your system.
+  3. Type `./configure' to configure the package for your system.
      If you're using `csh' on an old version of System V, you might
      need to type `sh ./configure' instead to prevent `csh' from trying
      to execute `configure' itself.
@@ -152,19 +149,19 @@ The simplest way to compile this package is:
      Running `configure' takes awhile.  While running, it prints some
      messages telling which features it is checking for.
 
-  6. Type `make' to compile the package.
+  4. Type `make' to compile the package.
 
-  7. Optionally, type `make check' to run any self-tests that come with
+  5. Optionally, type `make check' to run any self-tests that come with
      the package. Note that many of the tests require root privileges in
      order to run.
 
-  8. Type `make install' to install the programs and any data files and
+  6. Type `make install' to install the programs and any data files and
      documentation.
 
-  9. Type `make html' or `make pdf' to generate the html or pdf
+  7. Type `make html' or `make pdf' to generate the html or pdf
      documentation.  Note, these are not built by default.
 
- 10. You can remove the program binaries and object files from the
+  8. You can remove the program binaries and object files from the
      source code directory by typing `make clean'.  To also remove the
      files that `configure' created (so you can compile the package for
      a different kind of computer), type `make distclean'.  There is
diff --git a/bootstrap.conf b/bootstrap.conf
index 7a7813d28254..c85905d35c20 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -100,4 +100,8 @@ bootstrap_post_import_hook () {
 
 bootstrap_epilogue () {
   mv INSTALL.grub INSTALL
+
+  # Update translation files and create LINGUAS file used to determine
+  # the set of languages used to translate.
+  ./linguas.sh
 }
-- 
2.34.1


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] INSTALL: Fix a grammatical error

[Glenn Washburn]

Also, add more documentation mentioning that the tests require a
"specially crafted environment" to run. Just running as root is not
enough.

Signed-off-by: Glenn Washburn <development@efficientek.com>
---
 INSTALL | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/INSTALL b/INSTALL
index 2b40cc59227b..a3bb1e365b36 100644
--- a/INSTALL
+++ b/INSTALL
@@ -138,8 +138,8 @@ The simplest way to compile this package is:
 
   2. Type `./bootstrap'.
 
-     The autogen.sh (called by bootstrap) uses python. By default autodetect
-     it, but it can be overridden by setting the PYTHON variable.
+     The autogen.sh (called by bootstrap) uses python. By default it is
+     autodetected, but it can be overridden by setting the PYTHON variable.
 
   3. Type `./configure' to configure the package for your system.
      If you're using `csh' on an old version of System V, you might
@@ -152,8 +152,8 @@ The simplest way to compile this package is:
   4. Type `make' to compile the package.
 
   5. Optionally, type `make check' to run any self-tests that come with
-     the package. Note that many of the tests require root privileges in
-     order to run.
+     the package. Note that many of the tests require root privileges and
+     a specially crafted environment in order to run.
 
   6. Type `make install' to install the programs and any data files and
      documentation.
-- 
2.34.1


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] gitignore: Remove po/*.po and po/LINGUAS

[Glenn Washburn]

po files will now be tracked. This has the following benefits as listed
by Colin Watson:

  * Build processes would no longer be vulnerable to an external server
    potentially going down for an extended period of time; they'd be
    stuck with outdated translations until the server was fixed or came
    up with a workaround, but that's better than nothing.

  * It would be easier to manage branches of stable releases, rather than
    assuming that translations downloaded for master will match the POT
    files for a stable release.

  * Tests would be able to pass from a clean git checkout without relying
    on an external server, improving QA reliability.

  * It would be easier to make and test branches while offline.

  * The translations shipped with a release tarball could be tagged in
    git so that it's easy to investigate bugs in them.

  * Downstream distributors would be able to use git branches without
    having to fill in additional files.

Signed-off-by: Glenn Washburn <development@efficientek.com>
---
 .gitignore | 2 --
 1 file changed, 2 deletions(-)

diff --git a/.gitignore b/.gitignore
index 524f2e6d0070..9e333886c99c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -249,8 +249,6 @@ widthspec.bin
 /pata_test
 /po/*.gmo
 /po/*.mo
-/po/*.po
-/po/LINGUAS
 /po/Makefile.in.in
 /po/Makevars
 /po/Makevars.template
-- 
2.34.1


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] bootstrap: Run linguas.sh in bootstrap epilogue

[Glenn Washburn]

Daniel,

These patches were not meant to be threaded. Let me know if you'd like
me to resend them so they are not threaded.

Glenn

On Sun,  9 Nov 2025 21:04:46 -0600
Glenn Washburn <development@efficientek.com> wrote:

> Heretofore, linguas.sh had to be run by the user and a common mistake
> made when building GRUB was to not run the command. By adding it to
> the bootstrap epilogue it will get run at the end of the bootstrap
> script. The user no longer needs to remember to run it.
> 
> Update INSTALL file to reflect that it is no longer necessary to run
> linguas.sh. Also, fix a list numbering error.
> 
> Fixes: 9f73ebd49be (* INSTALL: Document linguas.sh.)
> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
>  INSTALL        | 17 +++++++----------
>  bootstrap.conf |  4 ++++
>  2 files changed, 11 insertions(+), 10 deletions(-)
> 
> diff --git a/INSTALL b/INSTALL
> index 724584c575e2..2b40cc59227b 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -136,15 +136,12 @@ The simplest way to compile this package is:
>  
>    1. `cd' to the directory containing the package's source code.
>  
> -  2. Skip this and following step if you use release tarball and proceed to
> -     step 4. If you want translations type `./linguas.sh'.
> -  
> -  3. Type `./bootstrap'.
> +  2. Type `./bootstrap'.
>  
>       The autogen.sh (called by bootstrap) uses python. By default autodetect
>       it, but it can be overridden by setting the PYTHON variable.
>  
> -  4. Type `./configure' to configure the package for your system.
> +  3. Type `./configure' to configure the package for your system.
>       If you're using `csh' on an old version of System V, you might
>       need to type `sh ./configure' instead to prevent `csh' from trying
>       to execute `configure' itself.
> @@ -152,19 +149,19 @@ The simplest way to compile this package is:
>       Running `configure' takes awhile.  While running, it prints some
>       messages telling which features it is checking for.
>  
> -  6. Type `make' to compile the package.
> +  4. Type `make' to compile the package.
>  
> -  7. Optionally, type `make check' to run any self-tests that come with
> +  5. Optionally, type `make check' to run any self-tests that come with
>       the package. Note that many of the tests require root privileges in
>       order to run.
>  
> -  8. Type `make install' to install the programs and any data files and
> +  6. Type `make install' to install the programs and any data files and
>       documentation.
>  
> -  9. Type `make html' or `make pdf' to generate the html or pdf
> +  7. Type `make html' or `make pdf' to generate the html or pdf
>       documentation.  Note, these are not built by default.
>  
> - 10. You can remove the program binaries and object files from the
> +  8. You can remove the program binaries and object files from the
>       source code directory by typing `make clean'.  To also remove the
>       files that `configure' created (so you can compile the package for
>       a different kind of computer), type `make distclean'.  There is
> diff --git a/bootstrap.conf b/bootstrap.conf
> index 7a7813d28254..c85905d35c20 100644
> --- a/bootstrap.conf
> +++ b/bootstrap.conf
> @@ -100,4 +100,8 @@ bootstrap_post_import_hook () {
>  
>  bootstrap_epilogue () {
>    mv INSTALL.grub INSTALL
> +
> +  # Update translation files and create LINGUAS file used to determine
> +  # the set of languages used to translate.
> +  ./linguas.sh
>  }

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] gitignore: Remove po/*.po and po/LINGUAS

[Glenn Washburn]

On Sun,  9 Nov 2025 21:04:48 -0600
Glenn Washburn <development@efficientek.com> wrote:

> po files will now be tracked. This has the following benefits as listed
> by Colin Watson:

This should have been done a long time ago[1]. If someone checks out the
2.14 release tag and builds it, they should be able to get the same po
files as were used a the time of release. With the proposed change to
have linguas.sh run as a part of bootstrap[2], this might not exactly
happen because a user building from tag 2.14 will still download the
latest po files by default if they are connected to the internet. But
they could disable that by commenting out the line running linguas.sh
in the bootstrap.conf.

Glenn 

[1]
https://lore.kernel.org/grub-devel/20251109202142.6cbd1fc7@crass-HP-ZBook-15-G2/T/#t
[2]
https://lore.kernel.org/grub-devel/20251109210823.76982257@crass-HP-ZBook-15-G2/T/#t

> 
>   * Build processes would no longer be vulnerable to an external server
>     potentially going down for an extended period of time; they'd be
>     stuck with outdated translations until the server was fixed or came
>     up with a workaround, but that's better than nothing.
> 
>   * It would be easier to manage branches of stable releases, rather than
>     assuming that translations downloaded for master will match the POT
>     files for a stable release.
> 
>   * Tests would be able to pass from a clean git checkout without relying
>     on an external server, improving QA reliability.
> 
>   * It would be easier to make and test branches while offline.
> 
>   * The translations shipped with a release tarball could be tagged in
>     git so that it's easy to investigate bugs in them.
> 
>   * Downstream distributors would be able to use git branches without
>     having to fill in additional files.
> 
> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
>  .gitignore | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/.gitignore b/.gitignore
> index 524f2e6d0070..9e333886c99c 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -249,8 +249,6 @@ widthspec.bin
>  /pata_test
>  /po/*.gmo
>  /po/*.mo
> -/po/*.po
> -/po/LINGUAS
>  /po/Makefile.in.in
>  /po/Makevars
>  /po/Makevars.template

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] INSTALL: Fix a grammatical error

[Sudhakar Kuppusamy]

> On 10 Nov 2025, at 8:34 AM, Glenn Washburn <development@efficientek.com> wrote:
> 
> Also, add more documentation mentioning that the tests require a
> "specially crafted environment" to run. Just running as root is not
> enough.
> 
> Signed-off-by: Glenn Washburn <development@efficientek.com>

Reviewed-by: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>

Thanks,
Sudhakar  
> ---
> INSTALL | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/INSTALL b/INSTALL
> index 2b40cc59227b..a3bb1e365b36 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -138,8 +138,8 @@ The simplest way to compile this package is:
> 
>   2. Type `./bootstrap'.
> 
> -     The autogen.sh (called by bootstrap) uses python. By default autodetect
> -     it, but it can be overridden by setting the PYTHON variable.
> +     The autogen.sh (called by bootstrap) uses python. By default it is
> +     autodetected, but it can be overridden by setting the PYTHON variable.
> 
>   3. Type `./configure' to configure the package for your system.
>      If you're using `csh' on an old version of System V, you might
> @@ -152,8 +152,8 @@ The simplest way to compile this package is:
>   4. Type `make' to compile the package.
> 
>   5. Optionally, type `make check' to run any self-tests that come with
> -     the package. Note that many of the tests require root privileges in
> -     order to run.
> +     the package. Note that many of the tests require root privileges and
> +     a specially crafted environment in order to run.
> 
>   6. Type `make install' to install the programs and any data files and
>      documentation.
> -- 
> 2.34.1
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] bootstrap: Run linguas.sh in bootstrap epilogue

[Mike Gilbert]

On Sun, Nov 9, 2025 at 10:08 PM Glenn Washburn
<development@efficientek.com> wrote:
>
> Daniel,
>
> These patches were not meant to be threaded. Let me know if you'd like
> me to resend them so they are not threaded.
>
> Glenn
>
> On Sun,  9 Nov 2025 21:04:46 -0600
> Glenn Washburn <development@efficientek.com> wrote:
>
> > Heretofore, linguas.sh had to be run by the user and a common mistake
> > made when building GRUB was to not run the command. By adding it to
> > the bootstrap epilogue it will get run at the end of the bootstrap
> > script. The user no longer needs to remember to run it.
> >
> > Update INSTALL file to reflect that it is no longer necessary to run
> > linguas.sh. Also, fix a list numbering error.
> >
> > Fixes: 9f73ebd49be (* INSTALL: Document linguas.sh.)
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
> > ---
> >  INSTALL        | 17 +++++++----------
> >  bootstrap.conf |  4 ++++
> >  2 files changed, 11 insertions(+), 10 deletions(-)
> >
> > diff --git a/INSTALL b/INSTALL
> > index 724584c575e2..2b40cc59227b 100644
> > --- a/INSTALL
> > +++ b/INSTALL
> > @@ -136,15 +136,12 @@ The simplest way to compile this package is:
> >
> >    1. `cd' to the directory containing the package's source code.
> >
> > -  2. Skip this and following step if you use release tarball and proceed to
> > -     step 4. If you want translations type `./linguas.sh'.
> > -
> > -  3. Type `./bootstrap'.
> > +  2. Type `./bootstrap'.
> >
> >       The autogen.sh (called by bootstrap) uses python. By default autodetect
> >       it, but it can be overridden by setting the PYTHON variable.
> >
> > -  4. Type `./configure' to configure the package for your system.
> > +  3. Type `./configure' to configure the package for your system.
> >       If you're using `csh' on an old version of System V, you might
> >       need to type `sh ./configure' instead to prevent `csh' from trying
> >       to execute `configure' itself.
> > @@ -152,19 +149,19 @@ The simplest way to compile this package is:
> >       Running `configure' takes awhile.  While running, it prints some
> >       messages telling which features it is checking for.
> >
> > -  6. Type `make' to compile the package.
> > +  4. Type `make' to compile the package.
> >
> > -  7. Optionally, type `make check' to run any self-tests that come with
> > +  5. Optionally, type `make check' to run any self-tests that come with
> >       the package. Note that many of the tests require root privileges in
> >       order to run.
> >
> > -  8. Type `make install' to install the programs and any data files and
> > +  6. Type `make install' to install the programs and any data files and
> >       documentation.
> >
> > -  9. Type `make html' or `make pdf' to generate the html or pdf
> > +  7. Type `make html' or `make pdf' to generate the html or pdf
> >       documentation.  Note, these are not built by default.
> >
> > - 10. You can remove the program binaries and object files from the
> > +  8. You can remove the program binaries and object files from the
> >       source code directory by typing `make clean'.  To also remove the
> >       files that `configure' created (so you can compile the package for
> >       a different kind of computer), type `make distclean'.  There is
> > diff --git a/bootstrap.conf b/bootstrap.conf
> > index 7a7813d28254..c85905d35c20 100644
> > --- a/bootstrap.conf
> > +++ b/bootstrap.conf
> > @@ -100,4 +100,8 @@ bootstrap_post_import_hook () {
> >
> >  bootstrap_epilogue () {
> >    mv INSTALL.grub INSTALL
> > +
> > +  # Update translation files and create LINGUAS file used to determine
> > +  # the set of languages used to translate.
> > +  ./linguas.sh
> >  }

Could you add some way to disable calling linguas.sh, or some way to
disable the rsync call?

In the grub-9999 package for Gentoo Linux, we call bootstrap in a
context which does not permit network access. We pre-fetch gnulib in
an earlier phase of the build process.

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] bootstrap: Run linguas.sh in bootstrap epilogue

[Glenn Washburn]

On Mon, 10 Nov 2025 12:09:32 -0500
Mike Gilbert <floppym@gentoo.org> wrote:

> On Sun, Nov 9, 2025 at 10:08 PM Glenn Washburn
> <development@efficientek.com> wrote:
> >
> > Daniel,
> >
> > These patches were not meant to be threaded. Let me know if you'd like
> > me to resend them so they are not threaded.
> >
> > Glenn
> >
> > On Sun,  9 Nov 2025 21:04:46 -0600
> > Glenn Washburn <development@efficientek.com> wrote:
> >
> > > Heretofore, linguas.sh had to be run by the user and a common mistake
> > > made when building GRUB was to not run the command. By adding it to
> > > the bootstrap epilogue it will get run at the end of the bootstrap
> > > script. The user no longer needs to remember to run it.
> > >
> > > Update INSTALL file to reflect that it is no longer necessary to run
> > > linguas.sh. Also, fix a list numbering error.
> > >
> > > Fixes: 9f73ebd49be (* INSTALL: Document linguas.sh.)
> > > Signed-off-by: Glenn Washburn <development@efficientek.com>
> > > ---
> > >  INSTALL        | 17 +++++++----------
> > >  bootstrap.conf |  4 ++++
> > >  2 files changed, 11 insertions(+), 10 deletions(-)
> > >
> > > diff --git a/INSTALL b/INSTALL
> > > index 724584c575e2..2b40cc59227b 100644
> > > --- a/INSTALL
> > > +++ b/INSTALL
> > > @@ -136,15 +136,12 @@ The simplest way to compile this package is:
> > >
> > >    1. `cd' to the directory containing the package's source code.
> > >
> > > -  2. Skip this and following step if you use release tarball and proceed to
> > > -     step 4. If you want translations type `./linguas.sh'.
> > > -
> > > -  3. Type `./bootstrap'.
> > > +  2. Type `./bootstrap'.
> > >
> > >       The autogen.sh (called by bootstrap) uses python. By default autodetect
> > >       it, but it can be overridden by setting the PYTHON variable.
> > >
> > > -  4. Type `./configure' to configure the package for your system.
> > > +  3. Type `./configure' to configure the package for your system.
> > >       If you're using `csh' on an old version of System V, you might
> > >       need to type `sh ./configure' instead to prevent `csh' from trying
> > >       to execute `configure' itself.
> > > @@ -152,19 +149,19 @@ The simplest way to compile this package is:
> > >       Running `configure' takes awhile.  While running, it prints some
> > >       messages telling which features it is checking for.
> > >
> > > -  6. Type `make' to compile the package.
> > > +  4. Type `make' to compile the package.
> > >
> > > -  7. Optionally, type `make check' to run any self-tests that come with
> > > +  5. Optionally, type `make check' to run any self-tests that come with
> > >       the package. Note that many of the tests require root privileges in
> > >       order to run.
> > >
> > > -  8. Type `make install' to install the programs and any data files and
> > > +  6. Type `make install' to install the programs and any data files and
> > >       documentation.
> > >
> > > -  9. Type `make html' or `make pdf' to generate the html or pdf
> > > +  7. Type `make html' or `make pdf' to generate the html or pdf
> > >       documentation.  Note, these are not built by default.
> > >
> > > - 10. You can remove the program binaries and object files from the
> > > +  8. You can remove the program binaries and object files from the
> > >       source code directory by typing `make clean'.  To also remove the
> > >       files that `configure' created (so you can compile the package for
> > >       a different kind of computer), type `make distclean'.  There is
> > > diff --git a/bootstrap.conf b/bootstrap.conf
> > > index 7a7813d28254..c85905d35c20 100644
> > > --- a/bootstrap.conf
> > > +++ b/bootstrap.conf
> > > @@ -100,4 +100,8 @@ bootstrap_post_import_hook () {
> > >
> > >  bootstrap_epilogue () {
> > >    mv INSTALL.grub INSTALL
> > > +
> > > +  # Update translation files and create LINGUAS file used to determine
> > > +  # the set of languages used to translate.
> > > +  ./linguas.sh
> > >  }
> 
> Could you add some way to disable calling linguas.sh, or some way to
> disable the rsync call?

Actually, it just came to me a good way to disable the whole thing,
which I think is what should be done. This will be able to be disabled
via the existing --skip-po option to bootstrap.

> In the grub-9999 package for Gentoo Linux, we call bootstrap in a
> context which does not permit network access. We pre-fetch gnulib in
> an earlier phase of the build process.

If this is the case, then I don't see a problem with this patch as is.
The rsync will try to run and fail to connect. linguas.sh is not run
with set -e, so the script will continue and create the LINGUAS. If you
have run linguas.sh in an earlier pre-fetch stage, running it again
with an rsync failure will not change anything. The LINGUAS file will
be recreated, but it should be the same as the one that already exists
from the pre-fetch stage.

The reason I want a way to disable all of linguas.sh is for the case
where one _does_ have network access, but wants to use existing po
files. This is for the future where hopefully po files will be tracked
in the repo and someone wants to checkout, say 2.14, and build with the
po files at release time.

Glenn

> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel