* [PATCH] gitignore: Remove po/*.po and po/LINGUAS
@ 2025-11-11 7:15 Glenn Washburn
0 siblings, 0 replies; 3+ messages in thread
From: Glenn Washburn @ 2025-11-11 7:15 UTC (permalink / raw)
To: grub-devel; +Cc: Daniel Kiper, Glenn Washburn
po files will now be tracked. This has the following benefits as listed
by Colin Watson:
* Build processes would no longer be vulnerable to an external server
potentially going down for an extended period of time; they'd be
stuck with outdated translations until the server was fixed or came
up with a workaround, but that's better than nothing.
* It would be easier to manage branches of stable releases, rather than
assuming that translations downloaded for master will match the POT
files for a stable release.
* Tests would be able to pass from a clean git checkout without relying
on an external server, improving QA reliability.
* It would be easier to make and test branches while offline.
* The translations shipped with a release tarball could be tagged in
git so that it's easy to investigate bugs in them.
* Downstream distributors would be able to use git branches without
having to fill in additional files.
Signed-off-by: Glenn Washburn <development@efficientek.com>
---
Resending this patch alone as it was accidentally added to a previous patch
series that it should not have been a part of.
Glenn
---
.gitignore | 2 --
1 file changed, 2 deletions(-)
diff --git a/.gitignore b/.gitignore
index 524f2e6d0070..9e333886c99c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -249,8 +249,6 @@ widthspec.bin
/pata_test
/po/*.gmo
/po/*.mo
-/po/*.po
-/po/LINGUAS
/po/Makefile.in.in
/po/Makevars
/po/Makevars.template
--
2.34.1
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] bootstrap: Run linguas.sh in bootstrap epilogue
@ 2025-11-10 3:04 Glenn Washburn
2025-11-10 3:04 ` [PATCH] gitignore: Remove po/*.po and po/LINGUAS Glenn Washburn
0 siblings, 1 reply; 3+ messages in thread
From: Glenn Washburn @ 2025-11-10 3:04 UTC (permalink / raw)
To: grub-devel; +Cc: Daniel Kiper, Glenn Washburn
Heretofore, linguas.sh had to be run by the user and a common mistake
made when building GRUB was to not run the command. By adding it to
the bootstrap epilogue it will get run at the end of the bootstrap
script. The user no longer needs to remember to run it.
Update INSTALL file to reflect that it is no longer necessary to run
linguas.sh. Also, fix a list numbering error.
Fixes: 9f73ebd49be (* INSTALL: Document linguas.sh.)
Signed-off-by: Glenn Washburn <development@efficientek.com>
---
INSTALL | 17 +++++++----------
bootstrap.conf | 4 ++++
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/INSTALL b/INSTALL
index 724584c575e2..2b40cc59227b 100644
--- a/INSTALL
+++ b/INSTALL
@@ -136,15 +136,12 @@ The simplest way to compile this package is:
1. `cd' to the directory containing the package's source code.
- 2. Skip this and following step if you use release tarball and proceed to
- step 4. If you want translations type `./linguas.sh'.
-
- 3. Type `./bootstrap'.
+ 2. Type `./bootstrap'.
The autogen.sh (called by bootstrap) uses python. By default autodetect
it, but it can be overridden by setting the PYTHON variable.
- 4. Type `./configure' to configure the package for your system.
+ 3. Type `./configure' to configure the package for your system.
If you're using `csh' on an old version of System V, you might
need to type `sh ./configure' instead to prevent `csh' from trying
to execute `configure' itself.
@@ -152,19 +149,19 @@ The simplest way to compile this package is:
Running `configure' takes awhile. While running, it prints some
messages telling which features it is checking for.
- 6. Type `make' to compile the package.
+ 4. Type `make' to compile the package.
- 7. Optionally, type `make check' to run any self-tests that come with
+ 5. Optionally, type `make check' to run any self-tests that come with
the package. Note that many of the tests require root privileges in
order to run.
- 8. Type `make install' to install the programs and any data files and
+ 6. Type `make install' to install the programs and any data files and
documentation.
- 9. Type `make html' or `make pdf' to generate the html or pdf
+ 7. Type `make html' or `make pdf' to generate the html or pdf
documentation. Note, these are not built by default.
- 10. You can remove the program binaries and object files from the
+ 8. You can remove the program binaries and object files from the
source code directory by typing `make clean'. To also remove the
files that `configure' created (so you can compile the package for
a different kind of computer), type `make distclean'. There is
diff --git a/bootstrap.conf b/bootstrap.conf
index 7a7813d28254..c85905d35c20 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -100,4 +100,8 @@ bootstrap_post_import_hook () {
bootstrap_epilogue () {
mv INSTALL.grub INSTALL
+
+ # Update translation files and create LINGUAS file used to determine
+ # the set of languages used to translate.
+ ./linguas.sh
}
--
2.34.1
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] gitignore: Remove po/*.po and po/LINGUAS
2025-11-10 3:04 [PATCH] bootstrap: Run linguas.sh in bootstrap epilogue Glenn Washburn
@ 2025-11-10 3:04 ` Glenn Washburn
2025-11-10 3:17 ` Glenn Washburn
0 siblings, 1 reply; 3+ messages in thread
From: Glenn Washburn @ 2025-11-10 3:04 UTC (permalink / raw)
To: grub-devel; +Cc: Daniel Kiper, Glenn Washburn
po files will now be tracked. This has the following benefits as listed
by Colin Watson:
* Build processes would no longer be vulnerable to an external server
potentially going down for an extended period of time; they'd be
stuck with outdated translations until the server was fixed or came
up with a workaround, but that's better than nothing.
* It would be easier to manage branches of stable releases, rather than
assuming that translations downloaded for master will match the POT
files for a stable release.
* Tests would be able to pass from a clean git checkout without relying
on an external server, improving QA reliability.
* It would be easier to make and test branches while offline.
* The translations shipped with a release tarball could be tagged in
git so that it's easy to investigate bugs in them.
* Downstream distributors would be able to use git branches without
having to fill in additional files.
Signed-off-by: Glenn Washburn <development@efficientek.com>
---
.gitignore | 2 --
1 file changed, 2 deletions(-)
diff --git a/.gitignore b/.gitignore
index 524f2e6d0070..9e333886c99c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -249,8 +249,6 @@ widthspec.bin
/pata_test
/po/*.gmo
/po/*.mo
-/po/*.po
-/po/LINGUAS
/po/Makefile.in.in
/po/Makevars
/po/Makevars.template
--
2.34.1
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gitignore: Remove po/*.po and po/LINGUAS
2025-11-10 3:04 ` [PATCH] gitignore: Remove po/*.po and po/LINGUAS Glenn Washburn
@ 2025-11-10 3:17 ` Glenn Washburn
0 siblings, 0 replies; 3+ messages in thread
From: Glenn Washburn @ 2025-11-10 3:17 UTC (permalink / raw)
To: grub-devel; +Cc: Daniel Kiper
On Sun, 9 Nov 2025 21:04:48 -0600
Glenn Washburn <development@efficientek.com> wrote:
> po files will now be tracked. This has the following benefits as listed
> by Colin Watson:
This should have been done a long time ago[1]. If someone checks out the
2.14 release tag and builds it, they should be able to get the same po
files as were used a the time of release. With the proposed change to
have linguas.sh run as a part of bootstrap[2], this might not exactly
happen because a user building from tag 2.14 will still download the
latest po files by default if they are connected to the internet. But
they could disable that by commenting out the line running linguas.sh
in the bootstrap.conf.
Glenn
[1]
https://lore.kernel.org/grub-devel/20251109202142.6cbd1fc7@crass-HP-ZBook-15-G2/T/#t
[2]
https://lore.kernel.org/grub-devel/20251109210823.76982257@crass-HP-ZBook-15-G2/T/#t
>
> * Build processes would no longer be vulnerable to an external server
> potentially going down for an extended period of time; they'd be
> stuck with outdated translations until the server was fixed or came
> up with a workaround, but that's better than nothing.
>
> * It would be easier to manage branches of stable releases, rather than
> assuming that translations downloaded for master will match the POT
> files for a stable release.
>
> * Tests would be able to pass from a clean git checkout without relying
> on an external server, improving QA reliability.
>
> * It would be easier to make and test branches while offline.
>
> * The translations shipped with a release tarball could be tagged in
> git so that it's easy to investigate bugs in them.
>
> * Downstream distributors would be able to use git branches without
> having to fill in additional files.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
> .gitignore | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/.gitignore b/.gitignore
> index 524f2e6d0070..9e333886c99c 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -249,8 +249,6 @@ widthspec.bin
> /pata_test
> /po/*.gmo
> /po/*.mo
> -/po/*.po
> -/po/LINGUAS
> /po/Makefile.in.in
> /po/Makevars
> /po/Makevars.template
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-11 7:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-11 7:15 [PATCH] gitignore: Remove po/*.po and po/LINGUAS Glenn Washburn
-- strict thread matches above, loose matches on Subject: below --
2025-11-10 3:04 [PATCH] bootstrap: Run linguas.sh in bootstrap epilogue Glenn Washburn
2025-11-10 3:04 ` [PATCH] gitignore: Remove po/*.po and po/LINGUAS Glenn Washburn
2025-11-10 3:17 ` Glenn Washburn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).