* [PATCH v2] linguas: Ensure that linguas.sh runs from the directory that it resides
@ 2025-11-17 4:23 Glenn Washburn
2025-11-17 17:41 ` Daniel Kiper
0 siblings, 1 reply; 2+ messages in thread
From: Glenn Washburn @ 2025-11-17 4:23 UTC (permalink / raw)
To: grub-devel; +Cc: Daniel Kiper, Glenn Washburn
The script assumes that it is run from the root of the source tree,
which is where it is located. So this should be enforced to prevent
accidental misuses.
realpath is used instead of readlink as that is recommended in Debian's
readlink manpage since at least Debian 11. Also, use the shell variable's
parameter expansion for removing a suffix pattern to get the directory
in which the script resides. This is preferable to using the dirname binary
as it avoids creating a new process.
Signed-off-by: Glenn Washburn <development@efficientek.com>
---
linguas.sh | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/linguas.sh b/linguas.sh
index b95ad4f7d9c2..45cdf2ac14ac 100755
--- a/linguas.sh
+++ b/linguas.sh
@@ -1,5 +1,10 @@
#!/bin/sh
+SDIR=$(realpath -e "$0")
+SDIR=${SDIR%/*}
+
+cd "$SDIR"
+
rsync -Lrtvz translationproject.org::tp/latest/grub/ po
autogenerated="en@quot en@hebrew de@hebrew en@cyrillic en@greek en@arabic en@piglatin de_CH"
--
2.34.1
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] linguas: Ensure that linguas.sh runs from the directory that it resides
2025-11-17 4:23 [PATCH v2] linguas: Ensure that linguas.sh runs from the directory that it resides Glenn Washburn
@ 2025-11-17 17:41 ` Daniel Kiper
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Kiper @ 2025-11-17 17:41 UTC (permalink / raw)
To: Glenn Washburn; +Cc: grub-devel
On Sun, Nov 16, 2025 at 10:23:41PM -0600, Glenn Washburn wrote:
> The script assumes that it is run from the root of the source tree,
> which is where it is located. So this should be enforced to prevent
> accidental misuses.
>
> realpath is used instead of readlink as that is recommended in Debian's
> readlink manpage since at least Debian 11. Also, use the shell variable's
> parameter expansion for removing a suffix pattern to get the directory
> in which the script resides. This is preferable to using the dirname binary
> as it avoids creating a new process.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-17 17:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-17 4:23 [PATCH v2] linguas: Ensure that linguas.sh runs from the directory that it resides Glenn Washburn
2025-11-17 17:41 ` Daniel Kiper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox