public inbox for grub-devel@gnu.org
 help / color / mirror / Atom feed
* [PATCH] tests: Fix nonnative tests labeled as native
@ 2025-11-21  5:29 Glenn Washburn
  2025-11-21 14:40 ` Sudhakar Kuppusamy
  2025-11-21 18:29 ` Daniel Kiper
  0 siblings, 2 replies; 3+ messages in thread
From: Glenn Washburn @ 2025-11-21  5:29 UTC (permalink / raw)
  To: grub-devel; +Cc: Daniel Kiper, Glenn Washburn

The tests asn1_test and tpm2_key_protector_test should be labelled as
nonnative tests because they run tests on the target. A clue that
indicates a nonnative test is the usage of the grub-shell script.

Signed-off-by: Glenn Washburn <development@efficientek.com>
---
 Makefile.util.def | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile.util.def b/Makefile.util.def
index e59f08f57917..04146ff037db 100644
--- a/Makefile.util.def
+++ b/Makefile.util.def
@@ -1300,13 +1300,13 @@ script = {
 };
 
 script = {
-  testcase = native;
+  testcase = nonnative;
   name = asn1_test;
   common = tests/asn1_test.in;
 };
 
 script = {
-  testcase = native;
+  testcase = nonnative;
   name = tpm2_key_protector_test;
   common = tests/tpm2_key_protector_test.in;
 };
-- 
2.34.1


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] tests: Fix nonnative tests labeled as native
  2025-11-21  5:29 [PATCH] tests: Fix nonnative tests labeled as native Glenn Washburn
@ 2025-11-21 14:40 ` Sudhakar Kuppusamy
  2025-11-21 18:29 ` Daniel Kiper
  1 sibling, 0 replies; 3+ messages in thread
From: Sudhakar Kuppusamy @ 2025-11-21 14:40 UTC (permalink / raw)
  To: The development of GNU GRUB; +Cc: Daniel Kiper, Glenn Washburn



> On 21 Nov 2025, at 10:59 AM, Glenn Washburn <development@efficientek.com> wrote:
> 
> The tests asn1_test and tpm2_key_protector_test should be labelled as
> nonnative tests because they run tests on the target. A clue that
> indicates a nonnative test is the usage of the grub-shell script.
> 
> Signed-off-by: Glenn Washburn <development@efficientek.com>

Reviewed-by: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>

Thanks,
Sudhakar
  
> ---
> Makefile.util.def | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile.util.def b/Makefile.util.def
> index e59f08f57917..04146ff037db 100644
> --- a/Makefile.util.def
> +++ b/Makefile.util.def
> @@ -1300,13 +1300,13 @@ script = {
> };
> 
> script = {
> -  testcase = native;
> +  testcase = nonnative;
>   name = asn1_test;
>   common = tests/asn1_test.in;
> };
> 
> script = {
> -  testcase = native;
> +  testcase = nonnative;
>   name = tpm2_key_protector_test;
>   common = tests/tpm2_key_protector_test.in;
> };
> -- 
> 2.34.1
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tests: Fix nonnative tests labeled as native
  2025-11-21  5:29 [PATCH] tests: Fix nonnative tests labeled as native Glenn Washburn
  2025-11-21 14:40 ` Sudhakar Kuppusamy
@ 2025-11-21 18:29 ` Daniel Kiper
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Kiper @ 2025-11-21 18:29 UTC (permalink / raw)
  To: Glenn Washburn; +Cc: grub-devel

On Thu, Nov 20, 2025 at 11:29:41PM -0600, Glenn Washburn wrote:
> The tests asn1_test and tpm2_key_protector_test should be labelled as
> nonnative tests because they run tests on the target. A clue that
> indicates a nonnative test is the usage of the grub-shell script.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-11-22  8:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-21  5:29 [PATCH] tests: Fix nonnative tests labeled as native Glenn Washburn
2025-11-21 14:40 ` Sudhakar Kuppusamy
2025-11-21 18:29 ` Daniel Kiper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox