public inbox for grub-devel@gnu.org
 help / color / mirror / Atom feed
* [PATCH grub] tests/util/grub-fs-tester: Use CSMACINTOSH encoding instead of macroman
@ 2025-12-12  6:23 Glenn Washburn
  2025-12-20 14:05 ` Daniel Kiper
  0 siblings, 1 reply; 2+ messages in thread
From: Glenn Washburn @ 2025-12-12  6:23 UTC (permalink / raw)
  To: grub-devel
  Cc: Daniel Kiper, Vladimir 'phcoder' Serbinenko,
	Glenn Washburn

From Debian 12 to 13, recode had a major overhaul and now does not support
the macroman encoding. Its unclear if this is a bug or intentional.
Regardless, use the CSMACINTOSH encoding instead as MacRoman and it are
aliases and CSMACINTOSH is supported on both Debian 12 and 13.

Signed-off-by: Glenn Washburn <development@efficientek.com>
---
 tests/util/grub-fs-tester.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in
index 7199322c61d5..1f80e8203ffa 100644
--- a/tests/util/grub-fs-tester.in
+++ b/tests/util/grub-fs-tester.in
@@ -743,7 +743,9 @@ for LOGSECSIZE in $(range "$MINLOGSECSIZE" "$MAXLOGSECSIZE" 1); do
 		    dd if=/dev/urandom of="${MOUNTDEVICE}" bs=1 seek=$((0x468)) conv=notrunc count=8
 		    MOUNTFS="hfsplus";;
 		x"hfs")
-		    "mkfs.hfs" -b $BLKSIZE -v "`echo $FSLABEL |recode utf8..macroman`" -h "${MOUNTDEVICE}"
+		    # CSMACINTOSH is an alias for MacRoman which is the
+		    # encoding used on HFS
+		    "mkfs.hfs" -b $BLKSIZE -v "`echo $FSLABEL | recode utf8..CSMACINTOSH`" -h "${MOUNTDEVICE}"
 		    dd if=/dev/urandom of="${MOUNTDEVICE}" bs=1 seek=$((0x474)) conv=notrunc count=8
 		    MOUNTOPTS="iocharset=utf8,codepage=macroman,"
 		    ;;
-- 
2.34.1


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH grub] tests/util/grub-fs-tester: Use CSMACINTOSH encoding instead of macroman
  2025-12-12  6:23 [PATCH grub] tests/util/grub-fs-tester: Use CSMACINTOSH encoding instead of macroman Glenn Washburn
@ 2025-12-20 14:05 ` Daniel Kiper
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Kiper @ 2025-12-20 14:05 UTC (permalink / raw)
  To: Glenn Washburn; +Cc: grub-devel, Vladimir 'phcoder' Serbinenko

On Fri, Dec 12, 2025 at 12:23:49AM -0600, Glenn Washburn wrote:
> From Debian 12 to 13, recode had a major overhaul and now does not support
> the macroman encoding. Its unclear if this is a bug or intentional.
> Regardless, use the CSMACINTOSH encoding instead as MacRoman and it are
> aliases and CSMACINTOSH is supported on both Debian 12 and 13.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-20 14:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-12  6:23 [PATCH grub] tests/util/grub-fs-tester: Use CSMACINTOSH encoding instead of macroman Glenn Washburn
2025-12-20 14:05 ` Daniel Kiper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox