public inbox for grub-devel@gnu.org
 help / color / mirror / Atom feed
From: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>
To: grub-devel@gnu.org
Cc: daniel.kiper@oracle.com, sridharm@linux.ibm.com,
	ssrish@linux.ibm.com, mlewando@redhat.com, phcoder@gmail.com,
	Sudhakar Kuppusamy <sudhakar@linux.ibm.com>,
	stefanb@linux.ibm.com,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Subject: [PATCH] powerpc_ieee1275: Excluding the PKS for grub-emu on 32-bit PowerPC
Date: Fri, 27 Feb 2026 19:11:43 +0530	[thread overview]
Message-ID: <20260227134143.72746-1-sudhakar@linux.ibm.com> (raw)

Configuring the build with --with-platform=emu fails on 32-bit PowerPC with:

/usr/bin/ld: appendedsig.module: in function `grub_mod_init':
/home/glaubitz/grub/grub-core/commands/appendedsig/appendedsig.c:1615:(.text+0x2ab4): undefined reference to `grub_pks_get_keystore'
/usr/bin/ld: appendedsig.module: in function `create_dbs_from_pks':
/home/glaubitz/grub/grub-core/commands/appendedsig/appendedsig.c:1400:(.text+0x2c3c): undefined reference to `grub_pks_free_data'
collect2: error: ld returned 1 exit status

Fixing this by excluding the Platform Keystore (PKS) for grub-emu on 32-bit PowerPC.

Reported-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Signed-off-by: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>
---
 include/grub/powerpc/ieee1275/platform_keystore.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/grub/powerpc/ieee1275/platform_keystore.h b/include/grub/powerpc/ieee1275/platform_keystore.h
index 931ada224..3bfb594a3 100644
--- a/include/grub/powerpc/ieee1275/platform_keystore.h
+++ b/include/grub/powerpc/ieee1275/platform_keystore.h
@@ -96,7 +96,7 @@ struct grub_pks
 };
 typedef struct grub_pks grub_pks_t;
 
-#if defined(__powerpc__)
+#if defined(__powerpc__) && !(GRUB_MACHINE_EMU)
 /* Initialization of the Platform Keystore. */
 extern void
 grub_pks_keystore_init (void);
-- 
2.50.1 (Apple Git-155)


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

             reply	other threads:[~2026-02-27 13:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 13:41 Sudhakar Kuppusamy [this message]
2026-02-27 21:29 ` [PATCH] powerpc_ieee1275: Excluding the PKS for grub-emu on 32-bit PowerPC John Paul Adrian Glaubitz
2026-02-27 21:52   ` John Paul Adrian Glaubitz
2026-03-03 15:18     ` Sudhakar Kuppusamy
2026-02-27 22:19 ` Vladimir 'phcoder' Serbinenko
2026-03-03 15:20   ` Sudhakar Kuppusamy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260227134143.72746-1-sudhakar@linux.ibm.com \
    --to=sudhakar@linux.ibm.com \
    --cc=daniel.kiper@oracle.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=grub-devel@gnu.org \
    --cc=mlewando@redhat.com \
    --cc=phcoder@gmail.com \
    --cc=sridharm@linux.ibm.com \
    --cc=ssrish@linux.ibm.com \
    --cc=stefanb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox